Skip to content

fix(kanban): use localized column label in select-all aria label#23659

Closed
smwbev wants to merge 1 commit into
NousResearch:mainfrom
smwbev:fix/kanban-column-label-aria
Closed

fix(kanban): use localized column label in select-all aria label#23659
smwbev wants to merge 1 commit into
NousResearch:mainfrom
smwbev:fix/kanban-column-label-aria

Conversation

@smwbev

@smwbev smwbev commented May 11, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes a Kanban dashboard render crash caused by a stale COLUMN_LABEL reference in the column select-all checkbox aria label.

The dashboard now computes colLabel through getColumnLabel(t, props.column.name), which supports the current i18n fallback path. Reusing that value avoids referencing the removed COLUMN_LABEL object and keeps the accessible label aligned with the rendered column title.

Before this change, opening the Kanban dashboard could fail with:

ReferenceError: COLUMN_LABEL is not defined

Related Issue

Fixes #23620.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • plugins/kanban/dashboard/dist/index.js
    • Replaces the stale COLUMN_LABEL[props.column.name] lookup with the already computed colLabel fallback for the select-all checkbox aria-label.

How to Test

  1. Start the dashboard and open the Kanban tab.
  2. Confirm the board renders instead of showing the plugin render error.
  3. Confirm the column select-all checkboxes have accessible labels such as Select all tasks in Triage.
  4. Run validation commands:
node --check plugins/kanban/dashboard/dist/index.js
python -m pytest tests/plugins/test_kanban_dashboard_plugin.py -q -o 'addopts='

Validated locally:

node --check plugins/kanban/dashboard/dist/index.js
# no output, exit code 0

python -m pytest tests/plugins/test_kanban_dashboard_plugin.py -q -o 'addopts='
# 81 passed

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: Ubuntu 24.04 / Linux, dashboard served locally

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

Before:

KANBAN TAB HIT A RENDERING ERROR
COLUMN_LABEL is not defined

After:

  • Kanban tab renders successfully.
  • Browser console shows no JavaScript errors.
  • Column select-all checkbox labels render from the localized/fallback column label.

@alt-glitch alt-glitch added type/bug Something isn't working comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have labels May 11, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #23637 — same fix for the COLUMN_LABEL ReferenceError in kanban dashboard select-all aria-label (issue #23620). Both use a localized fallback; #23637 was opened first.

@smwbev

smwbev commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for checking — I missed #23637 when preparing this. Closing this PR as a duplicate.

For context, this version reused the already computed colLabel from getColumnLabel(t, props.column.name) so the aria label stays aligned with the rendered column title, but #23637 fixes the same underlying COLUMN_LABEL ReferenceError and was opened first.

@smwbev

smwbev commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

Update after the duplicate/superseded discussion: I previously said I would close this as a duplicate of #23637, but #23637 has now been marked as superseded by this PR because this version uses the existing colLabel value from getColumnLabel(t, props.column.name) rather than directly reading FALLBACK_COLUMN_LABEL.

I will leave #23659 open for maintainers and updated the PR body to reference Fixes #23620.

kshitijk4poor added a commit that referenced this pull request May 11, 2026
For PRs #23206 (Frowtek), #23252 (Sylw3ster), #23358 (dmnkhorvath),
#23659 (smwbev), and #23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
@kshitijk4poor

Copy link
Copy Markdown
Collaborator

Merged via salvage PR #23791. Your commits were cherry-picked onto current main with your authorship preserved in git log. Thanks for the fix!

rmulligan pushed a commit to rmulligan/hermes-agent that referenced this pull request May 11, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
JinyuID pushed a commit to JinyuID/hermes-agent that referenced this pull request May 11, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
jsboige pushed a commit to jsboige/hermes-agent that referenced this pull request May 14, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
AlexFoxD pushed a commit to AlexFoxD/hermes-agent that referenced this pull request May 21, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
Seven74AI pushed a commit to Seven74AI/hermes-agent that referenced this pull request Jun 13, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Kanban dashboard: COLUMN_LABEL undefined in aria-label at column select-all checkbox

3 participants