fix(kanban): use localized column label in select-all aria label#23659
fix(kanban): use localized column label in select-all aria label#23659smwbev wants to merge 1 commit into
Conversation
|
Thanks for checking — I missed #23637 when preparing this. Closing this PR as a duplicate. For context, this version reused the already computed |
|
Update after the duplicate/superseded discussion: I previously said I would close this as a duplicate of #23637, but #23637 has now been marked as superseded by this PR because this version uses the existing I will leave #23659 open for maintainers and updated the PR body to reference |
|
Merged via salvage PR #23791. Your commits were cherry-picked onto current main with your authorship preserved in git log. Thanks for the fix! |
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
What does this PR do?
Fixes a Kanban dashboard render crash caused by a stale
COLUMN_LABELreference in the column select-all checkbox aria label.The dashboard now computes
colLabelthroughgetColumnLabel(t, props.column.name), which supports the current i18n fallback path. Reusing that value avoids referencing the removedCOLUMN_LABELobject and keeps the accessible label aligned with the rendered column title.Before this change, opening the Kanban dashboard could fail with:
Related Issue
Fixes #23620.
Type of Change
Changes Made
plugins/kanban/dashboard/dist/index.jsCOLUMN_LABEL[props.column.name]lookup with the already computedcolLabelfallback for the select-all checkboxaria-label.How to Test
Select all tasks in Triage.node --check plugins/kanban/dashboard/dist/index.js python -m pytest tests/plugins/test_kanban_dashboard_plugin.py -q -o 'addopts='Validated locally:
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Before:
After: