fix(kanban): use FALLBACK_COLUMN_LABEL in column select-all aria-label#23637
Closed
liuhao1024 wants to merge 1 commit into
Closed
fix(kanban): use FALLBACK_COLUMN_LABEL in column select-all aria-label#23637liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
The i18n refactor (c391684) renamed COLUMN_LABEL to FALLBACK_COLUMN_LABEL but missed the aria-label reference at line 1901 of plugins/kanban/dashboard/dist/index.js. This caused a ReferenceError: COLUMN_LABEL is not defined when rendering the column select-all checkbox. Fixes NousResearch#23620
19 tasks
Collaborator
|
Merged via salvage PR #23791 using #23659's implementation. Your fix correctly identified the undefined bug and used — but #23659's use of the already-in-scope variable is i18n-aware (it matches the visible column label on line 1911). Thanks for the contribution — your finding helped confirm the bug! |
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
ReferenceError: COLUMN_LABEL is not definedin the Kanban dashboard's column select-all checkbox.Root Cause
The i18n refactor in commit
c39168453renamedCOLUMN_LABELtoFALLBACK_COLUMN_LABELbut missed one reference at line 1901 ofplugins/kanban/dashboard/dist/index.js— thearia-labelattribute of the column header checkbox.Fix
Changed
COLUMN_LABEL→FALLBACK_COLUMN_LABELon the single affected line. All other references (lines 59, 97) already use the correct name.Testing
COLUMN_LABELreferences now useFALLBACK_COLUMN_LABELFixes #23620