fix(kanban): restore HERMES_KANBAN_BOARD after scoped slash override#23252
Closed
Sylw3ster wants to merge 1 commit into
Closed
fix(kanban): restore HERMES_KANBAN_BOARD after scoped slash override#23252Sylw3ster wants to merge 1 commit into
Sylw3ster wants to merge 1 commit into
Conversation
kshitijk4poor
added a commit
that referenced
this pull request
May 11, 2026
Collaborator
|
Merged via salvage PR #23791. Your commits were cherry-picked onto current main with your authorship preserved in git log. Thanks for the fix! |
rmulligan
pushed a commit
to rmulligan/hermes-agent
that referenced
this pull request
May 11, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
JinyuID
pushed a commit
to JinyuID/hermes-agent
that referenced
this pull request
May 11, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
jsboige
pushed a commit
to jsboige/hermes-agent
that referenced
this pull request
May 14, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
AlexFoxD
pushed a commit
to AlexFoxD/hermes-agent
that referenced
this pull request
May 21, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
Seven74AI
pushed a commit
to Seven74AI/hermes-agent
that referenced
this pull request
Jun 13, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a kanban board-state leak in in-process
/kanbancalls.When
kanban_command()handled--board <slug>, it setHERMES_KANBAN_BOARDbut did not restore the previous value afterwards. That was invisible in
one-shot CLI subprocesses, but it could leak across calls in long-lived
processes like the gateway, causing later implicit kanban operations to resolve
against the wrong board.
What changed
HERMES_KANBAN_BOARDvalue before applying a scoped--boardoverridepaths
run_slash("--board ...")flow
Why this matters
The kanban CLI comments already describe
--boardas a per-call override.Without restoration, a single board-scoped slash command could poison ambient
board resolution for later calls in the same process.
That is especially relevant for the gateway, where
/kanbanuses the sharedrun_slash()path inside a long-lived process.Testing
Fail-first regression test added first:
python -m pytest -o addopts='' tests/hermes_cli/test_kanban_cli.py -k board_override_restores_prior_env -qAdditional targeted verification:
python -m pytest -o addopts='' tests/hermes_cli/test_kanban_cli.py tests/hermes_cli/test_pin_kanban_board_env.py tests/hermes_cli/test_kanban_boards.py -k 'board_override_restores_prior_env or pin_ or connect_without_args_uses_current or connect_env_var_overrides_current or file_pointer_honoured or env_beats_file or invalid_env_falls_through' -qRisk
Low.
The change does not alter board resolution during the command itself; it only
restores prior process state after a scoped override finishes.