fix(kanban): route gateway create auto-subscribe to explicit board#23206
Closed
Frowtek wants to merge 1 commit into
Closed
fix(kanban): route gateway create auto-subscribe to explicit board#23206Frowtek wants to merge 1 commit into
Frowtek wants to merge 1 commit into
Conversation
kshitijk4poor
added a commit
that referenced
this pull request
May 11, 2026
Collaborator
|
Merged via salvage PR #23791. Your commits were cherry-picked onto current main with your authorship preserved in git log. Thanks for the fix! |
rmulligan
pushed a commit
to rmulligan/hermes-agent
that referenced
this pull request
May 11, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
JinyuID
pushed a commit
to JinyuID/hermes-agent
that referenced
this pull request
May 11, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
jsboige
pushed a commit
to jsboige/hermes-agent
that referenced
this pull request
May 14, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
AlexFoxD
pushed a commit
to AlexFoxD/hermes-agent
that referenced
this pull request
May 21, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
Seven74AI
pushed a commit
to Seven74AI/hermes-agent
that referenced
this pull request
Jun 13, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath), NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban bug-fix batch salvage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix gateway
/kanban createauto-subscribe when the command uses the global--boardflag.Before this change, a command like:
/kanban --board projx create "hello" --assignee alicewould create the task on
projx, but the gateway would fail to auto-subscribe the originating chat to task notifications. The handler only detectedcreatewhen it was the first token, and the follow-up subscription write did not carry the explicit board through to the DB connection.Root cause
GatewayRunner._handle_kanban_command()used a naive first-token check:text.split(None, 1)[:1] == ["create"]That breaks as soon as
--boardappears before the subcommand.The auto-subscribe path also opened a plain kanban connection without the explicit board override, so even if create detection had succeeded, the subscription write could drift to the ambient/current board instead of the requested one.
Fix
shlex--boardflag when determining the actual subcommandThis keeps the patch local to the gateway handler and avoids broader parser refactors.
Tests
Added a regression test covering:
/kanban --board projx create ...from the gateway surfacedefaultTest run:
python -m pytest -o "addopts=" tests/hermes_cli/test_kanban_notify.py -q