Skip to content

fix(kanban): route gateway create auto-subscribe to explicit board#23206

Closed
Frowtek wants to merge 1 commit into
NousResearch:mainfrom
Frowtek:fix/kanban-gateway-explicit-board-subscribe
Closed

fix(kanban): route gateway create auto-subscribe to explicit board#23206
Frowtek wants to merge 1 commit into
NousResearch:mainfrom
Frowtek:fix/kanban-gateway-explicit-board-subscribe

Conversation

@Frowtek

@Frowtek Frowtek commented May 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix gateway /kanban create auto-subscribe when the command uses the global --board flag.

Before this change, a command like:

/kanban --board projx create "hello" --assignee alice

would create the task on projx, but the gateway would fail to auto-subscribe the originating chat to task notifications. The handler only detected create when it was the first token, and the follow-up subscription write did not carry the explicit board through to the DB connection.

Root cause

GatewayRunner._handle_kanban_command() used a naive first-token check:

  • text.split(None, 1)[:1] == ["create"]

That breaks as soon as --board appears before the subcommand.

The auto-subscribe path also opened a plain kanban connection without the explicit board override, so even if create detection had succeeded, the subscription write could drift to the ambient/current board instead of the requested one.

Fix

  • Parse the slash command tokens with shlex
  • Skip the global --board flag when determining the actual subcommand
  • Capture the requested board slug and use it when opening the DB connection for the auto-subscribe write

This keeps the patch local to the gateway handler and avoids broader parser refactors.

Tests

Added a regression test covering:

  • /kanban --board projx create ... from the gateway surface
  • task creation on the named board
  • auto-subscription stored on that same board
  • no subscription leak into default

Test run:

  • python -m pytest -o "addopts=" tests/hermes_cli/test_kanban_notify.py -q

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins comp/gateway Gateway runner, session dispatch, delivery labels May 10, 2026
kshitijk4poor added a commit that referenced this pull request May 11, 2026
For PRs #23206 (Frowtek), #23252 (Sylw3ster), #23358 (dmnkhorvath),
#23659 (smwbev), and #23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
@kshitijk4poor

Copy link
Copy Markdown
Collaborator

Merged via salvage PR #23791. Your commits were cherry-picked onto current main with your authorship preserved in git log. Thanks for the fix!

rmulligan pushed a commit to rmulligan/hermes-agent that referenced this pull request May 11, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
JinyuID pushed a commit to JinyuID/hermes-agent that referenced this pull request May 11, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
jsboige pushed a commit to jsboige/hermes-agent that referenced this pull request May 14, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
AlexFoxD pushed a commit to AlexFoxD/hermes-agent that referenced this pull request May 21, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
Seven74AI pushed a commit to Seven74AI/hermes-agent that referenced this pull request Jun 13, 2026
For PRs NousResearch#23206 (Frowtek), NousResearch#23252 (Sylw3ster), NousResearch#23358 (dmnkhorvath),
NousResearch#23659 (smwbev), and NousResearch#23356 (TurgutKural) — all part of the kanban
bug-fix batch salvage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants