fix(tui): remove 'q' alias from /quit, add to /queue#14681
Conversation
The TUI frontend's slash command registry shadowed /queue's 'q' alias with /quit's 'q' alias. Since /quit appeared later in the registry, the flat lookup kept the later entry, making /q always quit instead of queueing a prompt. This mirrors the backend fix in PR NousResearch#10538 (hermes_cli/commands.py) but applies the same correction to the TUI TypeScript registry. Fixes NousResearch#10467
|
Hey team — while reviewing the docs tonight I came across this note in the Slash Commands Reference:
This made me pause. If the collision is a known behavior that you've deliberately chosen to document rather than fix, I'm happy to close this PR — I don't want to push a change that runs counter to the project's intent. My assumption was that because /q is listed as an alias for /queue in the docs, the silent resolution to /quit was an oversight rather than a design choice. How would you like /q to behave long-term? If the preference is for /quit to keep /q and for /queue to drop the alias from docs, I can adjust or withdraw. Just want to make sure whatever lands is what you actually want, not what I assumed. |
|
I think this PR is still correct. #10538 already resolved the same alias collision in the Python command registry by making The docs note appears stale now: it describes the old registry collision, but current So I’d treat this as a TUI parity fix, not a behavior change against docs. The docs should be updated to remove the warning once this lands. |
Summary
Fixes the TUI frontend slash command registry where
/qwas incorrectly resolving to/quitinstead of/queue.Problem
PR #10538 fixed the Python backend (
hermes_cli/commands.py) by removing'q'from/quit's aliases, but the same bug persisted in the TUI TypeScript registry (ui-tui/src/app/slash/commands/core.ts).The TUI's flat command lookup silently overwrote
/queue'sqalias with/quit's, making the documented/qshorthand for queueing prompts unusable — it always exited instead.Changes
core.ts: Remove'q'from/quit's aliases (keeps'exit')core.ts: Addaliases: ['q']to/queuecommandRelated
Verification
/q <msg>now correctly queues a message/quitand/exitstill exit the TUI