Remove conflicting /q alias from /queue#9830
Closed
Xowiek wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the clear write-up and regression tests, @Xowiek! This fix was independently landed the day after you opened this PR. This is an automated hermes-sweeper review. Already implemented on main:
Closing as implemented. The regression test file added here ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a conflicting
/qalias in the slash-command registry.Before this change,
/qwas assigned to bothqueueandquit. That made command lookup and help output disagree:/qresolved toquit, while help still advertised/qas an alias for/queue.Fix
Remove the conflicting
qalias fromqueueand keep the existing/q -> quitbehavior unchanged.Also update the related CLI comment so it matches the actual behavior.
Tests
Added regression coverage for:
/queuehelp no longer showing/qresolve_command("q")continuing to resolve toquitValidation:
python -m unittest discover -s tests/hermes_cli -p test_command_alias_collisions.py -v Result: test_aliases_are_unique_across_commands ... ok test_queue_help_does_not_advertise_quit_alias ... ok Ran 2 tests in 0.010s OK