fix(tui): drop /quit alias 'q' so /q routes to backend /queue#31985
Closed
hclsys wants to merge 1 commit into
Closed
fix(tui): drop /quit alias 'q' so /q routes to backend /queue#31985hclsys wants to merge 1 commit into
hclsys wants to merge 1 commit into
Conversation
The TUI 'quit' command carried alias 'q', which collides with the Python-side /queue alias (hermes_cli/commands.py). TUI-local commands dispatch before the backend, so typing /q exited Hermes (session.die) instead of queueing a prompt for the next turn. Remove 'q' from the quit aliases — /quit and /exit are explicit enough — so /q falls through to the backend where it maps to /queue. Add a slash-parity regression test asserting 'q' is not a TUI-local name/alias. Fixes NousResearch#31983
Collaborator
Author
|
Closing in favor of #14681 by @8bit64k, which makes the same |
daletkc
pushed a commit
to daletkc/hermes-agent
that referenced
this pull request
May 25, 2026
…rch#31983) Adapted from @hclsys's test in PR NousResearch#31985. Asserts findSlashCommand('q') resolves to the queue command, not quit.
bridge25
pushed a commit
to bridge25/hermes-agent
that referenced
this pull request
May 27, 2026
…rch#31983) Adapted from @hclsys's test in PR NousResearch#31985. Asserts findSlashCommand('q') resolves to the queue command, not quit.
mathias3
pushed a commit
to mathias3/hermes-agent
that referenced
this pull request
May 28, 2026
…rch#31983) Adapted from @hclsys's test in PR NousResearch#31985. Asserts findSlashCommand('q') resolves to the queue command, not quit.
Bryce-huang
pushed a commit
to wbkunlun/hermes-agent
that referenced
this pull request
May 29, 2026
…rch#31983) Adapted from @hclsys's test in PR NousResearch#31985. Asserts findSlashCommand('q') resolves to the queue command, not quit. #AI commit#
mosaiq-systems
pushed a commit
to mosaiq-systems/hermes-agent
that referenced
this pull request
May 29, 2026
…rch#31983) Adapted from @hclsys's test in PR NousResearch#31985. Asserts findSlashCommand('q') resolves to the queue command, not quit.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…rch#31983) Adapted from @hclsys's test in PR NousResearch#31985. Asserts findSlashCommand('q') resolves to the queue command, not quit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31983.
Summary
In the TUI, typing
/qexited Hermes instead of queuing a prompt. Thequitcommand carried aliasq(ui-tui/src/app/slash/commands/core.ts), which collides with the Python-side/queuealiasq(hermes_cli/commands.py). TUI-local commands dispatch before the backend, so/qalways resolved to/quit→ctx.session.die().Fix
Remove
qfrom thequitaliases (now just['exit'])./quitand/exitare explicit enough for exiting, so/qfalls through to the backend where it correctly maps to/queue.Test
Added a regression test to
src/__tests__/slashParity.test.tsassertingqis not a TUI-local name/alias (so it can't shadow the backend/queue). The existing parity suite only deduped an alias set, so this collision was previously silent.Verified the test guards the regression: with the
qalias restored, the new test fails (1 failed); with the fix, it passes.Note:
npm run type-checkreports pre-existing errors inpackages/hermes-ink/src/utils/execFileNoThrow.tsandsrc/app/useMainApp.tsthat are present onmainindependent of this change (confirmed by stashing the diff); this PR touches only thequitalias array and the parity test, both of which lint clean.