Skip to content

fix(tui): remap /q alias from quit to queue (salvage #14681 + #31985)#32074

Merged
daimon-nous[bot] merged 3 commits into
mainfrom
hermes/fix-tui-q-alias
May 25, 2026
Merged

fix(tui): remap /q alias from quit to queue (salvage #14681 + #31985)#32074
daimon-nous[bot] merged 3 commits into
mainfrom
hermes/fix-tui-q-alias

Conversation

@alt-glitch

Copy link
Copy Markdown
Collaborator

Summary

/q in the TUI resolves to /queue, not /quit. Previously the quit command carried alias q in core.ts, shadowing the Python-side /queue alias — typing /q <msg> exited the TUI instead of queueing a prompt.

Salvage of PR #14681 by @8bit64k (code fix) + regression test adapted from PR #31985 by @hclsys.

Changes

  • ui-tui/src/app/slash/commands/core.ts: remove q from quit aliases, add aliases: ["q"] to queue
  • ui-tui/src/__tests__/slashParity.test.ts: regression test asserting findSlashCommand("q") resolves to queue
  • scripts/release.py: AUTHOR_MAP entries for 8bit64k + hclsys

Validation

Before After
/q hello in TUI exits (session.die) queues prompt
/quit / /exit exits exits (unchanged)
vitest slashParity 2 passed 3 passed + regression guard

Fixes #31983. Closes #14681. Credits #31985.

8bit64k and others added 3 commits May 25, 2026 12:44
The TUI frontend's slash command registry shadowed /queue's 'q' alias
with /quit's 'q' alias. Since /quit appeared later in the registry,
the flat lookup kept the later entry, making /q always quit instead
of queueing a prompt.

This mirrors the backend fix in PR #10538 (hermes_cli/commands.py)
but applies the same correction to the TUI TypeScript registry.

Fixes #10467
Adapted from @hclsys's test in PR #31985. Asserts findSlashCommand('q')
resolves to the queue command, not quit.
@daimon-nous daimon-nous Bot merged commit f5bb595 into main May 25, 2026
20 of 22 checks passed
@daimon-nous daimon-nous Bot deleted the hermes/fix-tui-q-alias branch May 25, 2026 12:48
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/fix-tui-q-alias vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9325 on HEAD, 9325 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4934 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/tui Terminal UI (ui-tui/ + tui_gateway/) labels May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/tui Terminal UI (ui-tui/ + tui_gateway/) P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TUI: /q alias resolves to /quit instead of /queue

2 participants