fix(cli): resolve alias collision for /q between queue and quit#7399
Closed
Dusk1e wants to merge 1 commit into
Closed
fix(cli): resolve alias collision for /q between queue and quit#7399Dusk1e wants to merge 1 commit into
Dusk1e wants to merge 1 commit into
Conversation
Contributor
|
Thanks for this fix, @Dusk1e — you correctly identified the alias collision bug! This is an automated hermes-sweeper review. The same fix was independently authored by a maintainer and merged to
Your diagnosis was exactly right. Closing as already implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a CLI dispatch bug where the
/qalias was registered for bothqueueandquitcommands. Due to the command registry's "last-writer-wins" behavior,/qwas incorrectly resolving toquitinstead ofqueue.Problem
When a user attempted to queue a message using
/q <message>, the application would immediately trigger the quit command and exit, leading to potential data loss and a broken user experience.Changes
qalias from thequitcommand, leaving it exclusively forqueue./qcorrectly dispatches to the queue logic.Verification
/qnow properly queues messages instead of exiting.tests/cli/test_cli_init.pyandtests/hermes_cli/test_commands.py(131 passed in total).