Skip to content

test: add ArbSys precompile tests#162

Merged
AnkushinDaniil merged 1 commit into
hudem1/feat/precompile/arb-sysfrom
daniil/arb-sys-tests
Aug 25, 2025
Merged

test: add ArbSys precompile tests#162
AnkushinDaniil merged 1 commit into
hudem1/feat/precompile/arb-sysfrom
daniil/arb-sys-tests

Conversation

@AnkushinDaniil

@AnkushinDaniil AnkushinDaniil commented Aug 23, 2025

Copy link
Copy Markdown
Collaborator

Fixes #168

Note

The base is hudem1/feat/precompile/arb-sys

Important

These PRs need to be merged in order for the tests to pass:
#154
#9180
#9190

Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs Outdated
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs Outdated
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs Outdated
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs Outdated
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs Outdated
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs Outdated
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs Outdated
@hudem1 hudem1 mentioned this pull request Aug 23, 2025
@AnkushinDaniil AnkushinDaniil requested a review from hudem1 August 23, 2025 16:45
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/arb-sys-tests branch 2 times, most recently from e73ff60 to 980dd8a Compare August 23, 2025 17:38

@wurdum wurdum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread src/Nethermind.Arbitrum/Execution/ArbitrumTransactionProcessor.cs Outdated
Comment thread src/Nethermind.Arbitrum/Modules/ArbitrumRpcModule.cs
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs Outdated
Comment thread src/Nethermind.Arbitrum.Test/Precompiles/ArbSysTests.cs Outdated
Comment thread src/Nethermind.Arbitrum/Modules/ArbitrumRpcModule.cs
@AnkushinDaniil AnkushinDaniil requested a review from hudem1 August 24, 2025 16:05
Comment thread src/Nethermind.Arbitrum/Modules/ArbitrumRpcModule.cs
Comment thread src/Nethermind.Arbitrum/Properties/configs/arbitrum-local.json Outdated
Comment thread src/Nethermind.Arbitrum/Properties/configs/arbitrum-sepolia.json
Comment thread src/Nethermind.Arbitrum/Precompiles/ArbSys.cs
}

[Test]
public void SendTxToL1_BurnsCorrectAmountOfGas()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test naming convention

Comment thread src/Nethermind.Arbitrum/Precompiles/ArbSys.cs Outdated

@hudem1 hudem1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looks good !

@AnkushinDaniil AnkushinDaniil merged commit 1bb2183 into hudem1/feat/precompile/arb-sys Aug 25, 2025
3 of 5 checks passed
@AnkushinDaniil AnkushinDaniil deleted the daniil/arb-sys-tests branch August 25, 2025 18:04
hudem1 pushed a commit that referenced this pull request Aug 26, 2025
hudem1 added a commit that referenced this pull request Aug 26, 2025
* feat: First version of incomplete implementation

* feat: Implementation finished

* fix: Make BurnBalance public

* fix: InverseAddressAliasOffset fix

* refactor: Move ArbSysMetadata code to ArbSys

* clean: Remove console logs

* fix: Use correct types for ArbSysL2ToL1Tx and ArbSysL2ToL1Transaction structs

* fix: The value passed to WithdrawEth and SendTxToL1 is the solidity msg.value

* fix: DecodeEvent now does not assume non-indexed params as last

* quick fix: use BigInteger instead of UInt256 as value can be negative

* fix: Return SendRoot from DigestMessage instead of Hash256.Zero

* refactor(send-hash): Reuse ArbosStorage.CalculateHash instead of creating a new same one

* chore: Use explicit types

* refactor: Rename KeccakHashWithCost to ComputeKeccakHash

* refactor: Add explicit comment

* chore: Add context when throwing exception

* chore: Ternary if convention style

* test: ArbSysParserTests (#163)

* Tests & few changes

* feat: Use latest version of feature/arbitrum-setup for NMC submodule with StateStack

* refactor: Use existing helper

* test: add `ArbSys` precompile tests (#162)

* fix: Revert unintentional changes when merging test PR

* fix: Forgotten merge conflict changes

* fix: Code format

* fix: Remove local-only changes

* fix: Code format

---------

Co-authored-by: Stavros Vlachakis <89769224+svlachakis@users.noreply.github.com>
Co-authored-by: Daniil Ankushin <ankushin.daniil42@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants