Skip to content

feat: Add support for Arb Sys precompile#160

Merged
hudem1 merged 29 commits into
mainfrom
hudem1/feat/precompile/arb-sys
Aug 26, 2025
Merged

feat: Add support for Arb Sys precompile#160
hudem1 merged 29 commits into
mainfrom
hudem1/feat/precompile/arb-sys

Conversation

@hudem1

@hudem1 hudem1 commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator

Implementation is ready!
I set it as a draft because we need to merge the 2 test PRs first :

Needs following NMC PR

Closes issue #149

Fixes:

  • bug when decoding event where we assumed non-indexed params always came last in the event's parameter list.

Comment thread src/Nethermind.Arbitrum/Execution/ArbitrumBlockProcessor.cs

@wurdum wurdum left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing critical, feel free to ignore if urgent

Comment thread src/Nethermind.Arbitrum/Precompiles/ArbSys.cs Outdated
Comment thread src/Nethermind.Arbitrum/Precompiles/ArbSys.cs Outdated
Comment thread src/Nethermind.Arbitrum/Precompiles/ArbSys.cs Outdated
Comment thread src/Nethermind.Arbitrum/Precompiles/ArbSys.cs Outdated
Comment thread src/Nethermind.Arbitrum/Precompiles/ArbSys.cs Outdated
Comment thread src/Nethermind.Arbitrum/Precompiles/ArbSys.cs
@hudem1 hudem1 force-pushed the hudem1/feat/precompile/arb-sys branch from 1bb2183 to d72a94a Compare August 26, 2025 14:52
@hudem1 hudem1 marked this pull request as ready for review August 26, 2025 16:23
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Nethermind.Arbitrum 80% 56%
Summary 80% (5266 / 6585) 56% (1419 / 2523)

Minimum allowed line rate is 60%

@hudem1 hudem1 merged commit 5e1c0e6 into main Aug 26, 2025
5 checks passed
@hudem1 hudem1 deleted the hudem1/feat/precompile/arb-sys branch August 26, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants