Re-create empty account#9180
Merged
Merged
Conversation
Member
|
Maybe use same pattern we do with SystemUser for AuRa where it is just exempted from Eip158 deletion? |
Contributor
Author
Is it only SystemUser which is exempt from EIP158? Looking at |
MarekM25
reviewed
Aug 26, 2025
MarekM25
left a comment
Contributor
There was a problem hiding this comment.
Should we discuss it with Geth team?
ae7f243 to
fae8593
Compare
LukaszRozmej
approved these changes
Sep 15, 2025
benaadams
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
IWorldStatelevel.Update:
Tested multiple approach to achieve this functionality, but unfortunately nothing works without modifying directly
StateProvider. The goal is to be able to re-create an empty account, which normally is not allowed to be created with eip-158 enable.SystemTransactionReleaseSpecwhere a selected account is exempt from eip-158, but in this case, none of the accounts is known up-frontIWorldStatewhich reimplements eip-158 with an option to exempt selected accounts (on per block basis), which partially works. However, disabling eip-158 also modifiesVirtualMachine, so it would also have to be re-implemented to achieve the goal (seeClearEmptyAccountWhenTouched).Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
Requires explanation in Release Notes