Fix/zombie accounts#154
Merged
Merged
Conversation
Merged
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a hash mismatch on Sepolia archive at block 143 by implementing proper handling of zombie accounts in Arbitrum. The fix recreates empty accounts (zero balance, zero nonce) to maintain compatibility with legacy Geth behavior for older Arbitrum versions.
- Simplifies zombie account creation logic by using a new
CreateEmptyAccountIfDeletedmethod - Removes redundant zero-amount transfer check that was preventing proper zombie account handling
- Updates Nethermind submodule to include the new
IWorldStateinterface method
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ArbitrumTransactionProcessor.cs | Replaces manual account existence check with new CreateEmptyAccountIfDeleted method and removes early return for zero transfers |
| TrackingWorldState.cs | Adds implementation of CreateEmptyAccountIfDeleted method to delegate to underlying world state |
| src/Nethermind | Updates submodule commit to include new IWorldState interface method |
| .gitmodules | Changes Nethermind submodule branch to feature branch containing the required interface changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Minimum allowed line rate is |
wurdum
approved these changes
Sep 19, 2025
AnkushinDaniil
approved these changes
Sep 19, 2025
svlachakis
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hash mismatch on sepolia archive at block 143, by re-creating empty (zero balance, zero nonce) accounts. This is only valid for older versions of Arbitrum and explicitly recreates legacy geth behaviour.
The change is dependant on NM change to
IWorldState- NethermindEth/nethermind#9180