Infrastructure: Revert 6207 and 6277#6423
Conversation
This reverts commit e9f5f97.
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
left a comment
There was a problem hiding this comment.
It looks like trying to revert those two PRs took out too much.
vadi2
left a comment
There was a problem hiding this comment.
Source checks out on a visual scan 👍
|
I did check locally that the linked issues were resolved, but would love as many eyes on this as we can get |
|
/refresh links |
There was a problem hiding this comment.
It looks now like the code has properly been reverted - and it does compile - so I'm going to approve it. We will want to re-open the issues that were closed by those two PR - which seems to #5564 and which I have just re-opened...
|
Let's merge it in and see how PTBs are like now |
|
I will merge this over my lunch break, so I can be sure I have time to create the new PR to track trying to fix the issues with this fix/feature. |
|
thank you! |
|
#6425 reverts the reversion done here so that work can be done on getting the code up to snuff. |
|
#6290 is fixed by this revert |
Brief overview of PR changes/additions
#6207 and subsequently #6277 have since been discovered to be the source of several bugs, and so we have decided to revert the changes in development but open a new PR for the changes themselves.
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
resolve the following issues:
#6416
#6394
#6321
#6290