Fix: Chinese wrap width and autowrapping#6425
Closed
demonnic wants to merge 1 commit intodevelopmentfrom
Closed
Conversation
This reverts commit 4a9e1a4.
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Member
|
Closing for now as we haven't had any movement on this, but please do re-open if you'd like to work on it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Because we do want to fix wrapping for chinese fonts and include autowrapping if possible, I'm bringing these changes back in under their own branch for a new PR. Hopefully between us and the original author @hhsiao we'll get it resolved before it gets too stale.
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
This should fix #5564 - the original issue.
The original fix in #6207 introduced too many unexpected side-effects and had to be reverted in #6423 in time for release.