Fix errors when creating new triggers#2868
Merged
vadi2 merged 3 commits intoMudlet:developmentfrom Jul 29, 2019
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Member
Author
|
That default argument didn't work as expected, as I ended up setting it on 80% of the calls. 🤷♂️ |
keneanung
approved these changes
Jul 29, 2019
Contributor
|
This will fix #2629 |
vadi2
added a commit
to vadi2/Mudlet
that referenced
this pull request
Jul 31, 2019
This reverts commit 0578c61.
vadi2
added a commit
that referenced
this pull request
Aug 1, 2019
vadi2
added a commit
to vadi2/Mudlet
that referenced
this pull request
Aug 7, 2019
This reverts commit 0578c61.
vadi2
added a commit
that referenced
this pull request
Aug 8, 2019
* Remove left over debug statement for command line (#2885) * Fix permGroup for aliases and timers (#2887) * Remove text unnecessary for proxy translation (#2892) * Update autocomplete list for 4.0 (#2896) * Fix no patterns being set for triggers (#2891) * Default-initialise the repeating boolean (#2899) * Revert trigger editor changes (#2898) * Revert "Fix no patterns being set for triggers (#2891)" This reverts commit 0913755. * Revert "Fix errors when creating new triggers (#2868)" This reverts commit 0578c61. * Add supporters tab (#2880) (#2906) * Add initial tab and icon * Refactor text setting into separate methods * Comment improvement * Added a super simplistic structure for the Patreon tab * Added new HTML in * Add images * Remove PlaceholderText, fix Qt 5.7 compile * Add images in * Add missing end tag * Remove obsolete end tag * Set minimum size on about dialog to one that looks okay * Re-save with GIMP and fix libpng warnings * Draw our own images * Update names and white space * Layout * Typo * Dont create if already existing * Dont crash when closing Mudlet * Drop %3, save screen space * Don't print supporter's introduction big (cherry picked from commit 278d49f) * Update Windows Qt - 4.0 edition (#2911) * Move appveyor and windows SDK to Qt 5.12.4 * Fix macOS crash when saving settings (#2915) * 4.0.0 release * Re-set dev * Use OpenSSL 1.1.1 on Windows (#2923) * Use OpenSSL 1.1.1 on Windows * Set release build * Reset -dev * Fix dblsqd auto attachment * Fix mudletOlderThan() for 4.0 (#2925) (#2928) * mudletOlderThan fix * Logic adjustments * Combine and straighten else clauses (cherry picked from commit 42295a8) * Fix Patreon link in Supporters tab to open browser (#2927) (#2930) (cherry picked from commit 5647fe9) * New Crowdin translations (#2838) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Dutch) * New translations mudlet.ts (English, United Kingdom) * New translations mudlet.ts (French) * New translations mudlet.ts (German) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Polish) * New translations mudlet.ts (Portuguese) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Spanish) * New translations mudlet.ts (Chinese Traditional) * New translations mudlet.ts (Greek) * New translations mudlet.ts (Pirate English) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (English, United Kingdom) * New translations mudlet.ts (French) * New translations mudlet.ts (German) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Polish) * New translations mudlet.ts (Portuguese) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Spanish) * New translations mudlet.ts (Chinese Traditional) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Dutch) * New translations mudlet.ts (English, United Kingdom) * New translations mudlet.ts (French) * New translations mudlet.ts (German) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Polish) * New translations mudlet.ts (Portuguese) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Spanish) * New translations mudlet.ts (Chinese Traditional) * New translations mudlet.ts (Greek) * New translations mudlet.ts (Pirate English) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (French) * New translations mudlet.ts (German) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Polish) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) (cherry picked from commit 96e25f5) * 4.0.2 hotfix release * Use Qt 5.12.3 for Windows Mudlet (#2932) * Properly initialise ssl and proxy settings (#2931) * Actual 4.0.2 hotfix release * Re-set dev * Revert "Use OpenSSL 1.1.1 on Windows (#2923)" (#2934) This reverts commit 4127624. * 4.0.3 hotfix release (re-enable TLS/SSL in Windows) * Re-set dev
vadi2
added a commit
to dicene/Mudlet
that referenced
this pull request
Aug 13, 2019
…dlet#2945) * Add a workaround for mapper creation breaking getMainWindowSize() * Revert "Fix errors when creating new triggers (Mudlet#2868)" This reverts commit 0578c61. * Fix typo
vadi2
pushed a commit
that referenced
this pull request
Aug 20, 2019
* Initial commit. Adds ctrl+tab shortcut and logic for moving from pane to pane in the trigger editor. * Shortcut works without menu action. Forward tabbing logic seems to be right. Just missing reverse shortcut and logic. * Added CTRL+SHIFT+Tab shortcut to tab through sections in reverse order. * Removed unnecessary debug code. * Factor out drawing exits in the map into a separate method (#2941) * WIP * Const the variables that we can * Format * Reorganize windows sdk (#2958) * Move declaration of install functions This allows us to use them singularly in a different context. * Use our own edbee with updated QsLog (#2914) Intention is to send all improvements upstream but not be delayed by them getting merged. * Fix userwindows not going away on profile close (#2959) * Use correct URL to download the coverity software * Don't show SSL certificate info until we have one in Profile Preferences (#2953) * Don't show SSL certificate info until we have one & streamline UI * Remove colorroles * Add a workaround for mapper creation breaking getMainWindowSize() (#2945) * Add a workaround for mapper creation breaking getMainWindowSize() * Revert "Fix errors when creating new triggers (#2868)" This reverts commit 0578c61. * Fix typo * Don't include TLS code code when it's not available (#2965) * Raise minimum to Qt 5.11 (#2944) * Raise minimum to Qt 5.11 * Update Travis minimum Qt build * Remove < Qt 5.11 workarounds (#2969) * Replace a couple of cases of std::tie with auto (#2967) * Replace a couple of cases of std::tie with auto * A few more * Fix Coverity TTimer mRepeating initialiser warning (#2972) * Fix updateDialog uninitialised in constructor (#2973) * Fix nullptr warning around curVar (#2974) * Fix a possible nullptr dereference if the room wasn't found for some reason (#2975) * getRoom() will return nullptr if the room id is negative (#2976) * Add autocomplete toggle (#2679) * Update tooltip, more than IRE now provide maps (#2668) * Add autocomplete toggle to profile * Update to a version of edbee with autocomplete toggle * Wire in the autocomplete toggle * Use correct host variable * Add missing toggle call * Formatting changes up simplification of some code. * Added closing bracket that I must have accidentally deleted while resolving conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Don't show an error when creating a new group, and don't show the error (but still mark as ladybug) when creating a new trigger.
Motivation for adding to Mudlet
Better user experience.