Add supporters tab by vadi2 · Pull Request #2880 · Mudlet/Mudlet

vadi2 · 2019-07-29T15:23:21Z

Brief overview of PR changes/additions

Add supporters tab with the layout. I need help with the design here, ideas welcome! I'm stuck.

Motivation for adding to Mudlet

Patreon promises! :)

Other info (issues closed, discussion etc)

Patreon's branding guidelines allow the use of their logo.

add-deployment-links · 2019-07-29T15:23:22Z

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

linux: (download pending, check back soon!)
osx: (download pending, check back soon!)
windows: https://make.mudlet.org/snapshots/8f31e6/Mudlet-3.22.1-testing-PR2880-8f9cf433-windows.zip

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

SlySven · 2019-07-29T18:19:34Z

⚠️ Beware - this will clash with #2835 as they both touch the displayed licences and the other one makes changes in some of the lines modified here as well.

Kebap · 2019-07-29T21:45:24Z

Here is a design suggestion for you:

We may need to ask folks how they want to be called here though.

Kebap · 2019-07-29T21:55:59Z

My design is simple HTML & CSS with text overlaying one of two image files depending on tier:

<html><head>
  <style>
    .container {
      position: relative;
      text-align: center;
      color: black;
      font-weight: bold;
    }
    .centered {
      position: absolute;
      top: 50%;
      left: 50%;
      transform: translate(-50%, -50%);
    }
  </style>
</head><body>
  <p><div style="text-align: center">These formidable folks will be fondly remembered forever
  <br>for their generous sponsoring on <a href="">Mudlet's patreon page:</a></div></p>
  <div class="container">
    <img src="frame_plaque.png">
    <div class="centered"><h2>Vadim Peretokin</h2></div>
  </div>
  <div class="container">
    <img src="frame_swords.png">
    <div class="centered"><h2>Maiyannah</h2></div>
  </div>
  <div class="container">
    <img src="frame_swords.png">
    <div class="centered"><h2>Qwindor Rousseau</h2></div>
  </div>
</body></html>

You could easily put this in your C++ code and have it run through a simple list of [supporter name, patreon tier] and then assemble the HTML container and appropiate image for each entry. This way, (hopefully) adding more supporters later, will be possible quite easily.

# Conflicts: # src/dlgAboutDialog.cpp

vadi2 · 2019-07-30T04:08:04Z

Thanks, I've added it in. Names hardcoded until we finalize the design. Can you attach the images necessary?

Kebap · 2019-07-30T05:49:17Z

src/dlgAboutDialog.cpp

+{
+    QString supporters_text(
+            tr(R"(
+               <p><div style="text-align: center">These formidable folks will be fondly remembered forever


Only tr() translate this text. The rest shall be QStringLiteral and .arg()...
No need to toss these HTML piles, and supporters' names at Crowdin.

Kebap · 2019-07-30T05:50:36Z

Here are the images now:

vadi2 · 2019-07-30T06:05:56Z

Thanks. Can we also have the originals so we can modify them as necessary?

Kebap · 2019-07-30T06:14:00Z

Go ahead:

vadi2 · 2019-07-30T07:01:58Z

@Kebap it doesn't look like all of the css properties you're using are supported. Can you tweak it to work with what Qt supports? https://doc.qt.io/qt-5/stylesheet-customizing.html

Kebap · 2019-07-30T07:42:43Z

src/dlgAboutDialog.cpp

+void dlgAboutDialog::setSupportersTab(const QString& htmlHead) const
+{
+    QString supporters_text(QStringLiteral(R"(
+               <p><div style="text-align: center">%1</a>


Anchor end tag is obsolete

OK fixed, but the whole thing does not look correct anyway.

Anchor end tag is obsolete

Are you sure - remember this is Qt's own Rich-text it is NOT HTML5...!

Sure. Look at content of %1

vadi2 · 2019-07-30T07:46:43Z

Kebap · 2019-07-30T12:56:46Z

Thanks for the screenshot. I have searched the docs, but it seems I have reached QTextBrowser's edges with this. The alternative QWebView could render HTML better, but doesn't show local images easily.

May I suggest we use the images as headline then for now, like in the image you posted, or here:

vadi2 · 2019-07-30T13:20:19Z

Hm... no, that looks poor. I'll see if I can get it to overlap, there might be a way with background-image.

SlySven · 2019-07-30T19:30:04Z

Re: e50ca60 - that is a PITA that has bitten me as well - the current Qt Designer adding details that are not supported (and break compilation) for previous Qt versions. 🤕

vadi2 · 2019-07-31T08:36:16Z

Yep. Strangely they say they have fixed it a while ago, but I dont see the effects https://bugreports.qt.io/browse/QTBUG-72555

vadi2 · 2019-07-31T11:35:24Z

I'm afraid we're not using the QWebEngineView but a QTextBrowser instead - both display HTML, but one is way bigger than Mudlet itself (it's Chromium) and the other is much, much smaller and less feature rich.

vadi2 · 2019-07-31T15:12:48Z

If the html won't do it, we'll make our own images!

Want to take this as a base and improve the look'n'feel?

Kebap · 2019-07-31T23:42:40Z

❤️ the QPainter as well as the QStringList and for loops. Well done!
Not sure what you would like to see improved more in look & feel.
Given the release time, I'd rather postpone changes to a later day.

Kebap · 2019-08-01T01:21:30Z

vadi2 · 2019-08-01T03:29:49Z

src/dlgAboutDialog.cpp

-                          These formidable folks will be fondly remembered forever<br>for their generous sponsorship on <a href="https://www.patreon.com/mudlet">Mudlet's patreon</a>:
-                          )"), supporters_image_html));
+                          These formidable folks will be fondly remembered forever<br>for their generous financial support on <a href="https://www.patreon.com/mudlet">Mudlet's patreon</a>:
+                          )"), supporters_image_html, tr("Go to <a href=\"https://www.patreon.com/mudlet\">patreon.com/mudlet</a> if you'd like to be mentioned here.")));


The tooltip is kind of degrading in the obviousness of the message it delivers - anyone can figure out that you can go there to be mentioned.

vadi2 · 2019-08-01T03:44:25Z

Nice thanks, that looks better, but its too big for the default view now:

Its like we intend to keep the list to 3 people at most and not get any more.

Kebap · 2019-08-01T06:01:14Z

Thanks for spotting the crash! Indeed we need to ponder how to (hopefully) extend the list.

vadi2 · 2019-08-01T06:09:37Z

I mean - make things smaller again? The text and images take up all of the default space, so it doesn't give the impression that it can grow.

There is also a visible inconsistency in font when you change around tabs:

What do you think about keeping the first line of text consistent with others?

vadi2 · 2019-08-01T09:11:37Z

Looks good, perhaps the best we can make it with our skills =)

Kebap · 2019-08-01T10:51:26Z

This is still marked draft

vadi2 · 2019-08-01T11:02:05Z

Ready for review.

keneanung

Great work, thanks to you two!

* Add initial tab and icon * Refactor text setting into separate methods * Comment improvement * Added a super simplistic structure for the Patreon tab * Added new HTML in * Add images * Remove PlaceholderText, fix Qt 5.7 compile * Add images in * Add missing end tag * Remove obsolete end tag * Set minimum size on about dialog to one that looks okay * Re-save with GIMP and fix libpng warnings * Draw our own images * Update names and white space * Layout * Typo * Dont create if already existing * Dont crash when closing Mudlet * Drop %3, save screen space * Don't print supporter's introduction big (cherry picked from commit 278d49f)

Kebap · 2019-08-03T10:49:17Z

We need to give the images some alternative text for a11y

* Remove left over debug statement for command line (#2885) * Fix permGroup for aliases and timers (#2887) * Remove text unnecessary for proxy translation (#2892) * Update autocomplete list for 4.0 (#2896) * Fix no patterns being set for triggers (#2891) * Default-initialise the repeating boolean (#2899) * Revert trigger editor changes (#2898) * Revert "Fix no patterns being set for triggers (#2891)" This reverts commit 0913755. * Revert "Fix errors when creating new triggers (#2868)" This reverts commit 0578c61. * Add supporters tab (#2880) (#2906) * Add initial tab and icon * Refactor text setting into separate methods * Comment improvement * Added a super simplistic structure for the Patreon tab * Added new HTML in * Add images * Remove PlaceholderText, fix Qt 5.7 compile * Add images in * Add missing end tag * Remove obsolete end tag * Set minimum size on about dialog to one that looks okay * Re-save with GIMP and fix libpng warnings * Draw our own images * Update names and white space * Layout * Typo * Dont create if already existing * Dont crash when closing Mudlet * Drop %3, save screen space * Don't print supporter's introduction big (cherry picked from commit 278d49f) * Update Windows Qt - 4.0 edition (#2911) * Move appveyor and windows SDK to Qt 5.12.4 * Fix macOS crash when saving settings (#2915) * 4.0.0 release * Re-set dev * Use OpenSSL 1.1.1 on Windows (#2923) * Use OpenSSL 1.1.1 on Windows * Set release build * Reset -dev * Fix dblsqd auto attachment * Fix mudletOlderThan() for 4.0 (#2925) (#2928) * mudletOlderThan fix * Logic adjustments * Combine and straighten else clauses (cherry picked from commit 42295a8) * Fix Patreon link in Supporters tab to open browser (#2927) (#2930) (cherry picked from commit 5647fe9) * New Crowdin translations (#2838) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Dutch) * New translations mudlet.ts (English, United Kingdom) * New translations mudlet.ts (French) * New translations mudlet.ts (German) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Polish) * New translations mudlet.ts (Portuguese) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Spanish) * New translations mudlet.ts (Chinese Traditional) * New translations mudlet.ts (Greek) * New translations mudlet.ts (Pirate English) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (English, United Kingdom) * New translations mudlet.ts (French) * New translations mudlet.ts (German) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Polish) * New translations mudlet.ts (Portuguese) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Spanish) * New translations mudlet.ts (Chinese Traditional) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (French) * New translations mudlet.ts (French) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Dutch) * New translations mudlet.ts (English, United Kingdom) * New translations mudlet.ts (French) * New translations mudlet.ts (German) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Polish) * New translations mudlet.ts (Portuguese) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Spanish) * New translations mudlet.ts (Chinese Traditional) * New translations mudlet.ts (Greek) * New translations mudlet.ts (Pirate English) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (French) * New translations mudlet.ts (German) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Polish) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Russian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Chinese Simplified) * New translations mudlet.ts (Italian) * New translations mudlet.ts (Italian) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (German) * New translations mudlet.ts (Chinese Simplified) (cherry picked from commit 96e25f5) * 4.0.2 hotfix release * Use Qt 5.12.3 for Windows Mudlet (#2932) * Properly initialise ssl and proxy settings (#2931) * Actual 4.0.2 hotfix release * Re-set dev * Revert "Use OpenSSL 1.1.1 on Windows (#2923)" (#2934) This reverts commit 4127624. * 4.0.3 hotfix release (re-enable TLS/SSL in Windows) * Re-set dev

vadi2 added 5 commits July 21, 2019 12:16

Add initial tab and icon

8458aea

Refactor text setting into separate methods

ac20ad8

Comment improvement

3a73af6

Added a super simplistic structure for the Patreon tab

dd3b18f

Merge remote-tracking branch 'origin/development' into add-patreon-tab

2f6a6e5

vadi2 added this to the 4.0.0 milestone Jul 29, 2019

vadi2 added 2 commits July 30, 2019 06:04

Added new HTML in

21b704d

Merge remote-tracking branch 'origin/development' into add-patreon-tab

096453d

# Conflicts: # src/dlgAboutDialog.cpp

Kebap reviewed Jul 30, 2019

View reviewed changes

Add images

2605604

vadi2 added 2 commits July 30, 2019 08:30

Remove PlaceholderText, fix Qt 5.7 compile

e50ca60

Add images in

c31a4ef

Add missing end tag

338439a

Kebap reviewed Jul 30, 2019

View reviewed changes

Remove obsolete end tag

5512e97

Merge remote-tracking branch 'origin/development' into add-patreon-tab

046b89d

Draw our own images

2208fe6

Update names and white space

ebd6e7c

Kebap added 2 commits August 1, 2019 02:41

Layout

2ccb5f4

Typo

350635f

vadi2 commented Aug 1, 2019

View reviewed changes

vadi2 and others added 3 commits August 1, 2019 05:49

Dont create if already existing

9d405aa

Dont crash when closing Mudlet

d4311ed

Drop %3, save screen space

a24b6aa

Don't print supporter's introduction big

2511a50

vadi2 marked this pull request as ready for review August 1, 2019 10:56

vadi2 requested a review from a team as a code owner August 1, 2019 10:56

vadi2 requested a review from a team August 1, 2019 10:56

keneanung approved these changes Aug 1, 2019

View reviewed changes

vadi2 merged commit 278d49f into development Aug 1, 2019

vadi2 deleted the add-patreon-tab branch August 1, 2019 17:32

vadi2 mentioned this pull request Aug 1, 2019

Add supporters tab (#2880, 4.0 version) #2906

Merged

Uh oh!

Conversation

vadi2 commented Jul 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Brief overview of PR changes/additions

Motivation for adding to Mudlet

Other info (issues closed, discussion etc)

Uh oh!

add-deployment-links bot commented Jul 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test versions

Uh oh!

SlySven commented Jul 29, 2019

Uh oh!

Kebap commented Jul 29, 2019

Uh oh!

Kebap commented Jul 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vadi2 commented Jul 30, 2019

Uh oh!

Kebap Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

Kebap commented Jul 30, 2019

Uh oh!

vadi2 commented Jul 30, 2019

Uh oh!

Kebap commented Jul 30, 2019

Uh oh!

vadi2 commented Jul 30, 2019

Uh oh!

Kebap Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

vadi2 Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

SlySven Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

Kebap Jul 30, 2019

Choose a reason for hiding this comment

Uh oh!

vadi2 commented Jul 30, 2019

Uh oh!

Kebap commented Jul 30, 2019

Uh oh!

vadi2 commented Jul 30, 2019

Uh oh!

SlySven commented Jul 30, 2019

Uh oh!

vadi2 commented Jul 31, 2019

Uh oh!

vadi2 commented Jul 31, 2019

Uh oh!

vadi2 commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kebap commented Jul 31, 2019

Uh oh!

Kebap commented Aug 1, 2019

Uh oh!

vadi2 Aug 1, 2019

Choose a reason for hiding this comment

Uh oh!

vadi2 commented Aug 1, 2019

Uh oh!

Kebap commented Aug 1, 2019

Uh oh!

vadi2 commented Aug 1, 2019

Uh oh!

vadi2 commented Aug 1, 2019

Uh oh!

Kebap commented Aug 1, 2019

Uh oh!

vadi2 commented Aug 1, 2019

Uh oh!

keneanung left a comment

Choose a reason for hiding this comment

vadi2 commented Jul 29, 2019 •

edited

Loading

add-deployment-links bot commented Jul 29, 2019 •

edited

Loading

Kebap commented Jul 29, 2019 •

edited

Loading

vadi2 commented Jul 31, 2019 •

edited

Loading