Use our own edbee with updated QsLog#2914
Merged
vadi2 merged 4 commits intoMudlet:developmentfrom Aug 9, 2019
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
I wasn't really ready to maintain something regularly, so this is for the best. I was hopeful it could be brought upstream, but trying to pull it up, piece by piece, in an orderly manner would be quite a beast to take on. And it's possible there are design decisions made that the maintainer of the main branch would want them decoupled from the rest, but it would be similarly difficult to do that, I imagine. |
Member
|
FTR my upstream PR that tries to fix this there is: edbee/edbee-lib#86 . |
keneanung
approved these changes
Aug 5, 2019
For some reason SmartGit doesn't do this.
Member
Author
|
@keneanung what do you think is the issue with CMake builds? That |
Member
Author
|
Everything looks good now, checked all logs :) |
vadi2
added a commit
to dicene/Mudlet
that referenced
this pull request
Aug 13, 2019
Intention is to send all improvements upstream but not be delayed by them getting merged.
vadi2
pushed a commit
that referenced
this pull request
Aug 20, 2019
* Initial commit. Adds ctrl+tab shortcut and logic for moving from pane to pane in the trigger editor. * Shortcut works without menu action. Forward tabbing logic seems to be right. Just missing reverse shortcut and logic. * Added CTRL+SHIFT+Tab shortcut to tab through sections in reverse order. * Removed unnecessary debug code. * Factor out drawing exits in the map into a separate method (#2941) * WIP * Const the variables that we can * Format * Reorganize windows sdk (#2958) * Move declaration of install functions This allows us to use them singularly in a different context. * Use our own edbee with updated QsLog (#2914) Intention is to send all improvements upstream but not be delayed by them getting merged. * Fix userwindows not going away on profile close (#2959) * Use correct URL to download the coverity software * Don't show SSL certificate info until we have one in Profile Preferences (#2953) * Don't show SSL certificate info until we have one & streamline UI * Remove colorroles * Add a workaround for mapper creation breaking getMainWindowSize() (#2945) * Add a workaround for mapper creation breaking getMainWindowSize() * Revert "Fix errors when creating new triggers (#2868)" This reverts commit 0578c61. * Fix typo * Don't include TLS code code when it's not available (#2965) * Raise minimum to Qt 5.11 (#2944) * Raise minimum to Qt 5.11 * Update Travis minimum Qt build * Remove < Qt 5.11 workarounds (#2969) * Replace a couple of cases of std::tie with auto (#2967) * Replace a couple of cases of std::tie with auto * A few more * Fix Coverity TTimer mRepeating initialiser warning (#2972) * Fix updateDialog uninitialised in constructor (#2973) * Fix nullptr warning around curVar (#2974) * Fix a possible nullptr dereference if the room wasn't found for some reason (#2975) * getRoom() will return nullptr if the room id is negative (#2976) * Add autocomplete toggle (#2679) * Update tooltip, more than IRE now provide maps (#2668) * Add autocomplete toggle to profile * Update to a version of edbee with autocomplete toggle * Wire in the autocomplete toggle * Use correct host variable * Add missing toggle call * Formatting changes up simplification of some code. * Added closing bracket that I must have accidentally deleted while resolving conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Use our own https://github.com/Mudlet/edbee-lib fork instead of @dicene's since the autocompletion changes aren't really going upstream and we've been stuck in this limbo for a few years where we need to badger dicene for any improvements we want to do to edbee.
Motivation for adding to Mudlet
C++17 compilation on strict compilers that have deleted outdated C++ functionality finally removed in C++17 like
std::auto_ptr.Other info (issues closed, discussion etc)