Skip to content

Fix a possible nullptr dereference if the room wasn't found#2975

Merged
vadi2 merged 1 commit intoMudlet:developmentfrom
vadi2:fix-possible-nullptr-deference
Aug 13, 2019
Merged

Fix a possible nullptr dereference if the room wasn't found#2975
vadi2 merged 1 commit intoMudlet:developmentfrom
vadi2:fix-possible-nullptr-deference

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Aug 13, 2019

Brief overview of PR changes/additions

Fix a possible nullptr dereference if the room wasn't found for some reason.

Motivation for adding to Mudlet

Less theoretically possible crashes.

Other info (issues closed, discussion etc)

CID 1472988.

@vadi2 vadi2 added this to the 4.1.0 milestone Aug 13, 2019
@vadi2 vadi2 requested a review from a team as a code owner August 13, 2019 04:21
@vadi2 vadi2 requested a review from a team August 13, 2019 04:21
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Aug 13, 2019

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2 vadi2 merged commit 437893b into Mudlet:development Aug 13, 2019
@vadi2 vadi2 deleted the fix-possible-nullptr-deference branch August 13, 2019 08:28
vadi2 added a commit to dicene/Mudlet that referenced this pull request Aug 13, 2019
SlySven added a commit to SlySven/Mudlet that referenced this pull request Aug 16, 2019
That PR was unnecessary as there is no need to validate the `TRoom`
pointers for the set of rooms in the `(QSet<int>) roomsToConsider` as they
were previously checked for validity before being added to that set in
the code around line 415 within the same method in:
`(void) T2DMap::slot_switchArea(const QString&)`.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
@SlySven SlySven mentioned this pull request Aug 16, 2019
vadi2 pushed a commit that referenced this pull request Aug 20, 2019
* Initial commit. Adds ctrl+tab shortcut and logic for moving from pane to pane in the trigger editor.

* Shortcut works without menu action. Forward tabbing logic seems to be right.

Just missing reverse shortcut and logic.

* Added CTRL+SHIFT+Tab shortcut to tab through sections in reverse order.

* Removed unnecessary debug code.

* Factor out drawing exits in the map into a separate method (#2941)

* WIP

* Const the variables that we can

* Format

* Reorganize windows sdk (#2958)

* Move declaration of install functions

This allows us to use them singularly in a different context.

* Use our own edbee with updated QsLog (#2914)

Intention is to send all improvements upstream but not be delayed by them getting merged.

* Fix userwindows not going away on profile close (#2959)

* Use correct URL to download the coverity software

* Don't show SSL certificate info until we have one in Profile Preferences (#2953)

* Don't show SSL certificate info until we have one & streamline UI

* Remove colorroles

* Add a workaround for mapper creation breaking getMainWindowSize() (#2945)

* Add a workaround for mapper creation breaking getMainWindowSize()

* Revert "Fix errors when creating new triggers (#2868)"

This reverts commit 0578c61.

* Fix typo

* Don't include TLS code code when it's not available (#2965)

* Raise minimum to Qt 5.11 (#2944)

* Raise minimum to Qt 5.11

* Update Travis minimum Qt build

* Remove < Qt 5.11 workarounds (#2969)

* Replace a couple of cases of std::tie with auto (#2967)

* Replace a couple of cases of std::tie with auto

* A few more

* Fix Coverity TTimer mRepeating initialiser warning (#2972)

* Fix updateDialog uninitialised in constructor (#2973)

* Fix nullptr warning around curVar (#2974)

* Fix a possible nullptr dereference if the room wasn't found for some reason (#2975)

* getRoom() will return nullptr if the room id is negative (#2976)

* Add autocomplete toggle (#2679)

* Update tooltip, more than IRE now provide maps (#2668)

* Add autocomplete toggle to profile

* Update to a version of edbee with autocomplete toggle

* Wire in the autocomplete toggle

* Use correct host variable

* Add missing toggle call

* Formatting changes up simplification of some code.

* Added closing bracket that I must have accidentally deleted while resolving conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants