Fix a bad merge from merge 7580b5d. by ahmedcharles · Pull Request #15 · Mudlet/Mudlet

ahmedcharles · 2014-07-27T13:47:11Z

No description provided.

ahmedcharles · 2014-07-31T05:11:54Z

This is the most urgent since it fixes the cmake build and now that we have a travis ci config, there's more confidence that it doesn't break anything.

ahmedcharles · 2014-08-01T06:57:48Z

Since mudlet isn't a package (library) defining package_* doesn't make much sense, so I'm just going to define them with the same names as the defines.

SlySven · 2014-08-01T17:41:29Z

Is that the best way to go? I'm just thinking that it might be wise to draw a clear distinction between a "CMake" variable and a "Define" c.f. the qmake project file. In the latter the VERSION variable is a special one that qmake regards as the version of the executable named in TARGET (that is also a special variable!) - I do not know what the rules are for CMake; I'm guessing that the project(<string>) command may have a comparable role in CMake to assigning a value to the TARGET variable in qmake...

May I enquire what features force a CMake 2.8.11 minimum? Does it vary between OSs - avoiding the complications that might then arise from cross-compiling? (My GNU/Linux Debian stable Distro "Wheezy" is only at 2.8.9 and I've been looking through http://www.cmake.org/Wiki/CMake_Version_Compatibility_Matrix to try and pick out what the issues might be...)

SlySven · 2014-08-01T17:44:19Z

CMakeLists.txt

Is a space needed/safe between "project" and the '('?

The space doesn't matter.

Add definitions for the APP_* defines and remove a file which was removed in a previous commit but the merge went poorly.

ahmedcharles · 2014-08-01T18:18:26Z

Cmake 2.8.11 has a change in the way that it decides whether to link targets with qtmain.lib, which defines WinMain in a way that's compatible with Qt. It is also either the first version or second version to support MSVC 12 (2013), which is what I use to build mudlet. Which is almost the same reason I considered bumping the required Qt version to 5.3.1, since 5.3 is the first Qt version to support that version of MSVC.

Overall, I use cmake and have an interest in maintaining it because it allows me to develop using project files in MSVC and I haven't been able to get qmake to do that yet. However, now that they officially support MSVC 12, I'll probably investigate using qmake and see how that works, since until 1-2 days ago when I got 5.3.1, I was building Qt from source for MSVC, which has always been a hassle, since I'm always using a version that they don't officially support.

Anyways, I don't view the cmake build system as necessarily cross platform. There are almost no benefits to using it on linux or mac, where qmake works just fine (or better). And if qmake can work similarly or better on windows, with MSVC, I'll use that too and we can drop cmake entirely. But until that's working, I'd just like to stop maintaining separate build changes locally, just so I can contribute, cause it's a headache. I have changes that fix bugs (mostly memory leaks) in mudlet that have been sitting here for years and I can't seem to get them merged since it's too much work to validate them if I can't build mudlet without 15 other changes on top and this is the last change that puts us over the top, so I never have to touch the cmake build again until the next break happens. :)

SlySven · 2014-08-01T20:24:38Z

According to http://www.cmake.org/Wiki/CMake_Version_Compatibility_Matrix/Variables_That_Describe_the_System MSVC12 support comes in at 2.8.12 (or at least the variable "MSVC12" does, similarly 2.8.10 for MSVC60,70,71,90,10,11 though MSVC80 goes back a long way)...!

One advantage that CMake does have is that it was designed from the outset for a heterogeneous environment where Cross-compiling is likely - qmake should be able to also do this but it does not seem so simple.

I hope we don't have to bump the minimum Qt for everyone, can we not make it conditional for MSVC12? At present I don't think we are coding anything that actually requires Qt5 which is just as well; as, on the Linux side, not all distributions are shipping with those libraries in their "stable" versions and until they do they will be unable to package an up to date Mudlet (when we get it out the door). Although I am building on Qt 5.2.1, I also, with a few conditionals to replace Qt5 specific updates with previous equivalent code, test build on Debian "Stable"'s system Qt which is 4.8.2 and is indeed, largely "stable", this is not yet a term that I would use to describe Qt5 though it is getting better.

Chris7 · 2014-08-02T01:35:13Z

Currently we don't have a working cmake until this so I don't a need to
enforce anything for compatibility to be honest.

Sent from my phone.
On Aug 1, 2014 4:24 PM, "Stephen Lyons" notifications@github.com wrote:

According to
http://www.cmake.org/Wiki/CMake_Version_Compatibility_Matrix/Variables_That_Describe_the_System
MSVC12 support comes in at 2.8.12 (or at least the variable "MSVC12" does,
similarly 2.8.10 for MSVC60,70,71,90,10,11 though MSVC80 goes back a long
way)...!

One advantage that CMake does have is that it was designed from the outset
for a heterogeneous environment where Cross-compiling is likely - qmake
should be able to also do this but it does not seem so simple.

I hope we don't have to bump the minimum Qt for everyone, can we not
make it conditional for MSVC12? At present I don't think we are coding
anything that actually requires Qt5 which is just as well; as, on the
Linux side, not all distributions are shipping with those libraries in
their "stable" versions and until they do they will be unable to package an
up to date Mudlet (when we get it out the door). Although I am building on
Qt 5.2.1, I also, with a few conditionals to replace Qt5 specific updates
with previous equivalent code, test build on Debian "Stable"'s system Qt
which is 4.8.2 and is indeed, largely "stable", this is not yet a term that
I would use to describe Qt5 though it is getting better.

—
Reply to this email directly or view it on GitHub
#15 (comment).

vadi2 · 2014-08-02T04:10:12Z

Having this would be nice to have, we don't support cmake at the moment but
it'll help Ahmed with his patches. I'd like to see this merged.

ahmedcharles · 2014-08-04T06:45:52Z

Any thoughts on this?

Fix a bad merge from merge 7580b5d.

* Revise: improve mouse X position to index into TBuffer::lineBuffer This properly considers the width of the base character in a grapheme (it ignores the effect of any combining diacriticals) but DOES account for those Unicode codepoints that are NOT in the basic (first) Unicode Multi-plane. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Revise: use QFontMetrics::averageCharWidth() instead of odd letter widths For the use made of the widths concerned it makes more sense to use it rather than the width of a space or 'W' character - and is less likely to cause a seg. fault for fonts that do not have the selected character; Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Debug: add optional debug output (can be switched on from debugger) The code concerned is very spammy so it should only be switched on when needed. Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * BugFix: get width of image correct Signed-off-by: Stephen Lyons <slysven@virginmedia.com> * Revise: remove excess debugging info and comments following peer review Signed-off-by: Stephen Lyons <slysven@virginmedia.com>

…rocessing (#8571)  #### Brief overview of PR changes/additions Fix: heap-use-after-free when cleanup runs during alias/trigger/key processing #### Motivation for adding to Mudlet Fixes crash when running #8559 (comment) benchmark on Linux. #### Other info (issues closed, discussion etc) ==617553==ERROR: AddressSanitizer: heap-use-after-free on address 0x51200086e6d0 at pc 0x589b650367f6 bp 0x7ffc44dbc700 sp 0x7ffc44dbc6f8 READ of size 8 at 0x51200086e6d0 thread T0 #0 0x589b650367f5 in Tree<TAlias>::isActive() const (/home/vadi/Programs/Mudlet/build/src/mudlet+0xe8a7f5) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #1 0x589b65d81408 in TAlias::match(QString const&) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1bd5408) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #2 0x589b6560c156 in AliasUnit::processDataStream(QString const&) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1460156) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #3 0x589b65c872b4 in Host::send(QString, bool, bool) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1adb2b4) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #4 0x589b65d96517 in TCommandLine::enterCommand(QKeyEvent*) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1bea517) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #5 0x589b65d93095 in TCommandLine::event(QEvent*) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1be7095) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #6 0x7ac668391c8a in QApplicationPrivate::notify_helper(QObject*, QEvent*) /home/qt/work/qt/qtbase/src/widgets/kernel/qapplication.cpp:3307:31 #7 0x7ac66839b2f0 in QApplication::notify(QObject*, QEvent*) /home/qt/work/qt/qtbase/src/widgets/kernel/qapplication.cpp:2725:39 #8 0x7ac668b83f7f in QCoreApplication::notifyInternal2(QObject*, QEvent*) /home/qt/work/qt/qtbase/src/corelib/kernel/qcoreapplication.cpp:1109:24 #9 0x7ac66840cc0b in QWidgetWindow::event(QEvent*) /home/qt/work/qt/qtbase/src/widgets/kernel/qwidgetwindow.cpp:285:23 #10 0x7ac668391c8a in QApplicationPrivate::notify_helper(QObject*, QEvent*) /home/qt/work/qt/qtbase/src/widgets/kernel/qapplication.cpp:3307:31 #11 0x7ac668b83f7f in QCoreApplication::notifyInternal2(QObject*, QEvent*) /home/qt/work/qt/qtbase/src/corelib/kernel/qcoreapplication.cpp:1109:24 #12 0x7ac6677ee8e2 in QGuiApplicationPrivate::processKeyEvent(QWindowSystemInterfacePrivate::KeyEvent*) /home/qt/work/qt/qtbase/src/gui/kernel/qguiapplication.cpp:2609:46 #13 0x7ac655cf9a04 in QIBusPlatformInputContext::filterEventFinished(QDBusPendingCallWatcher*) /home/qt/work/qt/qtbase/src/plugins/platforminputcontexts/ibus/qibusplatforminputcontext.cpp:523:57 #14 0x7ac668be8b74 in QtPrivate::QSlotObjectBase::call(QObject*, void**) /home/qt/work/qt/qtbase/src/corelib/kernel/qobjectdefs_impl.h:461:57 #15 0x7ac668be8b74 in void doActivate<false>(QObject*, int, void**) /home/qt/work/qt/qtbase/src/corelib/kernel/qobject.cpp:4255:30 #16 0x7ac6671e5142 in void QMetaObject::activate<void, QDBusPendingCallWatcher*>(QObject*, QMetaObject const*, int, void*, QDBusPendingCallWatcher* const&) /home/qt/work/qt/qtbase/src/corelib/kernel/qobjectdefs.h:319:17 #17 0x7ac6671e5142 in QDBusPendingCallWatcher::finished(QDBusPendingCallWatcher*) /home/qt/work/qt/qtbase_build/src/dbus/DBus_autogen/include/moc_qdbuspendingcall.cpp:137:32 #18 0x7ac668bdd56b in QObject::event(QEvent*) /home/qt/work/qt/qtbase/src/corelib/kernel/qobject.cpp:1411:31 #19 0x7ac668391c8a in QApplicationPrivate::notify_helper(QObject*, QEvent*) /home/qt/work/qt/qtbase/src/widgets/kernel/qapplication.cpp:3307:31 #20 0x7ac668b83f7f in QCoreApplication::notifyInternal2(QObject*, QEvent*) /home/qt/work/qt/qtbase/src/corelib/kernel/qcoreapplication.cpp:1109:24 #21 0x7ac668b879e4 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) /home/qt/work/qt/qtbase/src/corelib/kernel/qcoreapplication.cpp:1904:36 #22 0x7ac668e7d416 in postEventSourceDispatch /home/qt/work/qt/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:246:39 #23 0x7ac6667145c4 (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5d5c4) (BuildId: 1eb6131419edb83b2178b682829a6913cf682d75) #24 0x7ac666773736 (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0xbc736) (BuildId: 1eb6131419edb83b2178b682829a6913cf682d75) #25 0x7ac666713a62 in g_main_context_iteration (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x5ca62) (BuildId: 1eb6131419edb83b2178b682829a6913cf682d75) #26 0x7ac668e7caad in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) /home/qt/work/qt/qtbase/src/corelib/kernel/qeventdispatcher_glib.cpp:399:43 #27 0x7ac668b9002a in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) /home/qt/work/qt/qtbase/src/corelib/kernel/qeventloop.cpp:186:22 #28 0x7ac668b8ba59 in QCoreApplication::exec() /home/qt/work/qt/qtbase/src/corelib/kernel/qcoreapplication.cpp:1452:36 #29 0x589b64ab0675 in main (/home/vadi/Programs/Mudlet/build/src/mudlet+0x904675) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #30 0x7ac66602a1c9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 #31 0x7ac66602a28a in __libc_start_main csu/../csu/libc-start.c:360:3 #32 0x589b649c1d04 in _start (/home/vadi/Programs/Mudlet/build/src/mudlet+0x815d04) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) 0x51200086e6d0 is located 16 bytes inside of 296-byte region [0x51200086e6c0,0x51200086e7e8) freed by thread T0 here: #0 0x589b64a9b9f1 in operator delete(void*) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x8ef9f1) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #1 0x589b65d80711 in TAlias::~TAlias() (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1bd4711) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #2 0x589b6560eefc in AliasUnit::doCleanup() (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1462efc) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #3 0x589b65c8e88d in Host::incomingStreamProcessor(QString const&, int) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1ae288d) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #4 0x589b651b73b5 in TMainConsole::runTriggers(int) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x100b3b5) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #5 0x589b64e39c4b in TBuffer::commitLine(char, unsigned long&) (/home/vadi/Programs/Mudlet/build/src/mudlet+0xc8dc4b) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #6 0x589b64e28d4e in TBuffer::translateToPlainText(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&, bool) (/home/vadi/Programs/Mudlet/build/src/mudlet+0xc7cd4e) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #7 0x589b651b638d in TMainConsole::printOnDisplay(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&, bool) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x100a38d) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #8 0x589b64f9ed5b in TLuaInterpreter::feedTriggers(lua_State*) (/home/vadi/Programs/Mudlet/build/src/mudlet+0xdf2d5b) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #9 0x7ac66942ffa0 in luaD_precall /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/ldo.c:320:10 #10 0x7ac66943ad7a in luaV_execute /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/lvm.c:591:17 #11 0x7ac66942e96c in luaD_call /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/ldo.c:378:5 #12 0x7ac66942af70 in luaD_rawrunprotected /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/ldo.c:116:3 #13 0x7ac66942bb94 in luaD_pcall /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/ldo.c:464:12 #14 0x7ac66942bce0 in lua_pcall /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/lapi.c:821:12 #15 0x589b64fd65f1 in TLuaInterpreter::call(QString const&, QString const&, bool) (/home/vadi/Programs/Mudlet/build/src/mudlet+0xe2a5f1) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #16 0x589b65d84d31 in TAlias::execute() (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1bd8d31) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #17 0x589b65d84577 in TAlias::match(QString const&) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1bd8577) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #18 0x589b6560c156 in AliasUnit::processDataStream(QString const&) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1460156) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #19 0x589b65c872b4 in Host::send(QString, bool, bool) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1adb2b4) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #20 0x589b65d96517 in TCommandLine::enterCommand(QKeyEvent*) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1bea517) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #21 0x589b65d93095 in TCommandLine::event(QEvent*) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1be7095) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #22 0x7ac668391c8a in QApplicationPrivate::notify_helper(QObject*, QEvent*) /home/qt/work/qt/qtbase/src/widgets/kernel/qapplication.cpp:3307:31 previously allocated by thread T0 here: #0 0x589b64a9b171 in operator new(unsigned long) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x8ef171) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #1 0x589b6500f595 in TLuaInterpreter::startTempAlias(QString const&, QString const&) (/home/vadi/Programs/Mudlet/build/src/mudlet+0xe63595) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #2 0x589b6512c41d in TLuaInterpreter::tempAlias(lua_State*) (/home/vadi/Programs/Mudlet/build/src/mudlet+0xf8041d) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #3 0x7ac66942ffa0 in luaD_precall /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/ldo.c:320:10 #4 0x7ac66943ad7a in luaV_execute /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/lvm.c:591:17 #5 0x7ac66942e96c in luaD_call /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/ldo.c:378:5 #6 0x7ac66942af70 in luaD_rawrunprotected /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/ldo.c:116:3 #7 0x7ac66942bb94 in luaD_pcall /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/ldo.c:464:12 #8 0x7ac66942bce0 in lua_pcall /build/lua5.1-rMDsVj/lua5.1-5.1.5/src/lapi.c:821:12 #9 0x589b64fd65f1 in TLuaInterpreter::call(QString const&, QString const&, bool) (/home/vadi/Programs/Mudlet/build/src/mudlet+0xe2a5f1) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #10 0x589b65d84d31 in TAlias::execute() (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1bd8d31) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #11 0x589b65d84577 in TAlias::match(QString const&) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1bd8577) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #12 0x589b6560c156 in AliasUnit::processDataStream(QString const&) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1460156) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #13 0x589b65c872b4 in Host::send(QString, bool, bool) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1adb2b4) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #14 0x589b65d96517 in TCommandLine::enterCommand(QKeyEvent*) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1bea517) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #15 0x589b65d93095 in TCommandLine::event(QEvent*) (/home/vadi/Programs/Mudlet/build/src/mudlet+0x1be7095) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) #16 0x7ac668391c8a in QApplicationPrivate::notify_helper(QObject*, QEvent*) /home/qt/work/qt/qtbase/src/widgets/kernel/qapplication.cpp:3307:31 SUMMARY: AddressSanitizer: heap-use-after-free (/home/vadi/Programs/Mudlet/build/src/mudlet+0xe8a7f5) (BuildId: c98a5e4208b6daa52aa1b083c4ee6c4ab4552cc4) in Tree<TAlias>::isActive() const Shadow bytes around the buggy address: 0x51200086e400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x51200086e480: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa 0x51200086e500: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd 0x51200086e580: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x51200086e600: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa =>0x51200086e680: fa fa fa fa fa fa fa fa fd fd[fd]fd fd fd fd fd 0x51200086e700: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x51200086e780: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa 0x51200086e800: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd 0x51200086e880: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x51200086e900: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==617553==ABORTING Co-authored-by: Vadim Peretokin <vadi2@users.noreply.github.com>

SlySven reviewed Aug 1, 2014
View reviewed changes

Fix cmake build.

1346314

Add definitions for the APP_* defines and remove a file which was removed in a previous commit but the merge went poorly.

Chris7 added a commit that referenced this pull request Aug 4, 2014

Merge pull request #15 from ahmedcharles/merge_fix

786dd0d

Fix a bad merge from merge 7580b5d.

Chris7 merged commit 786dd0d into Mudlet:development Aug 4, 2014

ahmedcharles deleted the merge_fix branch August 4, 2014 14:24

vadi2 mentioned this pull request Mar 31, 2017

Crash during a lot of spam #769

Closed

Nyyrazzilyss mentioned this pull request Dec 19, 2020

Expanding/collapsing folders in script editor causes crash #4427

Closed

TokugawaTFC mentioned this pull request Jul 22, 2021

Mudlet crashed when timer is run on ChromeOS #5326

Closed

Nyyrazzilyss mentioned this pull request Nov 20, 2021

Segfault in PTB #5666

Closed

This was referenced Aug 30, 2025

Add: map info to the 3D mapper as well #8142

Merged

Mudlet crash when using 3D mapper on profile start. #8149

Closed

vadi2 mentioned this pull request Nov 22, 2025

Fix: heap-use-after-free when cleanup runs during alias/trigger/key processing #8571

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix a bad merge from merge 7580b5d.#15

Fix a bad merge from merge 7580b5d.#15
Chris7 merged 1 commit intoMudlet:developmentfrom
ahmedcharles:merge_fix

ahmedcharles commented Jul 27, 2014

Uh oh!

ahmedcharles commented Jul 31, 2014

Uh oh!

ahmedcharles commented Aug 1, 2014

Uh oh!

SlySven commented Aug 1, 2014

Uh oh!

SlySven Aug 1, 2014

Uh oh!

ahmedcharles Aug 1, 2014

Uh oh!

ahmedcharles commented Aug 1, 2014

Uh oh!

SlySven commented Aug 1, 2014

Uh oh!

Chris7 commented Aug 2, 2014

Uh oh!

vadi2 commented Aug 2, 2014

Uh oh!

ahmedcharles commented Aug 4, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ahmedcharles commented Jul 27, 2014

Uh oh!

ahmedcharles commented Jul 31, 2014

Uh oh!

ahmedcharles commented Aug 1, 2014

Uh oh!

SlySven commented Aug 1, 2014

Uh oh!

SlySven Aug 1, 2014

Choose a reason for hiding this comment

Uh oh!

ahmedcharles Aug 1, 2014

Choose a reason for hiding this comment

Uh oh!

ahmedcharles commented Aug 1, 2014

Uh oh!

SlySven commented Aug 1, 2014

Uh oh!

Chris7 commented Aug 2, 2014

Uh oh!

vadi2 commented Aug 2, 2014

Uh oh!

ahmedcharles commented Aug 4, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants