This repository was archived by the owner on Nov 15, 2025. It is now read-only.
Make volume changing behaviour consistent with OS#630
Closed
krlvm wants to merge 8 commits intoModernFlyouts-Community:devfrom
Closed
Make volume changing behaviour consistent with OS#630krlvm wants to merge 8 commits intoModernFlyouts-Community:devfrom
krlvm wants to merge 8 commits intoModernFlyouts-Community:devfrom
Conversation
…#505) * Updated translators list on README
* Update feature_request.md * Update bug_report.md * Update feature_request.md
Add link to 0.3
* Updated Greek Translation (ModernFlyouts-Community#495) * Updated Greek Translation * Fixed Num Lock Flyout Out of Margins * Flyout animation toggle (ModernFlyouts-Community#511) * widget animation toggle * translation added * Flyout animation toggle - done * minor changes * typo in ru translation * Update Russian translation (ModernFlyouts-Community#510) * Update ModernFlyouts.ru.xlf * Update README.md * Update README.md * Update ModernFlyouts/MultilingualResources/ModernFlyouts.ru.xlf * Update ModernFlyouts/MultilingualResources/ModernFlyouts.ru.xlf * Apply suggestions from code review * - Updated Nuget Packages * Localized Manifest * Remove redundant playground * .wapproj simplification remove redundant windows.universal target * . * Update nuget packages * Update Nuget Packages * Minor cleanup * Finally! Fixed ModernFlyouts-Community#4 - Bug: Audio flyout is not shown when the volume is changed through means other than media keys Fixed ModernFlyouts-Community#470 - Bug: Flyouts doesn't appear while holding any mousebutton * fix null crash * Revert "fix null crash" This reverts commit 4ef6985. * Minor fixes * Translated all strings to danish (ModernFlyouts-Community#516) * Fix issue template syntax error (ModernFlyouts-Community#509) * Add some translators into the list in README (ModernFlyouts-Community#505) * Updated translators list on README * Translated all strings to danish Co-authored-by: Myuki <myuki@outlook.ie> Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com> * Temp enable both zh-hans and zh-cn * Update Ukrainian translation (ModernFlyouts-Community#545) * Fix issue template syntax error (ModernFlyouts-Community#509) * Add some translators into the list in README (ModernFlyouts-Community#505) * Updated translators list on README * Update ModernFlyouts.uk.xlf * Update ModernFlyouts.uk.xlf * Update ModernFlyouts.uk.xlf very important commit) Co-authored-by: Myuki <myuki@outlook.ie> Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com> Co-authored-by: Sam <35312698+Samuel12321@users.noreply.github.com> * Re-Updated Turkish Translation (ModernFlyouts-Community#562) * Fix issue template syntax error (ModernFlyouts-Community#509) * Add some translators into the list in README (ModernFlyouts-Community#505) * Updated translators list on README * Re-Updated Turkish Translation * Re-Updated Turkish Translation v2 Co-authored-by: Myuki <myuki@outlook.ie> Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com> * Fix syntax error for settings.off * updates Co-authored-by: Vasilis Patelis <65589110+VasilisPat@users.noreply.github.com> Co-authored-by: karpovv-boris <78983523+karpovv-boris@users.noreply.github.com> Co-authored-by: Tony <ANT0x1@users.noreply.github.com> Co-authored-by: sam <sam> Co-authored-by: Sam <samuelgilliessmith@hotmail.com> Co-authored-by: Shankar <shankarbus04082001@hotmail.com> Co-authored-by: Emil Nymann Sølyst <emilnymann96@gmail.com> Co-authored-by: Myuki <myuki@outlook.ie> Co-authored-by: imgradeone <30969327+imgradeone@users.noreply.github.com> Co-authored-by: PlayDay <18056374+playday3008@users.noreply.github.com> Co-authored-by: Eren <75967441+ErenAKGUN2007@users.noreply.github.com>
Member
|
TBH, this is what I wanted to do for a long time. But, in #23, @Cyberdroid1 and @Samuel12321 suggested the idea to disable the sliders (that will make it grey) inorder to denote the muted state visually. There was no complaints to change this behavior since then. This PR can be merged. 👍🤌 |
Contributor
Author
|
I'd like to make the slider gray, but I haven't found the way to do that :( |
Member
|
I will try to do that once this PR has been merged 😄 |
Member
|
Why this PR targetting main? Hey fella, can you retarget it to the dev branch? |
Contributor
Author
|
Oh, didn't notice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, when you set volume to 0 in flyout, it did not become muted.
When the audio was muted, it was impossible to adjust volume.
Now that the volume is set to 0, it also mutes can be unmuted by setting the volume to greater than 0, so it is consistent with system volume flyout behaviour.
demo.mp4