deps: @metamask/transaction-controller@^29.1.0->^30.0.0#342
Merged
legobeat merged 2 commits intoMetaMask:mainfrom Jun 3, 2024
Merged
deps: @metamask/transaction-controller@^29.1.0->^30.0.0#342legobeat merged 2 commits intoMetaMask:mainfrom
legobeat merged 2 commits intoMetaMask:mainfrom
Conversation
3112700 to
1bcb155
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/eth-block-tracker@8.1.0, npm/nonce-tracker@3.0.0 |
7 tasks
This was referenced May 29, 2024
Merged
16429d7 to
3ec18be
Compare
Contributor
Author
This was referenced Jun 3, 2024
dan437
approved these changes
Jun 3, 2024
Merged
7 tasks
dan437
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jun 5, 2024
## **Description** This effectively relates to two separate fixes for issues with polling behavior. - https://github.com/MetaMask/smart-transactions-controller/releases/tag/v10.1.1 [](https://codespaces.new/MetaMask/metamask-extension/pull/25030?quickstart=1) ## **Related issues** - Follow-up to and aligns with #24861 - #24913 ### Contents Highlights - MetaMask/smart-transactions-controller@v10.0.1...v10.1.1 - MetaMask/smart-transactions-controller#347 - MetaMask/smart-transactions-controller#339 - MetaMask/smart-transactions-controller#342 ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
danjm
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jun 13, 2024
This effectively relates to two separate fixes for issues with polling behavior. - https://github.com/MetaMask/smart-transactions-controller/releases/tag/v10.1.1 [](https://codespaces.new/MetaMask/metamask-extension/pull/25030?quickstart=1) - Follow-up to and aligns with #24861 - #24913 - MetaMask/smart-transactions-controller@v10.0.1...v10.1.1 - MetaMask/smart-transactions-controller#347 - MetaMask/smart-transactions-controller#339 - MetaMask/smart-transactions-controller#342 - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensuring latest version is of
@metamask/transaction-controllercan be used with this package.Blocking