fix: bump assets controller to 30.0.0 by salimtb · Pull Request #24913 · MetaMask/metamask-extension

salimtb · 2024-05-30T17:55:41Z

Description

Upgrades to version 30 of assets controllers, bringing a new marketData object to the token rates controller.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-05-30T17:55:52Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

bergeron · 2024-05-30T22:46:35Z

I'm looking through remaining occurrences of contractExchangeRates and contractExchangeRatesByChainId in state / mocked state

yarn.lock

for nonce-tracker/block-tracker bump

The currently replaced versions are verified compatible. Fixes nonce-tracker issue

bergeron · 2024-05-31T17:47:30Z

@metamaskbot update-policies

metamaskbot · 2024-05-31T17:57:22Z

Policies updated

…metamask-extension into bump-assets-controller-version

sahar-fehri · 2024-06-04T13:11:23Z

NFT detection flow works as expected.
Import/hide NFT working as expected.
When trying to send an NFT i have this error in the console and the transaction fails
SES_UNHANDLED_REJECTION: EthereumRpcError: header not found
Are you guys able to reproduce this too?
I suspect same error happens when you try to send an ERC20.
(video)

Screen.Recording.2024-06-04.at.15.08.44.mov

sahar-fehri · 2024-06-04T13:18:59Z

I confirm that i have seen same behavior happen when trying to send an ERC2O.
Also, noticed some glitches in the send flow, where sometimes when i try to send DAI, i see error
Error: Unable to determine contract standard
(video)

Screen.Recording.2024-06-04.at.15.16.05.mov

metamaskbot · 2024-06-04T16:54:15Z

Builds ready [87dd240]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (51 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	120	82	13	6
		domContentLoaded	8	20	10	3	1
		load	42	75	51	9	4
		domInteractive	8	20	10	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.01 KiB (0.03%)
ui: 72 Bytes (0.00%)
common: 22.93 KiB (0.37%)

metamaskbot · 2024-06-04T19:56:19Z

Builds ready [9fb556f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (141 ± 173 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	134	95	17	8
		domContentLoaded	8	16	12	2	1
		load	40	1710	141	360	173
		domInteractive	8	16	12	2	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.01 KiB (0.03%)
ui: 72 Bytes (0.00%)
common: 22.93 KiB (0.37%)

danjm · 2024-06-04T21:24:43Z

privacy-snapshot.json

-  "oidc.api.cx.metamask.io"
+  "oidc.api.cx.metamask.io",
+  "price.api.cx.metamask.io",
+  "token.api.cx.metamask.io"


Given the inclusion of "token.api.cx.metamask.io" should "token-api.metaswap.codefi.network", be removed?

I tried to remove it, but there was still a usage somewhere. I will tackle it separately from this upgrade.

Looks like it's becuase this comes from @metamask/controller-utils, and since this PR introduces the new version but is still using the older one(s) simultaneously, it will hit a different endpoint depending on which of the versions is used.

https://github.com/MetaMask/metamask-extension/pull/24913/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2deL4770

@danjm @legobeat @bergeron there's this PR which is currently blocked by this one that removes old metaswap, metafi urls -> we can keep both urls for now until mine is merged

> [!NOTE] > This PR is intended to be cherry-picked into RC 11.17.0 after being merged into develop ## **Description** Upgrade transaction-controller to get this fix: MetaMask/core#4343 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24947?quickstart=1) ## **Related issues** Fixes: A recent update to the transaction-controller has made the TransactionMeta object passed to the afterSign hook frozen. This change prevents adding new properties, leading to the error: “Cannot add property custodyId, object is not extensible.” This bug is breaking all transactions for MMI as the original txMeta cannot store required properties like custodyId. Blocked by #24861 Blocked by #24913 ## **Manual testing steps** I followed these steps to test the fix: 1. yarn && yarn start:mmi 2. create a new wallet 3. visit https://saturn-custody-ui.dev.metamask-institutional.io/ and add two custodial addresses 4. send 0ETH from one custodial address to the other You should see a popup with an Approve button. Before this fix, the transaction would appear in the activity tab with an error. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>

danjm

Approving the privacy-snapshot.json update on behalf of privacy reviewers

salimtb requested a review from a team as a code owner May 30, 2024 17:55

salimtb added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 30, 2024

salimtb marked this pull request as draft May 30, 2024 17:55

metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label May 30, 2024

salimtb added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 30, 2024

legobeat reviewed May 30, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

legobeat and others added 9 commits May 31, 2024 14:24

deps: @metamask/network-controller@^18.1.1->^18.1.2

d089168

fix(deps): @metamask/transaction-controller@^29.1.0->^30.0.0

dce3d43

for nonce-tracker/block-tracker bump

fix: force @metamask/transaction-controller to ^30.0.0

fc950be

The currently replaced versions are verified compatible. Fixes nonce-tracker issue

update lavamoat policies

cda63c9

fix: bump assets controller

c339ffd

fix nft controllers accessing getNetworkClientById

6c845db

remove unused patches

a5f795d

fix: fix getTokenExchangeRates selectors

dbab437

fix: update yarn after rebase

c4ec3b2

salimtb force-pushed the bump-assets-controller-version branch from 6dd2c8d to c4ec3b2 Compare May 31, 2024 14:56

fix unit tests

c4ebdf0

salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels May 31, 2024

Update LavaMoat policies

c8e6385

bergeron added 6 commits May 31, 2024 11:12

add metamask.io domains to privacy snapshot

f4a05df

Merge branch 'bump-assets-controller-version' of github.com:MetaMask/…

efa27ad

…metamask-extension into bump-assets-controller-version

Merge branch 'develop' into bump-assets-controller-version

85c97fa

move more api endpoints to new metamask.io domain

fe6df70

Merge branch 'bump-assets-controller-version' of github.com:MetaMask/…

c036089

…metamask-extension into bump-assets-controller-version

fix e2e test

5cb151c

legobeat mentioned this pull request Jun 4, 2024

fix: @metamask/smart-transactions-controller@^10.0.1->^10.1.1 #25030

Merged

7 tasks

Merge branch 'develop' into bump-assets-controller-version

87dd240

Merge branch 'develop' into bump-assets-controller-version

9fb556f

bergeron previously approved these changes Jun 4, 2024

View reviewed changes

dbrans mentioned this pull request Jun 4, 2024

fix: upgrade transaction-controller to 32.0.0 to fix mmi #24947

Merged

7 tasks

legobeat requested a review from a team June 4, 2024 21:07

danjm reviewed Jun 4, 2024

View reviewed changes

Merge branch 'develop' into bump-assets-controller-version

d40c703

danjm previously approved these changes Jun 5, 2024

View reviewed changes

Merge branch 'develop' into bump-assets-controller-version

1ee4a84

salimtb dismissed stale reviews from danjm, legobeat, and bergeron via 1ee4a84 June 5, 2024 10:04

salimtb requested review from bergeron, danjm and legobeat June 5, 2024 10:04

fix: fix conflict with PR #24947

83a317d

bergeron mentioned this pull request Jun 5, 2024

fix: Migrate API usage from *.metafi and *.metaswap subdomains to *.api.cx.metamask.io #24698

Merged

7 tasks

bergeron approved these changes Jun 5, 2024

View reviewed changes

danjm approved these changes Jun 5, 2024

View reviewed changes

bergeron merged commit 3c4e17b into develop Jun 5, 2024

bergeron deleted the bump-assets-controller-version branch June 5, 2024 14:57

github-actions bot locked and limited conversation to collaborators Jun 5, 2024

metamaskbot added the release-11.18.0 label Jun 5, 2024

gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024

Conversation

salimtb commented May 30, 2024 • edited by bergeron Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 30, 2024

Uh oh!

bergeron commented May 30, 2024

Uh oh!

Uh oh!

bergeron commented May 31, 2024

Uh oh!

metamaskbot commented May 31, 2024

Uh oh!

sahar-fehri commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sahar-fehri commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metamaskbot commented Jun 4, 2024

Uh oh!

metamaskbot commented Jun 4, 2024

Uh oh!

danjm Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

bergeron Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

legobeat Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cryptodev-2s Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danjm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

salimtb commented May 30, 2024 •

edited by bergeron

Loading

sahar-fehri commented Jun 4, 2024 •

edited

Loading

sahar-fehri commented Jun 4, 2024 •

edited

Loading

legobeat Jun 4, 2024 •

edited

Loading

cryptodev-2s Jun 5, 2024 •

edited

Loading