fix: Migrate API usage from *.metafi and *.metaswap subdomains to *.api.cx.metamask.io by cryptodev-2s · Pull Request #24698 · MetaMask/metamask-extension

cryptodev-2s · 2024-05-21T22:16:46Z

Description

API Platform team intends to deprecate *.metafi and *.metaswap subdomains in favour of *.api.cx.metamask.io
The new *.api.cx.metamask.io is already in place.
The old *.metafi and *.metaswap are still used across the controllers.
Controllers do not break currently because redirects are in place for the older sub-domains.
The redirects will be removed once all clients (Extension, Mobile, Core) are migrated.

Related issues

Fixes: #2351

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-05-21T22:16:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…pi.cx.metamask.io

georgewrmarshall

The updates to the component-library folder look great! There's one failing unit test and some possibly flaky e2e tests to address. I can approve on behalf of @MetaMask/design-system-engineers once those are resolved.

Verified that new image links in AvatarToken are working. ✅

socket-security · 2024-06-05T16:49:42Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/name-controller@8.0.0	Transitive: network	`+3`	544 kB

🚮 Removed packages: npm/@metamask/name-controller@6.0.1

View full report↗︎

socket-security · 2024-06-05T16:49:45Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

cryptodev-2s · 2024-06-05T17:08:12Z

@metamaskbot update-policies

metamaskbot · 2024-06-05T17:18:25Z

Policies updated

metamaskbot · 2024-06-05T18:18:46Z

Builds ready [8b83b3b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (116 ± 144 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	92	81	6	3
		domContentLoaded	8	17	10	2	1
		load	41	1427	116	301	144
		domInteractive	8	17	10	2	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 137.22 KiB (4.14%)
ui: 0 Bytes (0.00%)
common: 58.43 KiB (0.94%)

codecov · 2024-06-05T18:19:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.39%. Comparing base (d27a233) to head (8b83b3b).
Report is 264 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24698      +/-   ##
===========================================
- Coverage    67.37%   65.39%   -1.98%     
===========================================
  Files         1278     1351      +73     
  Lines        49881    53961    +4080     
  Branches     12944    14037    +1093     
===========================================
+ Hits         33605    35283    +1678     
- Misses       16276    18678    +2402

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cryptodev-2s · 2024-06-05T18:24:41Z

The updates to the component-library folder look great! There's one failing unit test and some possibly flaky e2e tests to address. I can approve on behalf of @MetaMask/design-system-engineers once those are resolved.

Verified that new image links in AvatarToken are working. ✅

Pipeline is back to green

cryptodev-2s · 2024-06-05T18:29:19Z

@SocketSecurity ignore npm/@metamask/name-controller@6.0.1

georgewrmarshall

LGTM! 🚀 Approving on behalf of @MetaMask/design-system-engineers

Checked to ensure no remaining instances of metafi.codefi.network in codebase ✅
Checked for console errors ✅
Check some image links in storybook and app render as expected ✅

kanthesha

LGTM.

Prithpal-Sooriya

Good on the notifications side (we are not using any of the old API domains)

pedronfigueiredo

I reviewed the privacy snapshots. LGTM!

cryptodev-2s requested review from a team as code owners May 21, 2024 22:16

cryptodev-2s added the team-shared-libraries label May 21, 2024

fix: Migrate API usage from *.metafi and *.metaswap subdomains to *.a…

94c9a24

…pi.cx.metamask.io

cryptodev-2s force-pushed the fix/replace-metafi-metaswap-subdomains branch from 15c4cdc to 94c9a24 Compare May 21, 2024 22:25

cryptodev-2s and others added 2 commits May 22, 2024 00:39

fix: add proxy.api.cx.metamask.io to privacy snapshots

409c6ee

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

c627e4f

georgewrmarshall reviewed May 22, 2024

View reviewed changes

cryptodev-2s and others added 3 commits May 22, 2024 18:13

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

70becda

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

12beffc

fix: bump phishing controller to version 9.0.3

08b4b35

cryptodev-2s changed the title ~~Migrate API usage from *.metafi and *.metaswap subdomains to *.api.cx.metamask.io~~ fix: Migrate API usage from *.metafi and *.metaswap subdomains to *.api.cx.metamask.io May 23, 2024

cryptodev-2s and others added 14 commits May 23, 2024 22:19

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

b4efa6f

fix: run yarn dedupe

3de2c39

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

08e2bb1

fix: bump assets-controllers

c456225

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

366ed45

fix: add missing nft controller action

dd92ad6

fix: nft detection controller missing constructor param

5657728

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

eeb8a87

fix: run yarn dedupe

8d0c350

fix: linting

4fa8b76

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

ee46e7e

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

ebd49fe

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

5d2b1f1

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

2ea8fe2

cryptodev-2s and others added 5 commits June 5, 2024 17:21

fix: remove duplicated nft detection controller option

a45e496

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

58287b8

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

7540f7f

Merge branch 'develop' into fix/replace-metafi-metaswap-subdomains

83c9698

fix: bump @metamask/name-controller and @metamask/name-controller

977fff3

Update LavaMoat policies

8b83b3b

metamaskbot requested review from a team as code owners June 5, 2024 17:18

cryptodev-2s requested review from bergeron and georgewrmarshall June 5, 2024 18:07

georgewrmarshall approved these changes Jun 5, 2024

View reviewed changes

cryptodev-2s removed the request for review from bergeron June 5, 2024 20:24

kanthesha approved these changes Jun 6, 2024

View reviewed changes

mikesposito approved these changes Jun 6, 2024

View reviewed changes

matthewwalsh0 approved these changes Jun 6, 2024

View reviewed changes

Prithpal-Sooriya approved these changes Jun 6, 2024

View reviewed changes

pedronfigueiredo approved these changes Jun 6, 2024

View reviewed changes

cryptodev-2s merged commit e6e3251 into develop Jun 6, 2024

cryptodev-2s deleted the fix/replace-metafi-metaswap-subdomains branch June 6, 2024 11:42

github-actions bot locked and limited conversation to collaborators Jun 6, 2024

metamaskbot added the release-11.18.0 label Jun 6, 2024

gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024

Conversation

cryptodev-2s commented May 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 21, 2024

Uh oh!

georgewrmarshall left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cryptodev-2s commented Jun 5, 2024

Uh oh!

metamaskbot commented Jun 5, 2024

Uh oh!

metamaskbot commented Jun 5, 2024

Uh oh!

codecov bot commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cryptodev-2s commented Jun 5, 2024

Uh oh!

cryptodev-2s commented Jun 5, 2024

Uh oh!

georgewrmarshall left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kanthesha left a comment

Choose a reason for hiding this comment

Uh oh!

Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

Uh oh!

pedronfigueiredo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

cryptodev-2s commented May 21, 2024 •

edited

Loading

georgewrmarshall left a comment •

edited

Loading

socket-security bot commented Jun 5, 2024 •

edited

Loading

socket-security bot commented Jun 5, 2024 •

edited

Loading

codecov bot commented Jun 5, 2024 •

edited

Loading

georgewrmarshall left a comment •

edited

Loading