fix: @metamask/transaction-controller@^29.1.0->^30.0.0 by legobeat · Pull Request #24861 · MetaMask/metamask-extension

legobeat · 2024-05-29T12:08:22Z

Description

Updates @metamask/transaction-controller and @metamask/network-controller to use latest version of @metamask/eth-block-tracker containing fix for multiple polling loops.
Updates @metamask/network-controller for the same and ensuring block tracker is in sync.

The nonce-tracker patch is removed as the changes have been incorporated in the new version, which is now used consistently.

Related issues

Prevent multiple simultaneous polling loops eth-block-tracker#208
chore(dependencies): @metamask/eth-token-tracker@^7.0.2->^8.0.0 #24855 the same fix for @metamask/eth-token-tracker
deps: @metamask/transaction-controller@^29.1.0->^30.0.0 smart-transactions-controller#342

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-05-29T12:08:35Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-05-29T12:19:58Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/network-controller@18.1.2	environment	`+6`	792 kB	metamaskbot
npm/@metamask/nonce-tracker@5.0.0	None	`+1`	64.5 kB
npm/@metamask/transaction-controller@30.0.0	None	`+1`	129 kB

🚮 Removed packages: npm/@metamask/network-controller@18.1.0

View full report↗︎

codecov · 2024-05-29T17:04:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.71%. Comparing base (63851c9) to head (d06eb7c).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24861      +/-   ##
===========================================
- Coverage    65.71%   65.71%   -0.00%     
===========================================
  Files         1368     1368              
  Lines        54388    54388              
  Branches     14150    14150              
===========================================
- Hits         35739    35737       -2     
- Misses       18649    18651       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

salimtb · 2024-05-31T14:34:00Z

hey @legobeat ,
what is the best scenario you suggest for testing/QA the changes of this PR ? maybe i should trigger a transaction using the extension and check the nonce ?

dbrans · 2024-05-31T18:52:38Z

@legobeat fyi: I've got a PR to upgrade transaction-controller to 31.0.0 fix mmi

legobeat · 2024-05-31T20:14:29Z

@legobeat fyi: I've got a PR to upgrade transaction-controller to 31.0.0 fix mmi

👍 Makes sense to bump to 30, and then to 32? One step at a time.

@dbrans Do you see any blockers for this one (v30)?

dbrans · 2024-06-03T12:39:01Z

Does this PR need a newer STX v10.1.1?

legobeat · 2024-06-03T15:05:05Z

Does this PR need a newer STX v10.1.1?

@dbrans No, we do want to merge those changes in separately since pulling it in here would be two potentially subtle block-tracking changes in one commit, which will make it hard to analyze results.

for nonce-tracker/block-tracker bump

The currently replaced versions are verified compatible. Fixes nonce-tracker issue

legobeat requested a review from matthewwalsh0 May 29, 2024 12:08

legobeat changed the title ~~deps: @metamask/transaction-controller@^29.1.0->^30.0.0~~ fix: @metamask/transaction-controller@^29.1.0->^30.0.0 May 29, 2024

legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels May 29, 2024

legobeat requested a review from dbrans May 29, 2024 12:12

legobeat marked this pull request as ready for review May 29, 2024 12:13

legobeat requested review from a team as code owners May 29, 2024 12:13

legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch from a885388 to 4da3ec0 Compare May 29, 2024 12:19

legobeat mentioned this pull request May 29, 2024

chore(dependencies): @metamask/eth-token-tracker@^7.0.2->^8.0.0 #24855

Merged

7 tasks

legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 2 times, most recently from dff2780 to cf6187c Compare May 29, 2024 13:56

legobeat requested review from mcmire and naugtur May 29, 2024 13:58

legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 3 times, most recently from 7b44c5a to 36b6c33 Compare May 29, 2024 16:25

legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 9 times, most recently from d288c19 to 6bb8cee Compare May 29, 2024 23:26

legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 5 times, most recently from 15ba5ec to cda63c9 Compare May 31, 2024 14:25

legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch from cda63c9 to 2cc97aa Compare May 31, 2024 17:44

legobeat requested review from dbrans and removed request for dbrans May 31, 2024 20:15

legobeat mentioned this pull request May 31, 2024

fix: upgrade transaction-controller to 32.0.0 to fix mmi #24947

Merged

7 tasks

legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch 2 times, most recently from 90bf936 to 63dba58 Compare May 31, 2024 20:41

legobeat requested review from dan437, jiexi and mcmire and removed request for mcmire May 31, 2024 20:42

legobeat force-pushed the fix-block-tracker-multiple-polling-loops branch from 63dba58 to cf0b9f5 Compare May 31, 2024 23:09

dbrans previously approved these changes Jun 3, 2024

View reviewed changes

zone-live previously approved these changes Jun 3, 2024

View reviewed changes

dbrans approved these changes Jun 3, 2024

View reviewed changes

legobeat added 5 commits June 3, 2024 20:50

sync yarn.lock

70c702d

deps: @metamask/network-controller@^18.1.1->^18.1.2

305f1bc

fix(deps): @metamask/transaction-controller@^29.1.0->^30.0.0

54a58b8

for nonce-tracker/block-tracker bump

fix: force @metamask/transaction-controller to ^30.0.0

bc18c0e

The currently replaced versions are verified compatible. Fixes nonce-tracker issue

update lavamoat policies

d06eb7c

bergeron approved these changes Jun 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: @metamask/transaction-controller@^29.1.0->^30.0.0#24861

fix: @metamask/transaction-controller@^29.1.0->^30.0.0#24861
legobeat merged 5 commits intoMetaMask:developfrom
legobeat:fix-block-tracker-multiple-polling-loops

legobeat commented May 29, 2024 •

edited

Loading

Uh oh!

github-actions bot commented May 29, 2024

Uh oh!

socket-security bot commented May 29, 2024 •

edited

Loading

Uh oh!

codecov bot commented May 29, 2024 •

edited

Loading

Uh oh!

salimtb commented May 31, 2024

Uh oh!

dbrans commented May 31, 2024

Uh oh!

legobeat commented May 31, 2024 •

edited

Loading

Uh oh!

dbrans commented Jun 3, 2024

Uh oh!

legobeat commented Jun 3, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

legobeat commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 29, 2024

Uh oh!

socket-security bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

salimtb commented May 31, 2024

Uh oh!

dbrans commented May 31, 2024

Uh oh!

legobeat commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbrans commented Jun 3, 2024

Uh oh!

legobeat commented Jun 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

legobeat commented May 29, 2024 •

edited

Loading

socket-security bot commented May 29, 2024 •

edited

Loading

codecov bot commented May 29, 2024 •

edited

Loading

legobeat commented May 31, 2024 •

edited

Loading

legobeat commented Jun 3, 2024 •

edited

Loading