Skip to content

fix: @metamask/smart-transactions-controller@^10.0.1->^10.1.1#25030

Merged
dan437 merged 2 commits intoMetaMask:developfrom
legobeat:deps-smart-transactions-controller-10.1.1
Jun 5, 2024
Merged

fix: @metamask/smart-transactions-controller@^10.0.1->^10.1.1#25030
dan437 merged 2 commits intoMetaMask:developfrom
legobeat:deps-smart-transactions-controller-10.1.1

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Jun 4, 2024 •
edited
Loading

Description

This effectively relates to two separate fixes for issues with polling behavior.

Open in GitHub Codespaces

Related issues

Contents Highlights

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat requested review from dan437 and dbrans June 4, 2024 11:16
@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Jun 4, 2024
@legobeat legobeat force-pushed the deps-smart-transactions-controller-10.1.1 branch from 9d9fbf7 to 8683424 Compare June 4, 2024 11:18
@legobeat legobeat changed the title fix: @metamask/smart-transactions-controller@^10.0.1->^10.1.0 fix: @metamask/smart-transactions-controller@^10.0.1->^10.1.1 Jun 4, 2024
@legobeat legobeat marked this pull request as ready for review June 4, 2024 19:02
@legobeat legobeat requested a review from a team as a code owner June 4, 2024 19:02
@legobeat legobeat force-pushed the deps-smart-transactions-controller-10.1.1 branch from 8683424 to 6ccf274 Compare June 4, 2024 19:02
@legobeat legobeat force-pushed the deps-smart-transactions-controller-10.1.1 branch from 6ccf274 to 9dcc2ca Compare June 4, 2024 20:29
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.69%. Comparing base (37f90a0) to head (9dcc2ca).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #25030      +/-   ##
===========================================
- Coverage    65.69%   65.69%   -0.00%     
===========================================
  Files         1369     1369              
  Lines        54377    54377              
  Branches     14156    14156              
===========================================
- Hits         35719    35718       -1     
- Misses       18658    18659       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan437 dan437 merged commit c4712af into MetaMask:develop Jun 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
@legobeat legobeat deleted the deps-smart-transactions-controller-10.1.1 branch June 5, 2024 16:32
@benjisclowder benjisclowder added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dan437 dan437 dan437 approved these changes

+1 more reviewer

@dbrans dbrans dbrans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-application-security Application security team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat @dbrans @dan437 @benjisclowder