Skip to content

Add category in eventOpts#9164

Merged
Gudahtt merged 1 commit intodevelopfrom
eventCategory
Aug 9, 2020
Merged

Add category in eventOpts#9164
Gudahtt merged 1 commit intodevelopfrom
eventCategory

Conversation

@tmashuang
Copy link
Copy Markdown
Contributor

Add category into config.eventOpts where we use it to compose the url with the action and name, instead of the top level config.

@tmashuang tmashuang requested a review from a team as a code owner August 9, 2020 01:47
@tmashuang tmashuang requested a review from Gudahtt August 9, 2020 01:47
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [3b81fea]
Page Load Metrics (554 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29403342
domContentLoaded2646415539747
load2666425549747
domInteractive2646405529747

@tmashuang tmashuang mentioned this pull request Aug 9, 2020
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! LGTM

@Gudahtt Gudahtt merged commit 3a7097a into develop Aug 9, 2020
@Gudahtt Gudahtt deleted the eventCategory branch August 9, 2020 03:42
Gudahtt pushed a commit that referenced this pull request Aug 9, 2020
Gudahtt added a commit that referenced this pull request Aug 10, 2020
* origin/master: (44 commits)
  Add category in eventOpts (#9164)
  Update changelog for v8.0.7 (#9161)
  Version v8.0.7
  Remove web3 e2e tests (#9159)
  Add web3 usage metrics, prepare for web3 removal (#9144)
  Use `pathname` instead of URL for `currentPath` metrics parameter (#9158)
  Remove `url` parameter from `metricsEvent` (#9157)
  Change MetaMetrics category for background events (#9155)
  remove .network-name height
  Use luxon@1.24.1 (#9154)
  Update 'react-devtools' to ^4.8.0 (#9140)
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  Update `brfs` from v1.6.1 to v2.0.2 (#9115)
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants