Skip to content

Add source map validator to CI#9135

Merged
Gudahtt merged 1 commit intodevelopfrom
add-source-map-validator-to-CI
Aug 4, 2020
Merged

Add source map validator to CI#9135
Gudahtt merged 1 commit intodevelopfrom
add-source-map-validator-to-CI

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Aug 4, 2020

Source maps are now validated during CI. This is done during a new job called "validate-source-maps`, and it is required to pass for tests to pass.

@Gudahtt
Copy link
Copy Markdown
Member Author

Gudahtt commented Aug 4, 2020

This depends upon #9132, #9133, and #9134.

Edit: All dependencies have been merged and this has been rebased.

Source maps are now validated during CI. This is done during a new job
called "validate-source-maps`, and it is required to pass for tests to
pass.
@Gudahtt Gudahtt force-pushed the add-source-map-validator-to-CI branch from d8de656 to 6296314 Compare August 4, 2020 16:45
@Gudahtt Gudahtt marked this pull request as ready for review August 4, 2020 17:07
@Gudahtt Gudahtt requested review from a team and kumavis as code owners August 4, 2020 17:07
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [6296314]
Page Load Metrics (711 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3010654188
domContentLoaded34094670918589
load34594871118488
domInteractive33994670918589

@Gudahtt Gudahtt merged commit f7edc83 into develop Aug 4, 2020
@Gudahtt Gudahtt deleted the add-source-map-validator-to-CI branch August 4, 2020 17:21
Gudahtt added a commit that referenced this pull request Aug 5, 2020
* origin/develop:
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  remove unused tx-list styles (#9121)
  delete unused confirm styles (#9118)
Gudahtt added a commit that referenced this pull request Aug 7, 2020
Source maps are now validated during CI. This is done during a new job
called "validate-source-maps`, and it is required to pass for tests to
pass.
Gudahtt added a commit that referenced this pull request Aug 10, 2020
* origin/master: (44 commits)
  Add category in eventOpts (#9164)
  Update changelog for v8.0.7 (#9161)
  Version v8.0.7
  Remove web3 e2e tests (#9159)
  Add web3 usage metrics, prepare for web3 removal (#9144)
  Use `pathname` instead of URL for `currentPath` metrics parameter (#9158)
  Remove `url` parameter from `metricsEvent` (#9157)
  Change MetaMetrics category for background events (#9155)
  remove .network-name height
  Use luxon@1.24.1 (#9154)
  Update 'react-devtools' to ^4.8.0 (#9140)
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  Update `brfs` from v1.6.1 to v2.0.2 (#9115)
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants