Update 'react-devtools' to ^4.8.0#9140
Merged
tmashuang merged 2 commits intoMetaMask:developfrom Aug 6, 2020
Merged
Conversation
whymarrh
previously requested changes
Aug 6, 2020
Contributor
whymarrh
left a comment
There was a problem hiding this comment.
LGTM but I think there might be some uncommitted lockfile changes here.
Would you mind running yarn and seeing if there are any extra changes?
Contributor
Author
|
There were, just didn't know if they were relevant or not, so I redacted them. Will provide them. |
Contributor
|
I'm not sure why the build is failing from a quick look, want to try rebasing this on the latest |
Contributor
Author
|
Pretty sure it was me pushing the branch to this repo then deleting, even though the head is from my fork, tangling up the CI. I'll resolve. |
d0c0297 to
7141a1f
Compare
Gudahtt
pushed a commit
that referenced
this pull request
Aug 7, 2020
* bump-react-devtools * Completed yarn lock after version bump of react-devtools
Gudahtt
added a commit
that referenced
this pull request
Aug 10, 2020
* origin/master: (44 commits) Add category in eventOpts (#9164) Update changelog for v8.0.7 (#9161) Version v8.0.7 Remove web3 e2e tests (#9159) Add web3 usage metrics, prepare for web3 removal (#9144) Use `pathname` instead of URL for `currentPath` metrics parameter (#9158) Remove `url` parameter from `metricsEvent` (#9157) Change MetaMetrics category for background events (#9155) remove .network-name height Use luxon@1.24.1 (#9154) Update 'react-devtools' to ^4.8.0 (#9140) Fix connection removal bug (#9137) Add source map validator to CI (#9135) Update source map validator target files (#9133) Improve sourcemap validator console report (#9131) Add `validate-source-maps` npm script (#9134) Non-zero exit code upon failure to validate source maps (#9132) Update `brfs` from v1.6.1 to v2.0.2 (#9115) Factor out `getEnvironment` function in build script (#9114) Update `browserify` from v16.2.3 to v16.5.1 (#9113) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One noticeable fix is the ability to resize the standalone app.