Skip to content

Improve sourcemap validator console report#9131

Merged
Gudahtt merged 1 commit intodevelopfrom
improve-sourcemap-validator-console-report
Aug 4, 2020
Merged

Improve sourcemap validator console report#9131
Gudahtt merged 1 commit intodevelopfrom
improve-sourcemap-validator-console-report

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Aug 4, 2020

The report printed to the console for invalid source map samples has been improved in a few ways:

  • The entire message is now printed using console.error, so the contents aren't split between STDERR and STDOUT
  • The code fence is now guaranteed to be a set length, rather than it varying depending on the filename
  • The code fence is no longer padded on the inside with newlines, which results in a more compact output that is (in my opinion) just as readable.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d6fca96]
Page Load Metrics (636 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3110440157
domContentLoaded5917076343115
load5937096363115
domInteractive5917076343115

@Gudahtt Gudahtt marked this pull request as ready for review August 4, 2020 14:11
@Gudahtt Gudahtt requested review from a team and kumavis as code owners August 4, 2020 14:11
rekmarks
rekmarks previously approved these changes Aug 4, 2020
Copy link
Copy Markdown
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The report printed to the console for invalid source map samples has
been improved in a few ways:

* The entire message is now printed using `console.error`, so the
contents aren't split between STDERR and STDOUT
* The code fence is now guaranteed to be a set length, rather than it
varying depending on the filename
* The code fence is no longer padded on the inside with newlines, which
results in a more compact output that is (in my opinion) just as
readable.
@Gudahtt Gudahtt force-pushed the improve-sourcemap-validator-console-report branch from d6fca96 to 381da0b Compare August 4, 2020 15:26
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [381da0b]
Page Load Metrics (545 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27413242
domContentLoaded3126385439847
load3136385459847
domInteractive3126375439847

@Gudahtt Gudahtt merged commit 7f87bdb into develop Aug 4, 2020
@Gudahtt Gudahtt deleted the improve-sourcemap-validator-console-report branch August 4, 2020 15:55
Gudahtt added a commit that referenced this pull request Aug 5, 2020
* origin/develop:
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  remove unused tx-list styles (#9121)
  delete unused confirm styles (#9118)
Gudahtt added a commit that referenced this pull request Aug 7, 2020
The report printed to the console for invalid source map samples has
been improved in a few ways:

* The entire message is now printed using `console.error`, so the
contents aren't split between STDERR and STDOUT
* The code fence is now guaranteed to be a set length, rather than it
varying depending on the filename
* The code fence is no longer padded on the inside with newlines, which
results in a more compact output that is (in my opinion) just as
readable.
Gudahtt added a commit that referenced this pull request Aug 10, 2020
* origin/master: (44 commits)
  Add category in eventOpts (#9164)
  Update changelog for v8.0.7 (#9161)
  Version v8.0.7
  Remove web3 e2e tests (#9159)
  Add web3 usage metrics, prepare for web3 removal (#9144)
  Use `pathname` instead of URL for `currentPath` metrics parameter (#9158)
  Remove `url` parameter from `metricsEvent` (#9157)
  Change MetaMetrics category for background events (#9155)
  remove .network-name height
  Use luxon@1.24.1 (#9154)
  Update 'react-devtools' to ^4.8.0 (#9140)
  Fix connection removal bug (#9137)
  Add source map validator to CI (#9135)
  Update source map validator target files (#9133)
  Improve sourcemap validator console report (#9131)
  Add `validate-source-maps` npm script (#9134)
  Non-zero exit code upon failure to validate source maps (#9132)
  Update `brfs` from v1.6.1 to v2.0.2 (#9115)
  Factor out `getEnvironment` function in build script (#9114)
  Update `browserify` from v16.2.3 to v16.5.1 (#9113)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants