Skip to content

Update wording on export private key modal#5535

Merged
whymarrh merged 2 commits intoMetaMask:developfrom
whymarrh:export-privkey-words
Oct 16, 2018
Merged

Update wording on export private key modal#5535
whymarrh merged 2 commits intoMetaMask:developfrom
whymarrh:export-privkey-words

Conversation

@whymarrh
Copy link
Copy Markdown
Contributor

Fixes #5314

This PR updates the wording on the export private key modal, to clarify that the password we are using the MetaMask password.

Before & after:

screen shot 2018-10-16 at 17 04 16

@alextsg
Copy link
Copy Markdown
Contributor

alextsg commented Oct 16, 2018

I just noticed that the red text says ".. can take steal any assets"

@whymarrh
Copy link
Copy Markdown
Contributor Author

Good catch, fixed!

@whymarrh whymarrh merged commit 0c09567 into MetaMask:develop Oct 16, 2018
@whymarrh whymarrh deleted the export-privkey-words branch October 16, 2018 22:36
mikesposito added a commit that referenced this pull request Mar 25, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Bumping `@metamask/keyring-controller` to 19.2.2

```markdown
## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](MetaMask/core#5353))
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31293?quickstart=1)

## **Related issues**

Related: #31200

## **Manual testing steps**

1. Start with an installation from before we introduced
keyringsMetadata, proceed past onboarding so that you have a vault setup
(e.g. v12.12.0)
2. Upgrade to this branch
3. Start the extension (without logging in)
4. Leave the window open a while to give it time to initialize all
controllers
5. Reload the extension before unlocking
6. Try to unlock the wallet

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Mar 25, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Bumping `@metamask/keyring-controller` to ^21.0.1

```markdown
## [21.0.1]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31293?quickstart=1)

## **Related issues**

Fixes: #31200

## **Manual testing steps**

1. Start with an installation from before we introduced
keyringsMetadata, proceed past onboarding so that you have a vault setup
(e.g. v12.12.0)
2. Upgrade to this branch
3. Start the extension (without logging in)
4. Leave the window open a while to give it time to initialize all
controllers
5. Reload the extension before unlocking
6. Try to unlock the wallet

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
dbrans pushed a commit that referenced this pull request Apr 3, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Bumping `@metamask/keyring-controller` to ^21.0.1

```markdown

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31293?quickstart=1)

Fixes: #31200

1. Start with an installation from before we introduced
keyringsMetadata, proceed past onboarding so that you have a vault setup
(e.g. v12.12.0)
2. Upgrade to this branch
3. Start the extension (without logging in)
4. Leave the window open a while to give it time to initialize all
controllers
5. Reload the extension before unlocking
6. Try to unlock the wallet

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants