Skip to content

fix: bump @metamask/keyring-controller to ^19.2.2#31293

Merged
mikesposito merged 3 commits intoVersion-v12.14.2from
mikesposito/patch-keyring-controller
Mar 25, 2025
Merged

fix: bump @metamask/keyring-controller to ^19.2.2#31293
mikesposito merged 3 commits intoVersion-v12.14.2from
mikesposito/patch-keyring-controller

Conversation

@mikesposito
Copy link
Copy Markdown
Member

@mikesposito mikesposito commented Mar 25, 2025 •
edited
Loading

Description

Bumping @metamask/keyring-controller to 19.2.2

## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](https://github.com/MetaMask/core/pull/5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](https://github.com/MetaMask/core/pull/5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](https://github.com/MetaMask/core/pull/5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](https://github.com/MetaMask/core/pull/5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](https://github.com/MetaMask/core/pull/5356)), ([#5366](https://github.com/MetaMask/core/pull/5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](https://github.com/MetaMask/core/pull/5353))

Open in GitHub Codespaces

Related issues

Related: #31200

Manual testing steps

  1. Start with an installation from before we introduced keyringsMetadata, proceed past onboarding so that you have a vault setup (e.g. v12.12.0)
  2. Upgrade to this branch
  3. Start the extension (without logging in)
  4. Leave the window open a while to give it time to initialize all controllers
  5. Reload the extension before unlocking
  6. Try to unlock the wallet

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 25, 2025 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/keyring-controller@19.2.1 ➜ 19.2.2 None 0 569 kB gudahtt

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 25, 2025 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/keyring-controller@19.2.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@mikesposito
Copy link
Copy Markdown
Member Author

mikesposito commented Mar 25, 2025 

@SocketSecurity ignore npm/@metamask/keyring-controller@19.2.2

Published by @Gudahtt

@mikesposito mikesposito marked this pull request as ready for review March 25, 2025 16:53
@mikesposito
Copy link
Copy Markdown
Member Author

mikesposito commented Mar 25, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 25, 2025

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested review from a team as code owners March 25, 2025 17:12
Gudahtt
Gudahtt approved these changes Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito merged commit d0e903d into Version-v12.14.2 Mar 25, 2025
70 checks passed
@mikesposito mikesposito deleted the mikesposito/patch-keyring-controller branch March 25, 2025 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 25, 2025

Builds ready [7bd3c30]
Page Load Metrics (2099 ± 397 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint141043161991672323
domContentLoaded135432921774460221
load141450802099826397
domInteractive25177563718
backgroundConnect291485316359172
firstReactRender20234795727
getState1593514419895
initialActions01000
loadScripts97120961258260125
setupStore9312707938
uiStartup16611001633141866896

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikesposito @metamaskbot @Gudahtt