Skip to content

fix: bump @metamask/keyring-controller to ^21.0.1#31274

Merged
mikesposito merged 3 commits intomainfrom
mikesposito/bumps/keyring-controller
Mar 25, 2025
Merged

fix: bump @metamask/keyring-controller to ^21.0.1#31274
mikesposito merged 3 commits intomainfrom
mikesposito/bumps/keyring-controller

Conversation

@mikesposito
Copy link
Copy Markdown
Member

@mikesposito mikesposito commented Mar 25, 2025

Description

Bumping @metamask/keyring-controller to ^21.0.1

## [21.0.1]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](https://github.com/MetaMask/core/pull/5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](https://github.com/MetaMask/core/pull/5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](https://github.com/MetaMask/core/pull/5535))

Open in GitHub Codespaces

Related issues

Fixes: #31200

Manual testing steps

  1. Start with an installation from before we introduced keyringsMetadata, proceed past onboarding so that you have a vault setup (e.g. v12.12.0)
  2. Upgrade to this branch
  3. Start the extension (without logging in)
  4. Leave the window open a while to give it time to initialize all controllers
  5. Reload the extension before unlocking
  6. Try to unlock the wallet

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito changed the title chore: bump @metamask/keyring-controller to ^21.0.0 fix: bump @metamask/keyring-controller to ^21.0.0 Mar 25, 2025
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 25, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/keyring-controller@21.0.021.0.1 None 0 617 kB metamaskbot

View full report↗︎

@mikesposito mikesposito changed the title fix: bump @metamask/keyring-controller to ^21.0.0 fix: bump @metamask/keyring-controller to ^21.0.1 Mar 25, 2025
@mikesposito mikesposito marked this pull request as ready for review March 25, 2025 16:58
Gudahtt
Gudahtt previously approved these changes Mar 25, 2025
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Mar 25, 2025

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

No policy changes

@mikesposito mikesposito enabled auto-merge March 25, 2025 17:29
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [46db44b]
Page Load Metrics (2894 ± 1050 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint53811966267522551083
domContentLoaded163511737259221831048
load178211976289421861050
domInteractive27371617335
backgroundConnect981156332230111
firstReactRender40129822713
getState373081257436
initialActions01000
loadScripts1165995019061887906
setupStore19214735125
uiStartup257012923464125931245
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 255 Bytes (0.00%)

@mikesposito mikesposito requested a review from a team March 25, 2025 18:13
@mikesposito mikesposito added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 4d3ddf4 Mar 25, 2025
109 checks passed
@mikesposito mikesposito deleted the mikesposito/bumps/keyring-controller branch March 25, 2025 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.16.0 Issue or pull request that will be included in release 12.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sentry] Error: KeyringController - keyring metadata length mismatch

4 participants