Update babel-eslint to the latest version 🚀#5356
Closed
greenkeeper[bot] wants to merge 1 commit intodevelopfrom
Closed
Update babel-eslint to the latest version 🚀#5356greenkeeper[bot] wants to merge 1 commit intodevelopfrom
greenkeeper[bot] wants to merge 1 commit intodevelopfrom
Conversation
Collaborator
Contributor
Author
Update to this version instead 🚀 Release Notes for v10.0.1v10.0.1
The |
mikesposito
added a commit
that referenced
this pull request
Mar 25, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bumping `@metamask/keyring-controller` to 19.2.2 ```markdown ## [19.2.2] ### Fixed - Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535)) - Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535)) - Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535)) ## [19.2.1] ### Changed - Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366)) - Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366)) ### Fixed - Ensure authorization contract address is provided ([#5353](MetaMask/core#5353)) ``` [](https://codespaces.new/MetaMask/metamask-extension/pull/31293?quickstart=1) ## **Related issues** Related: #31200 ## **Manual testing steps** 1. Start with an installation from before we introduced keyringsMetadata, proceed past onboarding so that you have a vault setup (e.g. v12.12.0) 2. Upgrade to this branch 3. Start the extension (without logging in) 4. Leave the window open a while to give it time to initialize all controllers 5. Reload the extension before unlocking 6. Try to unlock the wallet ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The devDependency babel-eslint was updated from
8.2.6to10.0.0.This version is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
Release Notes for v10.0.0
v10.0.0
Small breaking change: add a peerDependency starting from the ESLint version that added a parser feature that we were monkeypatching before (and drop that code). If already using ESLint 5 shouldn't be any different.
TypeAlias: #584Commits
The new version differs by 20 commits ahead by 20, behind by 2.
8f78e2810.0.0717fba7test value should be switched020d012Treat type alias declarationlike function declaration (#584)b400cb1Test eslint5, update peerDep (#690)c333bd6Drop old monkeypatching behavior (#689)6aa8b6f9.0.0c7ee9aeBump to babel@7.0.0 🎉 (#676)3ece549Docs: Make the default parserOptions more explicit (#673)0b36951Add logical assignment plugin (#674)5856ff5Bump some devDeps45938d9build(deps): upgrade @babel/* to 7.0.0-rc.2 (#668)bc978759.0.0-beta.374c5d62update lock6a45632chore - fixing eslint-scope to a safe version; resolves #656. (#657)e0119e09.0.0-beta.2There are 20 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴