Skip to content

Update babel-eslint to the latest version 🚀#5356

Closed
greenkeeper[bot] wants to merge 1 commit intodevelopfrom
greenkeeper/babel-eslint-10.0.0
Closed

Update babel-eslint to the latest version 🚀#5356
greenkeeper[bot] wants to merge 1 commit intodevelopfrom
greenkeeper/babel-eslint-10.0.0

Conversation

@greenkeeper
Copy link
Copy Markdown
Contributor

@greenkeeper greenkeeper bot commented Sep 25, 2018

The devDependency babel-eslint was updated from 8.2.6 to 10.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Release Notes for v10.0.0

v10.0.0

Small breaking change: add a peerDependency starting from the ESLint version that added a parser feature that we were monkeypatching before (and drop that code). If already using ESLint 5 shouldn't be any different.

  • Bugfix for TypeAlias: #584
/* @flow */
type Node<T> = { head: T; tail: Node<T> }

// or

type File = {chunks: Array<Chunk>}
type Chunk = {file: File}

  • Update to test against ESLint 5, add a peerDependency: #689
  • Drop monkeypatching behavior: #690
Commits

The new version differs by 20 commits ahead by 20, behind by 2.

  • 8f78e28 10.0.0
  • 717fba7 test value should be switched
  • 020d012 Treat type alias declarationlike function declaration (#584)
  • b400cb1 Test eslint5, update peerDep (#690)
  • c333bd6 Drop old monkeypatching behavior (#689)
  • 6aa8b6f 9.0.0
  • c7ee9ae Bump to babel@7.0.0 🎉 (#676)
  • 3ece549 Docs: Make the default parserOptions more explicit (#673)
  • 0b36951 Add logical assignment plugin (#674)
  • 5856ff5 Bump some devDeps
  • 45938d9 build(deps): upgrade @babel/* to 7.0.0-rc.2 (#668)
  • bc97875 9.0.0-beta.3
  • 74c5d62 update lock
  • 6a45632 chore - fixing eslint-scope to a safe version; resolves #656. (#657)
  • e0119e0 9.0.0-beta.2

There are 20 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [e36d5c1]: mascara, chrome, firefox, edge, opera

greenkeeper bot added a commit that referenced this pull request Sep 27, 2018
@greenkeeper
Copy link
Copy Markdown
Contributor Author

greenkeeper bot commented Sep 27, 2018

  • The devDependency babel-eslint was updated from 8.2.6 to 10.0.1.

Update to this version instead 🚀

Release Notes for v10.0.1

v10.0.1

The TypeAlias "conversion" to a function has issues. Sounds like we need to rethink the change, most likely we can just actually change the scoping rather than hardcode an AST change.

Commits

The new version differs by 2 commits.

See the full diff

@kumavis kumavis closed this Oct 10, 2018
@whymarrh whymarrh deleted the greenkeeper/babel-eslint-10.0.0 branch October 10, 2018 14:22
mikesposito added a commit that referenced this pull request Mar 25, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Bumping `@metamask/keyring-controller` to 19.2.2

```markdown
## [19.2.2]

### Fixed

- Fixed duplication of unsupported keyrings ([#5535](MetaMask/core#5535))
- Enforce keyrings metadata alignment when unlocking existing vault ([#5535](MetaMask/core#5535))
- Fixed frozen object mutation attempt when updating metadata ([#5535](MetaMask/core#5535))

## [19.2.1]

### Changed

- Bump `@metamask/keyring-api"` from `^17.0.0` to `^17.2.0` ([#5366](MetaMask/core#5366))
- Bump `@metamask/keyring-internal-api` from `^4.0.1` to `^4.0.3` ([#5356](MetaMask/core#5356)), ([#5366](MetaMask/core#5366))

### Fixed

- Ensure authorization contract address is provided ([#5353](MetaMask/core#5353))
```

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31293?quickstart=1)

## **Related issues**

Related: #31200

## **Manual testing steps**

1. Start with an installation from before we introduced
keyringsMetadata, proceed past onboarding so that you have a vault setup
(e.g. v12.12.0)
2. Upgrade to this branch
3. Start the extension (without logging in)
4. Leave the window open a while to give it time to initialize all
controllers
5. Reload the extension before unlocking
6. Try to unlock the wallet

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants