Skip to content

reduce: improve remove unref instr pass#2945

Merged
paulthomson merged 3 commits intoKhronosGroup:masterfrom
paulthomson:remove_unreferenced_improve
Oct 8, 2019
Merged

reduce: improve remove unref instr pass#2945
paulthomson merged 3 commits intoKhronosGroup:masterfrom
paulthomson:remove_unreferenced_improve

Conversation

@paulthomson
Copy link
Copy Markdown
Contributor

@paulthomson paulthomson commented Oct 4, 2019

  • Remove Impl struct in Reducer; we can re-add it later (in a cleaner fashion) if we need to.
  • Add cleanup passes in Reducer; needed so that removal of constants can be disabled during the main passes, and then enabled during cleanup passes, otherwise some main passes can perform worse due to lack of available constants.
  • Delete passes: remove op name, remove relaxed precision. And delete associated tests.
  • Add more tests for remove unreferenced instructions.
  • Always return and write the output file, even if there was a reduction failure.
  • Only exit with 0 if the reduction completed or we hit the reduction step limit.

@paulthomson paulthomson requested a review from afd October 4, 2019 14:34
Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good - one question in the comments.

@afd afd self-requested a review October 8, 2019 10:24
Copy link
Copy Markdown
Contributor

@afd afd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, so long as bots pass.

@paulthomson paulthomson merged commit 2f6a87f into KhronosGroup:master Oct 8, 2019
@paulthomson paulthomson deleted the remove_unreferenced_improve branch October 8, 2019 12:02
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
Roll third_party/glslang/ 7bc0473..4b97a11 (5 commits)

KhronosGroup/glslang@7bc0473...4b97a11

$ git log 7bc0473..4b97a11 --date=short --no-merges --format='%ad %ae %s'
2019-10-06 dj2 single line
2019-10-03 dj2 Update appveyor and travis files
2019-10-03 dj2 Move install directory for SPIRV/ folder.
2019-09-29 cepheus HLSL: Fix KhronosGroup#1912: add attribute syntax for nonreadable/nonwritable
2019-09-27 cepheus HLSL: Fix KhronosGroup#1912: add attribute syntax for overriding image formats.

Roll third_party/googletest/ dc1ca9ae4..cd17fa2ab (8 commits)

google/googletest@dc1ca9a...cd17fa2

$ git log dc1ca9ae4..cd17fa2ab --date=short --no-merges --format='%ad %ae %s'
2019-10-05 soap Add documentation for pkg-config in cross-compilation settings
2019-10-05 soap Revert "Use pcfiledir for prefix in pkgconfig file"
2019-10-03 misterg Googletest export
2019-10-03 absl-team Googletest export
2019-10-02 absl-team Googletest export
2019-09-29 misterg Googletest export
2019-10-01 ant35rookie Fix typo in documents
2019-08-16 pbarker Add many missing override keywords

Roll third_party/re2/ 5bd613749..266119da0 (2 commits)

google/re2@5bd6137...266119d

$ git log 5bd613749..266119da0 --date=short --no-merges --format='%ad %ae %s'
2019-10-09 junyer Tidy up the ersatz benchmark library.
2019-10-07 junyer Move pod_array.h and sparse_{array,set}.h from util/ to re2/.

Roll third_party/spirv-headers/ 842ec90..b252a50 (1 commit)

KhronosGroup/SPIRV-Headers@842ec90...b252a50

$ git log 842ec90..b252a50 --date=short --no-merges --format='%ad %ae %s'
2019-09-24 lukasz.gotszald add cmake option SPIRV_HEADERS_SKIP_INSTALL

Roll third_party/spirv-tools/ 9eb1c9a..df15a4a (15 commits)

KhronosGroup/SPIRV-Tools@9eb1c9a...df15a4a

$ git log 9eb1c9a..df15a4a --date=short --no-merges --format='%ad %ae %s'
2019-10-09 cwallez CMake: Add support for building with emscripten (KhronosGroup#2948)
2019-10-09 stevenperron Update CHANGES
2019-10-08 stevenperron Link cfg and dominator analysis in the context (KhronosGroup#2946)
2019-10-08 afdx spirv-fuzz: add transformation and pass to construct composites (KhronosGroup#2941)
2019-10-08 paulthomson reduce: improve remove unref instr pass (KhronosGroup#2945)
2019-10-08 afdx spirv-fuzz: add disabled test to document known issue (KhronosGroup#2942)
2019-10-08 afdx spirv-fuzz: Add fuzzer pass to change selection controls (KhronosGroup#2944)
2019-10-07 jeremy-lunarg Enable OpTypeCooperativeMatrix specialization (KhronosGroup#2927)
2019-10-04 stevenperron Handle OpKill better (KhronosGroup#2933)
2019-10-04 greg Generate null pointer by converting uint64 zero to pointer. (KhronosGroup#2935)
2019-10-03 afdx spirv-fuzz: option to convert shader into a form that renders red (KhronosGroup#2934)
2019-10-03 32110296+AaronHaganAMD Add SPV_KHR_shader_clock validation (KhronosGroup#2879)
2019-10-03 paulthomson reduce/fuzz: improve command line args (KhronosGroup#2932)
2019-10-02 alanbaker Validate physical storage buffer restrictions (KhronosGroup#2930)
2019-10-01 paulthomson fuzz: add shrinker-temp-file-prefix (KhronosGroup#2928)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants