Skip to content

Remove #ifdef EFFCEE guards in tests #1912

@dneto0

Description

@dneto0

Those guards were only added because we could still run most of our googletest tests but not the effcee tests. That's because effcee (and its re2) could not build with VS2013, but googletest could build with VS2013.

But recently googletest stopped building under VS2013. So there's no point in having the #ifdefs which just broke things.
(See #1910 and related break in google/shaderc#477 )

This change should:

  • remove the Effcee #ifdef guards
  • update the README and bots to say we now required Effcee in the source tree
  • be accompanied by an email to the developer mailing list about the change.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions