fuzz: add shrinker-temp-file-prefix#2928
Conversation
And relax naming requirements of input and output files.
| @@ -215,23 +219,11 @@ FuzzStatus ParseFlags(int argc, const char** argv, std::string* in_binary_file, | |||
| return {FuzzActions::STOP, 1}; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
By removing the following, it looks like we make it possible to pass an input file that does not end in .spv. Am I correct, and if so is it intentional? The help for the tool says that the input file must be a .spv file.
There was a problem hiding this comment.
Yes it is intentional. I'd like to pass a file with extension ".spv_orig". I will update the help text.
afd
left a comment
There was a problem hiding this comment.
Happy for you to decide on my one comment as you see fit.
| @@ -75,9 +75,8 @@ USAGE: %s [options] <input.spv> -o <output.spv> | |||
| USAGE: %s [options] <input.spv> -o <output.spv> \ | |||
| --shrink=<input.transformations> -- <interestingness_function> <args...> | |||
|
|
|||
There was a problem hiding this comment.
I think it would be clearer to say:
The SPIR-V binary is read from <input[.ext]>, e.g. 'shader.spv', or 'shader'. If <input.facts> ('shader.facts' in both example cases) is also present, facts about the SPIR-V binary are read from this file.
But perhaps this is a bit too nit-picky. What do you think?
There was a problem hiding this comment.
I personally find it clearer to use input.spv throughout as it gives me a reminder of what the input is. I think the use of the .spv extension should appear to be almost required, but we should support other extensions for convenience.
Roll third_party/glslang/ 7bc0473..4b97a11 (5 commits) KhronosGroup/glslang@7bc0473...4b97a11 $ git log 7bc0473..4b97a11 --date=short --no-merges --format='%ad %ae %s' 2019-10-06 dj2 single line 2019-10-03 dj2 Update appveyor and travis files 2019-10-03 dj2 Move install directory for SPIRV/ folder. 2019-09-29 cepheus HLSL: Fix KhronosGroup#1912: add attribute syntax for nonreadable/nonwritable 2019-09-27 cepheus HLSL: Fix KhronosGroup#1912: add attribute syntax for overriding image formats. Roll third_party/googletest/ dc1ca9ae4..cd17fa2ab (8 commits) google/googletest@dc1ca9a...cd17fa2 $ git log dc1ca9ae4..cd17fa2ab --date=short --no-merges --format='%ad %ae %s' 2019-10-05 soap Add documentation for pkg-config in cross-compilation settings 2019-10-05 soap Revert "Use pcfiledir for prefix in pkgconfig file" 2019-10-03 misterg Googletest export 2019-10-03 absl-team Googletest export 2019-10-02 absl-team Googletest export 2019-09-29 misterg Googletest export 2019-10-01 ant35rookie Fix typo in documents 2019-08-16 pbarker Add many missing override keywords Roll third_party/re2/ 5bd613749..266119da0 (2 commits) google/re2@5bd6137...266119d $ git log 5bd613749..266119da0 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 junyer Tidy up the ersatz benchmark library. 2019-10-07 junyer Move pod_array.h and sparse_{array,set}.h from util/ to re2/. Roll third_party/spirv-headers/ 842ec90..b252a50 (1 commit) KhronosGroup/SPIRV-Headers@842ec90...b252a50 $ git log 842ec90..b252a50 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 lukasz.gotszald add cmake option SPIRV_HEADERS_SKIP_INSTALL Roll third_party/spirv-tools/ 9eb1c9a..df15a4a (15 commits) KhronosGroup/SPIRV-Tools@9eb1c9a...df15a4a $ git log 9eb1c9a..df15a4a --date=short --no-merges --format='%ad %ae %s' 2019-10-09 cwallez CMake: Add support for building with emscripten (KhronosGroup#2948) 2019-10-09 stevenperron Update CHANGES 2019-10-08 stevenperron Link cfg and dominator analysis in the context (KhronosGroup#2946) 2019-10-08 afdx spirv-fuzz: add transformation and pass to construct composites (KhronosGroup#2941) 2019-10-08 paulthomson reduce: improve remove unref instr pass (KhronosGroup#2945) 2019-10-08 afdx spirv-fuzz: add disabled test to document known issue (KhronosGroup#2942) 2019-10-08 afdx spirv-fuzz: Add fuzzer pass to change selection controls (KhronosGroup#2944) 2019-10-07 jeremy-lunarg Enable OpTypeCooperativeMatrix specialization (KhronosGroup#2927) 2019-10-04 stevenperron Handle OpKill better (KhronosGroup#2933) 2019-10-04 greg Generate null pointer by converting uint64 zero to pointer. (KhronosGroup#2935) 2019-10-03 afdx spirv-fuzz: option to convert shader into a form that renders red (KhronosGroup#2934) 2019-10-03 32110296+AaronHaganAMD Add SPV_KHR_shader_clock validation (KhronosGroup#2879) 2019-10-03 paulthomson reduce/fuzz: improve command line args (KhronosGroup#2932) 2019-10-02 alanbaker Validate physical storage buffer restrictions (KhronosGroup#2930) 2019-10-01 paulthomson fuzz: add shrinker-temp-file-prefix (KhronosGroup#2928) Created with: roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
And relax naming requirements of input and output files.