Skip to content

Add SPV_KHR_shader_clock validation#2879

Merged
alan-baker merged 1 commit intoKhronosGroup:masterfrom
AaronHaganAMD:master
Oct 3, 2019
Merged

Add SPV_KHR_shader_clock validation#2879
alan-baker merged 1 commit intoKhronosGroup:masterfrom
AaronHaganAMD:master

Conversation

@AaronHaganAMD
Copy link
Copy Markdown
Contributor

Add checks for SPV_KHR_shader_clock

  1. Check that the Result Type must be a 64-bit unsigned integer type or a vector of two-components of 32-bit unsigned integer.

  2. Check for a valid execution scope.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 18, 2019

CLA assistant check
All committers have signed the CLA.

@dneto0 dneto0 requested a review from alan-baker September 18, 2019 18:47
Copy link
Copy Markdown
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests too.

@AaronHaganAMD
Copy link
Copy Markdown
Contributor Author

Added tests..

@alan-baker
Copy link
Copy Markdown
Contributor

When you fix the formatting issues, could you also rebase onto master?

@alan-baker alan-baker merged commit bc37fd5 into KhronosGroup:master Oct 3, 2019
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
Roll third_party/glslang/ 7bc0473..4b97a11 (5 commits)

KhronosGroup/glslang@7bc0473...4b97a11

$ git log 7bc0473..4b97a11 --date=short --no-merges --format='%ad %ae %s'
2019-10-06 dj2 single line
2019-10-03 dj2 Update appveyor and travis files
2019-10-03 dj2 Move install directory for SPIRV/ folder.
2019-09-29 cepheus HLSL: Fix KhronosGroup#1912: add attribute syntax for nonreadable/nonwritable
2019-09-27 cepheus HLSL: Fix KhronosGroup#1912: add attribute syntax for overriding image formats.

Roll third_party/googletest/ dc1ca9ae4..cd17fa2ab (8 commits)

google/googletest@dc1ca9a...cd17fa2

$ git log dc1ca9ae4..cd17fa2ab --date=short --no-merges --format='%ad %ae %s'
2019-10-05 soap Add documentation for pkg-config in cross-compilation settings
2019-10-05 soap Revert "Use pcfiledir for prefix in pkgconfig file"
2019-10-03 misterg Googletest export
2019-10-03 absl-team Googletest export
2019-10-02 absl-team Googletest export
2019-09-29 misterg Googletest export
2019-10-01 ant35rookie Fix typo in documents
2019-08-16 pbarker Add many missing override keywords

Roll third_party/re2/ 5bd613749..266119da0 (2 commits)

google/re2@5bd6137...266119d

$ git log 5bd613749..266119da0 --date=short --no-merges --format='%ad %ae %s'
2019-10-09 junyer Tidy up the ersatz benchmark library.
2019-10-07 junyer Move pod_array.h and sparse_{array,set}.h from util/ to re2/.

Roll third_party/spirv-headers/ 842ec90..b252a50 (1 commit)

KhronosGroup/SPIRV-Headers@842ec90...b252a50

$ git log 842ec90..b252a50 --date=short --no-merges --format='%ad %ae %s'
2019-09-24 lukasz.gotszald add cmake option SPIRV_HEADERS_SKIP_INSTALL

Roll third_party/spirv-tools/ 9eb1c9a..df15a4a (15 commits)

KhronosGroup/SPIRV-Tools@9eb1c9a...df15a4a

$ git log 9eb1c9a..df15a4a --date=short --no-merges --format='%ad %ae %s'
2019-10-09 cwallez CMake: Add support for building with emscripten (KhronosGroup#2948)
2019-10-09 stevenperron Update CHANGES
2019-10-08 stevenperron Link cfg and dominator analysis in the context (KhronosGroup#2946)
2019-10-08 afdx spirv-fuzz: add transformation and pass to construct composites (KhronosGroup#2941)
2019-10-08 paulthomson reduce: improve remove unref instr pass (KhronosGroup#2945)
2019-10-08 afdx spirv-fuzz: add disabled test to document known issue (KhronosGroup#2942)
2019-10-08 afdx spirv-fuzz: Add fuzzer pass to change selection controls (KhronosGroup#2944)
2019-10-07 jeremy-lunarg Enable OpTypeCooperativeMatrix specialization (KhronosGroup#2927)
2019-10-04 stevenperron Handle OpKill better (KhronosGroup#2933)
2019-10-04 greg Generate null pointer by converting uint64 zero to pointer. (KhronosGroup#2935)
2019-10-03 afdx spirv-fuzz: option to convert shader into a form that renders red (KhronosGroup#2934)
2019-10-03 32110296+AaronHaganAMD Add SPV_KHR_shader_clock validation (KhronosGroup#2879)
2019-10-03 paulthomson reduce/fuzz: improve command line args (KhronosGroup#2932)
2019-10-02 alanbaker Validate physical storage buffer restrictions (KhronosGroup#2930)
2019-10-01 paulthomson fuzz: add shrinker-temp-file-prefix (KhronosGroup#2928)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants