Create a better solution for define multi line fields by Freeman6475 · Pull Request #9456 · JabRef/jabref

Freeman6475 · 2022-12-15T18:45:42Z

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

ThiloteE · 2022-12-16T08:05:44Z

To ease organizational workflows I have linked the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

close

closes

closed

fix

fixes

fixed

resolve

resolves

resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

Siedlerchr · 2022-12-16T21:23:23Z

As we talked about this, I summarize this here again for the others:

Next steps:
create a checkbox column for the multiline check

see for an example how it is implemented

jabref/src/main/java/org/jabref/gui/slr/ManageStudyDefinitionView.java

Line 219 in c02d75b

    
           databaseEnabledColumn.setCellFactory(CheckBoxTableCell.forTableColumn(databaseEnabledColumn));

* upstream/main: (120 commits) Enable groups drag'n'drop to new library (JabRef#9460) Update MacOS jabrefHost.py to find local installs (JabRef#9487) Fix remember last open valid library with empty new one (JabRef#9489) Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486) Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485) New Crowdin updates (JabRef#9483) Add log for ignored excepton (JabRef#9302) Select Library to import into (JabRef#9402) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478) Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479) Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480) Bibtex month not deprecated (JabRef#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release Also trigger on branch arm64mac-release ...

todo map property of field

* upstream/main: Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (JabRef#9493)

make properties read write

Siedlerchr · 2022-12-24T16:20:18Z

TODO: How to adjust the serializer/parser to recognize the field properties. Store it in prefs as is?

* upstream/main: Bump classgraph from 4.8.152 to 4.8.153 (JabRef#9502) Bump slf4j-api from 2.0.5 to 2.0.6 (JabRef#9501) Bump org.beryx.jlink from 2.25.0 to 2.26.0 (JabRef#9500) Bump lucene-queries from 9.4.1 to 9.4.2 (JabRef#9499) Add double click on preview style to add/remove from the selected list (JabRef#9498) Fix no context menu with sorting on all entries group (JabRef#9497)

Siedlerchr · 2022-12-26T17:38:37Z

NON_WRAPPABLE_FIELDS:
FieldContentFormatterPreferences extract to BibEntryPreferences
Custom Entry types: move to preferences

Call with Carl: Still use the existing hack

* upstream/main: Update to JDK 19 (JabRef#9421)

store in prefs

fix checkstyle

Siedlerchr · 2022-12-27T21:36:18Z

I will create a follow up PR for moving the CustomEntryType to the preference tab

revert save database action formatting

calixtus · 2022-12-29T07:28:29Z

-                                             minWidth="150.0" prefWidth="-1.0" text="%Field"/>
+                                             minWidth="120.0" prefWidth="-1.0" text="%Field"/>
                                <TableColumn fx:id="fieldTypeColumn"
-                                             minWidth="100.0" prefWidth="100.0" text="%Field type"/>
+                                             minWidth="130.0" prefWidth="150.0" text="%Field type"/>
                                <TableColumn fx:id="fieldTypeActionColumn"
                                             maxWidth="40.0" minWidth="40.0" resizable="false"/>
+                                <TableColumn fx:id="fieldTypeMultilineColumn" text="%Multiline"
+                                             prefWidth="60.0" minWidth="50.0" resizable="true"/>


Not so happy with the arrangement of the checkboxes and buttons.
The remove button should be the most right aligned button. the checkbox-column is too wide. Maybe rotate the label of the TableColumn 90 degrees to display it vertically? (https://stackoverflow.com/questions/27666087/vertical-column-text-in-tableview)

I found a different solution for vertical alignment https://stackoverflow.com/a/74863464
In general this looks good, however, there seems to be some padding or margin missing.. Unfortunately I could not get scenic view to run on mac :(

I will take a look

can you commit your changes?

Pushed to the wrong repo^^

Fixed it now

I'll look into it tomorrow. There are some UI tweaks I'm thinking of. 🤔

set text manually

* upstream/main: Fix spaces Add missing dots Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2 try to repack deb file (JabRef#9506) Fix date parser for year/month (JabRef#9507) # Conflicts: # CHANGELOG.md

calixtus · 2023-01-01T22:39:03Z

calixtus · 2023-01-01T23:24:52Z


 ### Added

+


Duplicate changelog entry

* upstream/main: (29 commits) Use Set instead of List for custom journal abbreviations (JabRef#9515) Delete snap.yml (JabRef#9526) New Crowdin updates (JabRef#9523) Fix not on fx thread error when downloading file (JabRef#9522) Fix downloading in case of circular redirect (JabRef#9519) Typo: sucess -> success (JabRef#9520) New Crowdin updates (JabRef#9517) Add CHANGELOG.md entry for 9472 Fix journal abbbrev checker for curly braces (JabRef#9504) Remove journal_abbreviations_ieee_strings.csv from journal lists (JabRef#9511) Bump mockito-core from 4.10.0 to 4.11.0 (JabRef#9513) Bump lucene-core from 9.4.1 to 9.4.2 (JabRef#9512) Bump checkstyle from 10.5.0 to 10.6.0 (JabRef#9514) Create a better solution for define multi line fields (JabRef#9456) Check links once a month Really ignore CHANGELOG.md in link check Fix spaces Add missing dots Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2 try to repack deb file (JabRef#9506) ... # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java

* upstream/main: (244 commits) Use Set instead of List for custom journal abbreviations (JabRef#9515) Delete snap.yml (JabRef#9526) New Crowdin updates (JabRef#9523) Fix not on fx thread error when downloading file (JabRef#9522) Fix downloading in case of circular redirect (JabRef#9519) Typo: sucess -> success (JabRef#9520) New Crowdin updates (JabRef#9517) Add CHANGELOG.md entry for 9472 Fix journal abbbrev checker for curly braces (JabRef#9504) Remove journal_abbreviations_ieee_strings.csv from journal lists (JabRef#9511) Bump mockito-core from 4.10.0 to 4.11.0 (JabRef#9513) Bump lucene-core from 9.4.1 to 9.4.2 (JabRef#9512) Bump checkstyle from 10.5.0 to 10.6.0 (JabRef#9514) Create a better solution for define multi line fields (JabRef#9456) Check links once a month Really ignore CHANGELOG.md in link check Fix spaces Add missing dots Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2 try to repack deb file (JabRef#9506) ...

multi line field

a0ea6c3

ThiloteE added the component: entry-editor label Dec 16, 2022

Siedlerchr added the status: changes-required Pull requests that are not yet complete label Dec 21, 2022

Siedlerchr added 5 commits December 22, 2022 13:38

prepare checkbox table cell

393ee4f

todo map property of field

Merge remote-tracking branch 'upstream/main' into fix-issue-JabRef#6448

129b4f6

* upstream/main: Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (JabRef#9493)

prepare multiline fields

89490cb

add multiline text to field properties as well

a1a62cf

make properties read write

Siedlerchr added 4 commits December 24, 2022 17:20

refactor

e1fb9d3

checkstyle and remove obsolete method

ab0dfd8

checkstyle

6d06c01

Siedlerchr added 4 commits December 27, 2022 14:40

collect multiline

95c28b3

Merge remote-tracking branch 'upstream/main' into fix-issue-JabRef#6448

176cd2d

* upstream/main: Update to JDK 19 (JabRef#9421)

add predicate for checking non wrappable fields

d3684b3

use set of fields

b1e483f

store in prefs

Siedlerchr force-pushed the fix-issue-#6448 branch from 9a13b45 to b1e483f Compare December 27, 2022 21:16

fix gui layout

128386d

fix checkstyle

Siedlerchr marked this pull request as ready for review December 27, 2022 21:36

Siedlerchr added 4 commits December 27, 2022 22:44

add l10n

7c9d347

revert save database action formatting

fix checkstyle

84050ae

fix tab chars

40d0bc6

fix tab

8ac3dd5

Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes-required Pull requests that are not yet complete labels Dec 28, 2022

add changelog

a11c30c

calixtus reviewed Dec 29, 2022

View reviewed changes

Siedlerchr added 5 commits December 29, 2022 11:52

add rotated text

3134cd4

fix display of vertical label

fc11417

set text manually

group apparently has no css class

bafbe29

fix exception

b95cb87

calixtus and others added 2 commits January 1, 2023 23:39

Changed ui

9da72fb

fix l10n

af5ca92

Siedlerchr previously approved these changes Jan 1, 2023

View reviewed changes

calixtus reviewed Jan 1, 2023

View reviewed changes

Comment thread CHANGELOG.md

### Added

calixtus Jan 1, 2023

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate changelog entry

adjust changelog

59eb0b5

Siedlerchr dismissed their stale review via 59eb0b5 January 2, 2023 08:23

Siedlerchr merged commit fd37cd3 into JabRef:main Jan 2, 2023

Siedlerchr mentioned this pull request Jan 2, 2023

Update description and screenshot for multiline fields in custom entry types dialog JabRef/user-documentation#433

Open

Uh oh!

Conversation

Freeman6475 commented Dec 15, 2022 • edited by Siedlerchr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ThiloteE commented Dec 16, 2022

Linking a pull request to an issue using a keyword

Uh oh!

Siedlerchr commented Dec 16, 2022

Uh oh!

Siedlerchr commented Dec 24, 2022

Uh oh!

Siedlerchr commented Dec 26, 2022

Uh oh!

Siedlerchr commented Dec 27, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

calixtus commented Jan 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Freeman6475 commented Dec 15, 2022 •

edited by Siedlerchr

Loading

calixtus commented Jan 1, 2023 •

edited

Loading