Skip to content

Delete snap.yml#9526

Merged
Siedlerchr merged 1 commit into
mainfrom
remove-snap-workflow
Jan 4, 2023
Merged

Delete snap.yml#9526
Siedlerchr merged 1 commit into
mainfrom
remove-snap-workflow

Conversation

@koppor

@koppor koppor commented Jan 4, 2023

Copy link
Copy Markdown
Member

Snap builds are triggered by snapcraft:

grafik

See also https://snapcraft.io/docs/build-from-github

Thus, we do not need the action anymore.

I also removed it in our release howto: https://github.com/JabRef/jabref/wiki/Releasing-a-new-Version/_compare/7bc617153b13e1302bbc378690ef3cc8ff797a3b...60c0e1b2ce8692b2956f6eab45627fc2a3911a4e

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added dev: build-system platform: snap When JabRef is run as a snap on linux labels Jan 4, 2023
@Siedlerchr Siedlerchr merged commit 9a8684e into main Jan 4, 2023
@Siedlerchr Siedlerchr deleted the remove-snap-workflow branch January 4, 2023 13:05
Siedlerchr added a commit to NiD133/jabref that referenced this pull request Jan 4, 2023
* upstream/main: (29 commits)
  Use Set instead of List for custom journal abbreviations (JabRef#9515)
  Delete snap.yml (JabRef#9526)
  New Crowdin updates (JabRef#9523)
  Fix not on fx thread error when downloading file (JabRef#9522)
  Fix downloading in case of circular redirect (JabRef#9519)
  Typo: sucess -> success (JabRef#9520)
  New Crowdin updates (JabRef#9517)
  Add CHANGELOG.md entry for 9472
  Fix journal abbbrev checker for curly braces (JabRef#9504)
  Remove journal_abbreviations_ieee_strings.csv from journal lists (JabRef#9511)
  Bump mockito-core from 4.10.0 to 4.11.0 (JabRef#9513)
  Bump lucene-core from 9.4.1 to 9.4.2 (JabRef#9512)
  Bump checkstyle from 10.5.0 to 10.6.0 (JabRef#9514)
  Create a better solution for define multi line fields (JabRef#9456)
  Check links once a month
  Really ignore CHANGELOG.md in link check
  Fix spaces
  Add missing dots
  Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2
  try to repack deb file (JabRef#9506)
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
Siedlerchr added a commit to JabRef/jabref-koppor that referenced this pull request Jan 5, 2023
* upstream/main: (244 commits)
  Use Set instead of List for custom journal abbreviations (JabRef#9515)
  Delete snap.yml (JabRef#9526)
  New Crowdin updates (JabRef#9523)
  Fix not on fx thread error when downloading file (JabRef#9522)
  Fix downloading in case of circular redirect (JabRef#9519)
  Typo: sucess -> success (JabRef#9520)
  New Crowdin updates (JabRef#9517)
  Add CHANGELOG.md entry for 9472
  Fix journal abbbrev checker for curly braces (JabRef#9504)
  Remove journal_abbreviations_ieee_strings.csv from journal lists (JabRef#9511)
  Bump mockito-core from 4.10.0 to 4.11.0 (JabRef#9513)
  Bump lucene-core from 9.4.1 to 9.4.2 (JabRef#9512)
  Bump checkstyle from 10.5.0 to 10.6.0 (JabRef#9514)
  Create a better solution for define multi line fields (JabRef#9456)
  Check links once a month
  Really ignore CHANGELOG.md in link check
  Fix spaces
  Add missing dots
  Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2
  try to repack deb file (JabRef#9506)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: build-system platform: snap When JabRef is run as a snap on linux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants