Skip to content

Add double click on preview style to add/remove from the selected list#9498

Merged
calixtus merged 3 commits into
JabRef:mainfrom
Oldgram:fix-for-issue-9490
Dec 25, 2022
Merged

Add double click on preview style to add/remove from the selected list#9498
calixtus merged 3 commits into
JabRef:mainfrom
Oldgram:fix-for-issue-9490

Conversation

@Oldgram

@Oldgram Oldgram commented Dec 25, 2022

Copy link
Copy Markdown
Contributor

Fixes: #9490

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Authored-by: Dylan Goffinet <goffindy@gmail.com>

See: [Double-click on preview style should add it to "Selected"](JabRef#9490)
viewModel.resetDefaultLayout();
}

public void mouseClickedAvailable(MouseEvent event) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both methods can be made private, but apart from hat lgtm

Siedlerchr
Siedlerchr previously approved these changes Dec 25, 2022
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 25, 2022
@Siedlerchr

Copy link
Copy Markdown
Member

Thanks for your contribution! Just a minor change but otherwise lgtm

@calixtus calixtus merged commit ed78e89 into JabRef:main Dec 25, 2022
Siedlerchr added a commit that referenced this pull request Dec 26, 2022
* upstream/main:
  Bump classgraph from 4.8.152 to 4.8.153 (#9502)
  Bump slf4j-api from 2.0.5 to 2.0.6 (#9501)
  Bump org.beryx.jlink from 2.25.0 to 2.26.0 (#9500)
  Bump lucene-queries from 9.4.1 to 9.4.2 (#9499)
  Add double click on preview style to add/remove from the selected list (#9498)
  Fix no context menu with sorting on all entries group (#9497)
  Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (#9493)
Siedlerchr added a commit that referenced this pull request Dec 27, 2022
* upstream/main:
  Bump classgraph from 4.8.152 to 4.8.153 (#9502)
  Bump slf4j-api from 2.0.5 to 2.0.6 (#9501)
  Bump org.beryx.jlink from 2.25.0 to 2.26.0 (#9500)
  Bump lucene-queries from 9.4.1 to 9.4.2 (#9499)
  Add double click on preview style to add/remove from the selected list (#9498)
  Fix no context menu with sorting on all entries group (#9497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double-click on preview style should add it to "Selected"

3 participants