Bibtex month not deprecated by svenjaeger · Pull Request #9404 · JabRef/jabref

svenjaeger · 2022-11-25T14:10:24Z

This is about #7757. With these changes, the month is not shown as deprecated in BibTeX mode any more, but I am not sure whether anything is shown in this tab at all, now.

This obviously depends on the line
deprecatedFields.retainAll(getOptionalFieldsAndAliases());
that seems to filter out everything now.

take changes from main project

koppor · 2022-12-17T20:20:58Z

BibTeX

Before the PR:

After the PR:

biblatex

Before the PR:

After the PR:

…ecated

- Add paramter "mode" to getSecondaryOptionalNotDeprecatedFields - More advanced tool tip - Make variable name in EntryConverter more readable Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

koppor · 2022-12-18T23:20:09Z

Thank you for the PR. me, @calixtus, and @Siedlerchr hat a long discussion about the meaning of "deprecated" in that context. We agreed that it is "only" about biblatex. When a user aims for using biblatex, they want to know which fields they should not use any more. We also thought that year is still used in biblatex. However, when "month" is also used, JabRef now adds "month" to the deprecated tab and shows a hint that date should be used.

svenjaeger · 2022-12-19T17:48:53Z

-            if (EntryConverter.FIELD_ALIASES_LTX_TO_TEX.containsKey(field.getField())) {
-                optionalFieldsAndAliases.add(EntryConverter.FIELD_ALIASES_LTX_TO_TEX.get(field.getField()));
+            if (EntryConverter.FIELD_ALIASES_BIBTEX_TO_BIBLATEX.containsKey(field.getField())) {
+                optionalFieldsAndAliases.add(field.getField());


What is the intention here? Now, for each optional field, we first add it to optionalFieldsAndAliases, and if it is contained in FIELD_ALIASES_BIBTEX_TO_BIBLATEX, then we add it a second time.

* upstream/main: (75 commits) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478) Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479) Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480) Bibtex month not deprecated (JabRef#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release Also trigger on branch arm64mac-release Only arm64 m+ Update deployment-arm64.yml add deployment with arm as well Revert "Test self hosted runner" remove self hosted from normal deployment fix unit test for slr Refine do not put under drive letter Update journal abbrev list (JabRef#9469) ... # Conflicts: # CHANGELOG.md

…-excepton * upstream/main: (184 commits) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478) Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479) Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480) Bibtex month not deprecated (JabRef#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release Also trigger on branch arm64mac-release Only arm64 m+ Update deployment-arm64.yml add deployment with arm as well Revert "Test self hosted runner" remove self hosted from normal deployment fix unit test for slr Refine do not put under drive letter Update journal abbrev list (JabRef#9469) ... # Conflicts: # src/main/java/org/jabref/logic/remote/server/RemoteListenerServer.java

…of_groups_to_new_library * upstream/main: (148 commits) Fix remember last open valid library with empty new one (JabRef#9489) Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486) Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485) New Crowdin updates (JabRef#9483) Add log for ignored excepton (JabRef#9302) Select Library to import into (JabRef#9402) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478) Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479) Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480) Bibtex month not deprecated (JabRef#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release Also trigger on branch arm64mac-release Only arm64 m+ Update deployment-arm64.yml ...

* upstream/main: (145 commits) Enable groups drag'n'drop to new library (JabRef#9460) Update MacOS jabrefHost.py to find local installs (JabRef#9487) Fix remember last open valid library with empty new one (JabRef#9489) Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486) Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485) New Crowdin updates (JabRef#9483) Add log for ignored excepton (JabRef#9302) Select Library to import into (JabRef#9402) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478) Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479) Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480) Bibtex month not deprecated (JabRef#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release Also trigger on branch arm64mac-release ... # Conflicts: # CHANGELOG.md # src/main/java/org/jabref/preferences/JabRefPreferences.java

* upstream/main: (120 commits) Enable groups drag'n'drop to new library (JabRef#9460) Update MacOS jabrefHost.py to find local installs (JabRef#9487) Fix remember last open valid library with empty new one (JabRef#9489) Observable Preferences R (CitationKeyPatternPreferences) (JabRef#9486) Fixed ZBMathTest and extracted keyWordSeparator (JabRef#9485) New Crowdin updates (JabRef#9483) Add log for ignored excepton (JabRef#9302) Select Library to import into (JabRef#9402) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (JabRef#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (JabRef#9478) Bump mockito-core from 4.9.0 to 4.10.0 (JabRef#9479) Bump checkstyle from 10.4 to 10.5.0 (JabRef#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (JabRef#9480) Bibtex month not deprecated (JabRef#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release Also trigger on branch arm64mac-release ...

* upstream/main: (75 commits) Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (#9493) Enable groups drag'n'drop to new library (#9460) Update MacOS jabrefHost.py to find local installs (#9487) Fix remember last open valid library with empty new one (#9489) Observable Preferences R (CitationKeyPatternPreferences) (#9486) Fixed ZBMathTest and extracted keyWordSeparator (#9485) New Crowdin updates (#9483) Add log for ignored excepton (#9302) Select Library to import into (#9402) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (#9478) Bump mockito-core from 4.9.0 to 4.10.0 (#9479) Bump checkstyle from 10.4 to 10.5.0 (#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (#9480) Bibtex month not deprecated (#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release ...

svenjaeger and others added 3 commits August 15, 2017 20:22

Merge pull request #1 from JabRef/master

a3b60e9

take changes from main project

Merge branch 'JabRef:main' into master

9432e0a

Deprecated fields depend on mode

b17d128

koppor marked this pull request as draft November 26, 2022 23:01

ThiloteE added the component: entry-editor label Nov 29, 2022

koppor marked this pull request as ready for review December 12, 2022 23:54

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 12, 2022

svenjaeger and others added 4 commits December 18, 2022 08:22

reformating according to review comment

790b1d9

Merge remote-tracking branch 'origin/main' into bibtex-month-not-depr…

b30dc4c

…ecated

Merge branch 'fix-7757' into bibtex-month-not-deprecated

d20085a

koppor force-pushed the bibtex-month-not-deprecated branch from 771c16c to d20085a Compare December 18, 2022 23:17

Really use mode variable

8ea341a

calixtus changed the title ~~[wip]Bibtex month not deprecated~~ Bibtex month not deprecated Dec 18, 2022

Fix space

c8ebfd0

calixtus approved these changes Dec 18, 2022

View reviewed changes

Siedlerchr approved these changes Dec 18, 2022

View reviewed changes

Siedlerchr merged commit e8c3a42 into JabRef:main Dec 18, 2022

svenjaeger commented Dec 19, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bibtex month not deprecated#9404

Bibtex month not deprecated#9404
Siedlerchr merged 9 commits into
JabRef:mainfrom
svenjaeger:bibtex-month-not-deprecated

svenjaeger commented Nov 25, 2022 •

edited by koppor

Loading

Uh oh!

koppor commented Dec 17, 2022

Uh oh!

koppor commented Dec 18, 2022

Uh oh!

svenjaeger Dec 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

svenjaeger commented Nov 25, 2022 • edited by koppor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koppor commented Dec 17, 2022

BibTeX

biblatex

Uh oh!

koppor commented Dec 18, 2022

Uh oh!

svenjaeger Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

svenjaeger commented Nov 25, 2022 •

edited by koppor

Loading