[WIP] fix-for-issue-4113#4188
Conversation
tobiasdiez
left a comment
There was a problem hiding this comment.
The change in itself looks fine to me. Good job!
Please add a few test cases to PagesCheckerTest which confirm that the issue is indeed fixed.
|
I got it thank you. |
|
|
||
| ### Fixed | ||
| - We fixed an issue about improving check for page numbers. | ||
| (https://github.com/JabRef/jabref/issues/4113) |
* Convert IEEE fetcher to new interface * Move JSON parsing to respective fetcher * Remove obsolete localization keys
* Fix JabRef#4177: New entry dialog freezes no longer * Error messages on JavaFX thread
* Make global font size customizable * Don't be fancy and just use ordinary boolean or * Add missing localization * Add missing localization
* Convert CiteSeerX fetcher to new infrastructure The old implementation first extracted the detail pages for each article matched by the query and then went to every detail page to extract the bibliographic information. Instead, we now parse the COinS information that is already contained in the main result page and thereby reduce the number of requests to 1 per query. * Add additional test
…bref into fix-for-issue-4113
|
It appears that something went wrong and some other commits from master were added to this PR. Can you please rebase/merge the master so that only your changes remain. Thanks. |
|
I am sorry I don't understand. what should I do ? |
|
Have a look at the diff here in github. There is a lot of code that is marked as changed although you didn't touch it. These should vanish when use |
|
I am sorry that I am not familiar with git, so what should I do? |
|
I have previously synchronized the PR with the master. Do I need to roll back the code? |
|
The problem is that this PR contains all kinds of commits that are unrelated to this PR. @1160200515 It would be great if you could fix this. Probably the easiest thing would be to do this in another branch? If this is not possible we will have to close this PR, which would be kinda sad, since this would mean that your contribution will not be included into JabRef. |
|
@1160200515 can you please remove the unrelated commits (maybe a simple git pull upstream master is enough), because otherwise we cannot review and include this PR. Please also add tests. |
|
Superseeded by #4498 |
Refs #4113