Skip to content

Fix not on javafx thread exception in "generate data from doi"#4182

Merged
tobiasdiez merged 1 commit into
masterfrom
fixNotOnFXInDOI
Jul 12, 2018
Merged

Fix not on javafx thread exception in "generate data from doi"#4182
tobiasdiez merged 1 commit into
masterfrom
fixNotOnFXInDOI

Conversation

@tobiasdiez

@tobiasdiez tobiasdiez commented Jul 8, 2018

Copy link
Copy Markdown
Member

And another threading issue fixed...

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 8, 2018
LinusDietz
LinusDietz approved these changes Jul 10, 2018
View reviewed changes

@LinusDietz LinusDietz left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, however you will need to fix travis.

@tobiasdiez tobiasdiez merged commit 618f6d2 into master Jul 12, 2018
@tobiasdiez tobiasdiez deleted the fixNotOnFXInDOI branch July 12, 2018 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@LinusDietz LinusDietz LinusDietz approved these changes

@stefan-kolb stefan-kolb stefan-kolb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasdiez @LinusDietz @stefan-kolb