Convert IEEE fetcher to new interface#4162
Merged
Merged
Conversation
stefan-kolb
reviewed
Jul 12, 2018
| /** | ||
| * @implNote <a href="https://developer.ieee.org/docs/read/Metadata_API_responses">documentation</a> | ||
| */ | ||
| public static BibEntry parseIEEEJSONtoBibtex(JSONObject jsonEntry, Character keywordSeparator) { |
Member
There was a problem hiding this comment.
For me this belongs to the IEEE class.
Member
Author
There was a problem hiding this comment.
Good point. Moved it to the fetcher (as well as the other parsing code in that class)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IEEE fetcher now also fits in the new infrastructure and is converted to use the new IEEE API. The original fetcher performed a quite "sophisticated" cleanup of some fields. I'm not sure if this was needed because of scraping the webpage / a buggy BibTeX export or because the data is inherently faulty. After looking at the JSON response of some queries it appears that these cleanups are no longer necessary.