Fix #4177: New entry dialog freezes no longer#4179
Merged
Conversation
LinusDietz
approved these changes
Jul 10, 2018
LinusDietz
left a comment
Member
There was a problem hiding this comment.
Code-wise it's okay. I think we all know that in the long run we need to get rid of swing...
stefan-kolb
reviewed
Jul 12, 2018
stefan-kolb
left a comment
Member
There was a problem hiding this comment.
We need to rework this dialog in FX asap. I'm ok if some not so important dialogs stay Swing for some time, but for a release we need to have at least the important dialogs and workflows working as expected.
I don't think wrapping all our code in rinInJavaFXThread or Swingworker will help us anymore.
Member
Author
|
Agreed! However, I'll not have so much time in the next 3 weeks, I'll merge now (to have a somewhat working version again). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As usual with these kind of freezes, it was again a problem with the interaction of Swing and JavaFX... it still has the problem that the dialog sometimes opens in the background (I've no idea how to fix it except converting the dialog to JavaFX).