Skip to content

Add claude gitignore#15413

Merged
Siedlerchr merged 2 commits into
mainfrom
add-claude-gitignore
Mar 25, 2026
Merged

Add claude gitignore#15413
Siedlerchr merged 2 commits into
mainfrom
add-claude-gitignore

Conversation

@koppor

@koppor koppor commented Mar 25, 2026

Copy link
Copy Markdown
Member

PR Description

I am trying out https://github.com/tirth8205/code-review-graph for Claude Code.

It generated a file in .claude. Should not be versioned

Steps to test

  1. Install Claude Code
  2. Install https://github.com/tirth8205/code-review-graph
  3. Try out
  4. open git tool
  5. See that no files changed ^^

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • [/] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • [/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 25, 2026
@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Add PR link to issue comment template

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add clickable link to PR statistics in issue comments
• Link directs to user's pull requests on GitHub
Diagram
flowchart LR
  A["Issue Comment Template"] -- "Enhanced with" --> B["PR Statistics Link"]
  B -- "Links to" --> C["User's Pull Requests"]
Loading

Grey Divider

File Changes

1. .github/workflows/on-issue-comment.yml ✨ Enhancement +1/-1

Add PR link to issue comment template

• Modified the assigned issue comment template to include a clickable link to user's pull requests
• Changed PR count display from plain text to markdown link format
• Link wraps the total PR count and directs to user's GitHub pull requests page

.github/workflows/on-issue-comment.yml


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Grey Divider


Remediation recommended

1. Undefined prs_link placeholder 🐞 Bug ⛯ Reliability
Description
The workflow template now uses {{ prs_link }} as a Markdown link URL, but this repository provides
no definition/reference for prs_link. If takanome-dev/assign-issue-action@edge doesn’t supply
that variable, the posted comment will contain a raw/unexpanded placeholder or a broken link in the
PR statistics line.
Code

.github/workflows/on-issue-comment.yml[74]

+            At this point in time, you raised {{ prs_total }} pull request(s) of which {{ prs_merged_percentage }}% ({{ prs_merged }}/[{{ prs_total }}]({{ prs_link }})) have been merged.
Evidence
The edited text is rendered by an external action (takanome-dev/assign-issue-action@edge), so all
{{ ... }} variables must be provided by that action’s template context. In this repo checkout,
prs_link appears only in the modified line, meaning there’s no in-repo producer/definition to
ensure it exists at runtime.

.github/workflows/on-issue-comment.yml[15-18]
.github/workflows/on-issue-comment.yml[68-75]
.github/workflows/on-issue-comment.yml[73-75]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`.github/workflows/on-issue-comment.yml` now uses a new template variable `{{ prs_link }}` inside a markdown link. This variable is not defined/used anywhere else in the repository, so unless the external `takanome-dev/assign-issue-action@edge` action provides it, the comment text will render with a raw placeholder or broken link.

## Issue Context
The template variables (`{{ handle }}`, `{{ prs_total }}`, etc.) are expanded by the external action used in the workflow, not by repository code.

## Fix Focus Areas
- .github/workflows/on-issue-comment.yml[68-75]

## Suggested changes
- Either revert to the previous plain-text denominator (`({{ prs_merged }}/{{ prs_total }})`), or
- Build the PR list link using already-known variables (e.g., a GitHub search URL using `{{ handle }}`), avoiding dependence on an unverified `prs_link`, or
- If `prs_link` is intended and supported, add an explicit reference/documentation/comment pointing to where the action guarantees that output to reduce future breakage.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@testlens-app

testlens-app Bot commented Mar 25, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: f056a8a
▶️ Tests: 10203 executed
⚪️ Checks: 70/70 completed


Learn more about TestLens at testlens.app.

@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 25, 2026
@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Mar 25, 2026
Merged via the queue into main with commit f2cd46c Mar 25, 2026
66 of 73 checks passed
@Siedlerchr Siedlerchr deleted the add-claude-gitignore branch March 25, 2026 18:21
jadegold55 pushed a commit to jadegold55/jabref that referenced this pull request Mar 26, 2026
* Add new prs_link feature

* Add .claude to .gitignore
Siedlerchr added a commit to geovani-rocha/jabref that referenced this pull request Mar 28, 2026
…o fix-group-icons

* 'fix-group-icons' of github.com:geovani-rocha/jabref: (26 commits)
  chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.4 (JabRef#15436)
  chore(deps): update jackson monorepo to v3.1.1 (JabRef#15435)
  Fix PushToPreferences reset and import (JabRef#15395)
  Add fulltext fetcher for Wiley via their TDM API (JabRef#15388)
  Embed in-text nature in reference marks for CSL citations (JabRef#15381)
  Chore(deps): Bump com.gradleup.shadow:shadow-gradle-plugin (JabRef#15430)
  Fix not on fx thread exceptions for cleanup and cite key generator (JabRef#15424)
  Revert "Update gradle to nightly of 2026-03-23 (JabRef#15372)"
  feat: add benchmarks for Lucene fulltext search and linked file indexing, including setup and teardown of the index. (JabRef#15385)
  Chore(deps): Bump org.openrewrite.recipe:rewrite-recipe-bom (JabRef#15418)
  Add claude gitignore (JabRef#15413)
  Fix group filter icon in side pane (JabRef#15408)
  Add new prs_link feature
  Chore(deps): Bump org.glassfish.hk2:hk2-api in /versions (JabRef#15422)
  Chore(deps): Bump org.openrewrite.rewrite from 7.28.2 to 7.29.0 (JabRef#15419)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15417)
  Fix for inconsistent "hide tab bar" behavior (JabRef#15409)
  Update dependency org.glassfish.hk2:hk2-utils to v4 (JabRef#15407)
  Persist file notifications (JabRef#15403)
  Update dependency org.glassfish.hk2:hk2-locator to v4 (JabRef#15405)
  ...
Ranjeet2702 pushed a commit to Ranjeet2702/jabref that referenced this pull request Apr 14, 2026
* Add new prs_link feature

* Add .claude to .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants