Fix PushToPreferences reset and import#15395
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
|
Checkstyle fails because of checkstyle/checkstyle#19342 / checkstyle/checkstyle#17052 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Review Summary by QodoRefactor preferences handling and fix PushToApplicationPreferences reset/import
WalkthroughsDescription• Removed redundant defaultFontSize property from WorkspacePreferences • Refactored PushToApplicationPreferences to use factory pattern with getDefault() and setAll() methods • Consolidated push application path constants into a single Map for maintainability • Fixed preference import/export to properly restore PushToApplicationPreferences state • Moved ImportFormatPreferences and LayoutFormatterPreferences to interface defaults • Removed duplicate VSCode application entry in push applications list Diagramflowchart LR
A["PushToApplicationPreferences"] -->|"getDefault()"| B["Default Instance"]
A -->|"setAll()"| C["Copy State"]
D["JabRefCliPreferences"] -->|"getPushToApplicationPreferencesFromBackingStore()"| E["Load from Storage"]
F["Import/Export"] -->|"restore"| A
G["WorkspacePreferences"] -->|"removed defaultFontSize"| H["Simplified"]
File Changes1. jabgui/src/main/java/org/jabref/gui/WorkspacePreferences.java
|
Code Review by Qodo
1. getCommandPaths() mutated directly
|
✅ All tests passed ✅🏷️ Commit: 40b18aa Learn more about TestLens at testlens.app. |
| <Label text="%Application to push entries to"/> | ||
| <SearchableComboBox fx:id="pushToApplicationCombo" | ||
| prefWidth="200.0" GridPane.columnIndex="1" editable="false"/> | ||
| prefWidth="200.0" GridPane.columnIndex="1"/> |
…o fix-group-icons * 'fix-group-icons' of github.com:geovani-rocha/jabref: (26 commits) chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.4 (JabRef#15436) chore(deps): update jackson monorepo to v3.1.1 (JabRef#15435) Fix PushToPreferences reset and import (JabRef#15395) Add fulltext fetcher for Wiley via their TDM API (JabRef#15388) Embed in-text nature in reference marks for CSL citations (JabRef#15381) Chore(deps): Bump com.gradleup.shadow:shadow-gradle-plugin (JabRef#15430) Fix not on fx thread exceptions for cleanup and cite key generator (JabRef#15424) Revert "Update gradle to nightly of 2026-03-23 (JabRef#15372)" feat: add benchmarks for Lucene fulltext search and linked file indexing, including setup and teardown of the index. (JabRef#15385) Chore(deps): Bump org.openrewrite.recipe:rewrite-recipe-bom (JabRef#15418) Add claude gitignore (JabRef#15413) Fix group filter icon in side pane (JabRef#15408) Add new prs_link feature Chore(deps): Bump org.glassfish.hk2:hk2-api in /versions (JabRef#15422) Chore(deps): Bump org.openrewrite.rewrite from 7.28.2 to 7.29.0 (JabRef#15419) Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15417) Fix for inconsistent "hide tab bar" behavior (JabRef#15409) Update dependency org.glassfish.hk2:hk2-utils to v4 (JabRef#15407) Persist file notifications (JabRef#15403) Update dependency org.glassfish.hk2:hk2-locator to v4 (JabRef#15405) ...
* Initial cleanups * Adapt PushToApplicationPreferences * Fix artifact * Cleanup in WorkspacePreferences * Fix import * Fix and simplify Map of command paths * Fix duplicate VSCode application * Stylistic changes * Fix empty strings in prefs * Fix resetting of application settings * Fix checkstyle --------- Co-authored-by: Carl Christian Snethlage <calixtus@users.noreply.github.com>
Related issues and pull requests
Follow-up to #14410
PR Description
Qodo:
• Removed redundant defaultFontSize property from WorkspacePreferences
• Refactored PushToApplicationPreferences to use factory pattern with getDefault() and setAll() methods
• Consolidated push application path constants into a single Map for maintainability
• Fixed preference import/export to properly restore PushToApplicationPreferences state
• Moved ImportFormatPreferences and LayoutFormatterPreferences to interface defaults
• Removed duplicate VSCode application entry in push applications list
Steps to test
Checklist
CHANGELOG.mdin a way that can be understood by the average user (if change is visible to the user)