Skip to content

Update gradle to nightly of 2026-03-23#15372

Merged
koppor merged 11 commits into
mainfrom
update-gradle
Mar 23, 2026
Merged

Update gradle to nightly of 2026-03-23#15372
koppor merged 11 commits into
mainfrom
update-gradle

Conversation

@koppor

@koppor koppor commented Mar 19, 2026

Copy link
Copy Markdown
Member

PR Description

With gradle/gradle#34227 being merged, we can use the nightly build (and 9.5.0-rc1 as soon as it is out)

https://gradle.org/release-nightly/

Steps to test

See CI passing

Checklist

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/I added screenshots in the PR description (if change is visible to the user)
  • [/] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
  • [/] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
  • [/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Update Gradle to nightly 2026-03-19 and enhance FAQ documentation

✨ Enhancement 📝 Documentation

Grey Divider

Walkthroughs

Description
• Update Gradle to nightly build 9.4.1-20260319034812
• Reorganize FAQ documentation with improved Gradle troubleshooting section
• Add comprehensive Gradle command-line execution guide
• Restructure compilation-related FAQs for better organization
Diagram
flowchart LR
  A["Gradle Wrapper Config"] -->|Update to nightly| B["gradle-9.4.1-20260319034812"]
  C["FAQ Documentation"] -->|Reorganize sections| D["Gradle troubleshooting guide"]
  C -->|Add command-line guide| E["gg.cmd usage instructions"]
  C -->|Restructure| F["Compilation section"]
Loading

Grey Divider

File Changes

1. gradle/wrapper/gradle-wrapper.properties Dependencies +2/-2

Update Gradle wrapper to nightly build

• Update distributionUrl from custom JabRef build to official Gradle nightly snapshot
• Change validateDistributionUrl from false to true for security validation
• Point to gradle-9.4.1-20260319034812+0000-bin.zip from services.gradle.org

gradle/wrapper/gradle-wrapper.properties


2. gradlew Miscellaneous +1/-1

Update Gradle wrapper script template reference

• Update template reference URL to specific Gradle commit hash
• Maintain script functionality with updated source attribution

gradlew


3. docs/code-howtos/faq.md 📝 Documentation +27/-22

Reorganize FAQ with enhanced Gradle documentation

• Move Gradle section to beginning of FAQ for better visibility
• Expand Gradle troubleshooting with detailed error resolution steps
• Add comprehensive guide for running Gradle from command line using gg.cmd
• Reorganize compilation-related FAQs under new "Compilation" section header
• Remove outdated "Sync fork with upstream" GitHub workflow section

docs/code-howtos/faq.md


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Grey Divider


Action required

1. FAQ Gradle section grammar issues📘 Rule violation ⚙ Maintainability
Description
New documentation text contains grammar and capitalization issues (e.g., Gradle builds files,
gradle run, and development versions of gradle). This violates the requirement that user-facing
text be professional and free of typos/grammar errors.
Code

docs/code-howtos/faq.md[R20-35]

+Sometimes, one needs to double-check that there is an IDE setup issue - and not an issue with modified Gradle builds files.
+It is easily possible to run Gradle from the command line without installing a separate JDK manually.
+
+1. Download [gg.cmd](https://github.com/eirikb/gg/releases/latest/download/gg.cmd). [`gg.cmd`](https://github.com/eirikb/gg) is an easy-to-use toolchain downloading all requirements.
+2. Run `gradle`:
+
+   * Linux/macOS: `sh -x ./gg.cmd gradle :jabgui:run`
+   * Windows: `.\gg.cmd gradle :jabgui:run`
+
+---
+
+Alternatively, you can install a JDK 17 (or later) and execute `./gradlew :jabgui:run`.
-To ease development, a GitHub workflow automatically updates your `main` branch daily.
-However, it is not allowed to update your files if the GitHub workflows are updated by the JabRef team.
-Therefore, GitHub notifies you now and then that "Sync fork with upstream failed for main branch".
+### Many errors during gradle run - e.g., `Unresolved reference 'jvmDependencyConflicts'.`
-To solve this issue, open your GitHub repository in your browser.
-Then, click "Sync fork" to get your fork up-to-date and get the workflow passing again.
+Gradle updates are not easy at development versions of gradle.
Evidence
PR Compliance ID 35 requires user-facing text (documentation) to be professional and free of
typos/grammar errors. The added/modified FAQ Gradle section includes multiple wording/capitalization
problems in the referenced lines.

docs/code-howtos/faq.md[20-35]
Best Practice: Learned patterns

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The newly added Gradle FAQ text has grammar/capitalization issues (e.g., `Gradle builds files`, `gradle run`, and `development versions of gradle`), which makes the documentation look unpolished.
## Issue Context
This is user-facing documentation and must be professional and free of typos/grammar errors.
## Fix Focus Areas
- docs/code-howtos/faq.md[20-35]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools



Remediation recommended

2. Empty compilation section🐞 Bug ⚙ Maintainability
Description
In docs/code-howtos/faq.md, the new "Compilation" heading has no content because the next heading is
also level-2, so the intended subsection is not nested and the section hierarchy/TOC becomes
misleading. This appears to be an oversight introduced when adding the new parent "Compilation"
section around the existing entry.
Code

docs/code-howtos/faq.md[R193-197]

+## Compilation
-A: You have to ignore `buildSrc/src/main` as source directory in IntelliJ as indicated in our [setup guide](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace).
+## `java: package org.jabref.logic.journals does not exist`
+
+You have to ignore `buildSrc/src/main` as source directory in IntelliJ as indicated in our [setup guide](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace).
Evidence
The file consistently uses ## for major sections and ### for subsections (e.g., `## Failing
tests followed by ### Failing Checkstyle tests). In the new structure, ## Compilation` is
immediately followed by another ## ... heading, leaving the Compilation section empty and
preventing the java: package ... does not exist entry from being a nested subsection.

docs/code-howtos/faq.md[43-47]
docs/code-howtos/faq.md[193-199]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`## Compilation` is immediately followed by another `##` heading, which makes the `Compilation` section empty and breaks the document hierarchy.
### Issue Context
This section appears to be a new parent grouping for an existing FAQ entry; the child heading should be nested.
### Fix Focus Areas
- docs/code-howtos/faq.md[193-199]
### Suggested change
Change `## \`java: package org.jabref.logic.journals does not exist\`` to `### ...` (and optionally add a short intro line under `## Compilation`).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@koppor koppor added dev: build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Mar 19, 2026
Comment thread docs/code-howtos/faq.md Outdated
@testlens-app

This comment has been minimized.

@testlens-app

This comment has been minimized.

@testlens-app

This comment has been minimized.

@testlens-app

This comment has been minimized.

@koppor koppor changed the title Update gradle to nightly of 2026-03-19 Update gradle to nightly of 2026-03-23 Mar 23, 2026
@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label Mar 23, 2026
jabref-machine
jabref-machine previously approved these changes Mar 23, 2026
@koppor koppor enabled auto-merge March 23, 2026 08:58
@koppor

koppor commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

Validation error filed at gradle/actions#903

@testlens-app

This comment has been minimized.

@testlens-app

testlens-app Bot commented Mar 23, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 5d6a42b
▶️ Tests: 10203 executed
⚪️ Checks: 59/59 completed


Learn more about TestLens at testlens.app.

@koppor koppor added this pull request to the merge queue Mar 23, 2026
@github-actions github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Mar 23, 2026
Merged via the queue into main with commit 57552ee Mar 23, 2026
60 checks passed
@koppor koppor deleted the update-gradle branch March 23, 2026 10:20
koppor added a commit that referenced this pull request Mar 26, 2026
jadegold55 pushed a commit to jadegold55/jabref that referenced this pull request Mar 26, 2026
Siedlerchr added a commit to geovani-rocha/jabref that referenced this pull request Mar 28, 2026
…o fix-group-icons

* 'fix-group-icons' of github.com:geovani-rocha/jabref: (26 commits)
  chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.4 (JabRef#15436)
  chore(deps): update jackson monorepo to v3.1.1 (JabRef#15435)
  Fix PushToPreferences reset and import (JabRef#15395)
  Add fulltext fetcher for Wiley via their TDM API (JabRef#15388)
  Embed in-text nature in reference marks for CSL citations (JabRef#15381)
  Chore(deps): Bump com.gradleup.shadow:shadow-gradle-plugin (JabRef#15430)
  Fix not on fx thread exceptions for cleanup and cite key generator (JabRef#15424)
  Revert "Update gradle to nightly of 2026-03-23 (JabRef#15372)"
  feat: add benchmarks for Lucene fulltext search and linked file indexing, including setup and teardown of the index. (JabRef#15385)
  Chore(deps): Bump org.openrewrite.recipe:rewrite-recipe-bom (JabRef#15418)
  Add claude gitignore (JabRef#15413)
  Fix group filter icon in side pane (JabRef#15408)
  Add new prs_link feature
  Chore(deps): Bump org.glassfish.hk2:hk2-api in /versions (JabRef#15422)
  Chore(deps): Bump org.openrewrite.rewrite from 7.28.2 to 7.29.0 (JabRef#15419)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15417)
  Fix for inconsistent "hide tab bar" behavior (JabRef#15409)
  Update dependency org.glassfish.hk2:hk2-utils to v4 (JabRef#15407)
  Persist file notifications (JabRef#15403)
  Update dependency org.glassfish.hk2:hk2-locator to v4 (JabRef#15405)
  ...
Ranjeet2702 pushed a commit to Ranjeet2702/jabref that referenced this pull request Apr 14, 2026
* Update gradle to nightly of 2026-03-19

* Add FAQ on gradle (and remove outdated FAQ)

* Fix casing

* Add --stop

* Fix header formatting in FAQ section

* Fix capitalization of 'Gradle' in FAQ

* Update search

* Update wrapper

* Restore valid .jar
Ranjeet2702 pushed a commit to Ranjeet2702/jabref that referenced this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge PR is tagged with that label will be merged if workflows are green dev: build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers status: to-be-merged PRs which are accepted and should go into the merge-queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants