Fix for inconsistent "hide tab bar" behavior by alxafan · Pull Request #15409 · JabRef/jabref

alxafan · 2026-03-25T00:37:53Z

Related issues and pull requests

Closes #12680

PR Description

Added listener to "hide tab bar when a single library is present" setting, so that the UI updates on toggle. This fixes the tab bar not showing.
Changed CSS of tab-header-area from collapsing the element, to changing its size to 0. The collapsed element would not be updated correctly and be stuck in a stale state, only updating after another Library was added.

Before:

Screencast.From.2026-03-24.22-56-30.mp4

After:

Screencast.From.2026-03-25.01-29-50.mp4

Screenshot with my name and issue number:

Steps to test

Go through steps of the related issue:

Set preference to true for "Hide tab bar when single library is present"
Create a new library
Change the preference to false.
Now instead of no tab being shown, you should see the expected *untitled tab.

Checklist

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

…is present"

qodo-free-for-open-source-projects · 2026-03-25T00:38:07Z

Review Summary by Qodo

Fix tab bar visibility toggle behavior

🐞 Bug fix

Walkthroughs

Description

• Added listener to "hide tab bar" setting for dynamic UI updates
• Changed CSS from visibility collapse to height-based hiding
• Ensures tab bar properly shows/hides when preference toggled
• Updated CHANGELOG with fix description

Diagram

flowchart LR
  A["hideTabBarProperty listener"] -->|triggers| B["updateTabBarVisible()"]
  B -->|updates| C["tab-header-area CSS"]
  C -->|applies| D["Dynamic height changes"]
  E["CSS visibility:collapse"] -->|replaced by| F["height-based hiding"]

File Changes

1. jabgui/src/main/java/org/jabref/gui/frame/JabRefFrame.java 🐞 Bug fix +1/-0

Add preference listener for tab bar visibility

• Added listener to hideTabBarProperty() that triggers updateTabBarVisible()
• Ensures UI updates when the "hide tab bar when single library" preference is toggled
• Complements existing listeners for database and tab changes

jabgui/src/main/java/org/jabref/gui/frame/JabRefFrame.java

2. jabgui/src/main/resources/org/jabref/gui/Base.css 🐞 Bug fix +3/-1

Replace visibility collapse with height-based hiding

• Replaced visibility: collapse with explicit height properties (-fx-min-height: 0,
 -fx-max-height: 0)
• Added -fx-padding: 0 for consistency
• Fixes stale state issue where collapsed elements wouldn't update correctly

jabgui/src/main/resources/org/jabref/gui/Base.css

3. CHANGELOG.md 📝 Documentation +1/-0

Document tab bar visibility fix

• Added entry documenting the fix for tab bar visibility toggle issue #12680
• Describes the resolved problem in user-friendly language

CHANGELOG.md

qodo-free-for-open-source-projects · 2026-03-25T00:38:08Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

1. ~~Invalid -fx-max-height CSS~~ ☑ 📘 Rule violation ✓ Correctness

Description

The new CSS rule contains a malformed declaration (-fx-min-height: 0;-fx-max-height), which can
cause the JavaFX CSS parser to ignore the rule or behave inconsistently. This risks the tab bar
hide/show state becoming non-reactive or visually incorrect when toggling the preference.

Code

jabgui/src/main/resources/org/jabref/gui/Base.css[R670-671]
+    -fx-min-height: 0;-fx-max-height
+    -fx-max-height: 0;

Evidence
PR Compliance ID 42 requires UI state to remain reactive and consistent; the added CSS includes an
invalid property token that can prevent the intended layout update from applying reliably.
jabgui/src/main/resources/org/jabref/gui/Base.css[670-671]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A malformed JavaFX CSS declaration was introduced in the `hide-tab-bar` rule: `-fx-min-height: 0;-fx-max-height` is not valid CSS and may prevent the rule from applying.
## Issue Context
This CSS rule is part of the fix for inconsistent tab bar visibility, so parsing failures can reintroduce stale/non-reactive UI behavior.
## Fix Focus Areas
- jabgui/src/main/resources/org/jabref/gui/Base.css[670-671]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

testlens-app · 2026-03-25T01:08:05Z

✅ All tests passed ✅

🏷️ Commit: a23510a
▶️ Tests: 10203 executed
⚪️ Checks: 52/52 completed

Learn more about TestLens at testlens.app.

…o fix-group-icons * 'fix-group-icons' of github.com:geovani-rocha/jabref: (26 commits) chore(deps): update dependency org.apache.logging.log4j:log4j-to-slf4j to v2.25.4 (JabRef#15436) chore(deps): update jackson monorepo to v3.1.1 (JabRef#15435) Fix PushToPreferences reset and import (JabRef#15395) Add fulltext fetcher for Wiley via their TDM API (JabRef#15388) Embed in-text nature in reference marks for CSL citations (JabRef#15381) Chore(deps): Bump com.gradleup.shadow:shadow-gradle-plugin (JabRef#15430) Fix not on fx thread exceptions for cleanup and cite key generator (JabRef#15424) Revert "Update gradle to nightly of 2026-03-23 (JabRef#15372)" feat: add benchmarks for Lucene fulltext search and linked file indexing, including setup and teardown of the index. (JabRef#15385) Chore(deps): Bump org.openrewrite.recipe:rewrite-recipe-bom (JabRef#15418) Add claude gitignore (JabRef#15413) Fix group filter icon in side pane (JabRef#15408) Add new prs_link feature Chore(deps): Bump org.glassfish.hk2:hk2-api in /versions (JabRef#15422) Chore(deps): Bump org.openrewrite.rewrite from 7.28.2 to 7.29.0 (JabRef#15419) Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#15417) Fix for inconsistent "hide tab bar" behavior (JabRef#15409) Update dependency org.glassfish.hk2:hk2-utils to v4 (JabRef#15407) Persist file notifications (JabRef#15403) Update dependency org.glassfish.hk2:hk2-locator to v4 (JabRef#15405) ...

* Fix tab bar update when toggling "Hide tab bar when a single library is present" * Add CHANGELOG message * Fix malformed CSS declaration

alxafan added 2 commits March 25, 2026 00:52

Fix tab bar update when toggling "Hide tab bar when a single library …

b8e9e92

…is present"

Add CHANGELOG message

a851613

github-actions Bot added good second issue Issues that involve a tour of two or three interweaved components in JabRef component: ui labels Mar 25, 2026

qodo-free-for-open-source-projects Bot reviewed Mar 25, 2026

View reviewed changes

Comment thread jabgui/src/main/resources/org/jabref/gui/Base.css Outdated

github-actions Bot added the status: no-bot-comments label Mar 25, 2026

This comment has been minimized.

Sign in to view

github-actions Bot mentioned this pull request Mar 25, 2026

No tab shown when untitled tab is created #12680

Closed

2 tasks

Fix malformed CSS declaration

a23510a

calixtus approved these changes Mar 25, 2026

View reviewed changes

calixtus added this pull request to the merge queue Mar 25, 2026

github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Mar 25, 2026

Merged via the queue into JabRef:main with commit 6b59bec Mar 25, 2026
52 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix for inconsistent "hide tab bar" behavior#15409

Fix for inconsistent "hide tab bar" behavior#15409
calixtus merged 3 commits into
JabRef:mainfrom
alxafan:fix-for-issue-12680

alxafan commented Mar 25, 2026 •

edited

Loading

Uh oh!

qodo-free-for-open-source-projects Bot commented Mar 25, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

This comment has been minimized.

testlens-app Bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

alxafan commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues and pull requests

PR Description

Before:

After:

Steps to test

Checklist

Uh oh!

qodo-free-for-open-source-projects Bot commented Mar 25, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

Uh oh!

This comment has been minimized.

testlens-app Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All tests passed ✅

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alxafan commented Mar 25, 2026 •

edited

Loading

qodo-free-for-open-source-projects Bot commented Mar 25, 2026 •

edited

Loading

testlens-app Bot commented Mar 25, 2026 •

edited

Loading